[Hub Generated] Review request for Microsoft.MachineLearningServices to add version stable/2022-05-01 #18645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2019-10-01 to version 2022-05-01
- Update discriminator values from PascalCase to snake_case - Remove job schedules - Add MLTable
|
Hi, @erjms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json#L5811 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json#L5897 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json#L7469 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json#L7786 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json#L8622 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json#L8713 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3142 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3243 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3551 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3725 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3746 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3814 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3857 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3877 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L5466 |
The following errors/warnings exist before current PR submission:
Only 15 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Collection object 'AmlComputeNodesInformation' returned by list operation 'Compute_ListNodes' with 'x-ms-pageable' extension, has no property named 'value'. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L1031 |
| Since operation 'Quotas_Update' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L567 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3338 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L3892 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L4162 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L5646 |
|
| Based on the response model schema, operation 'VirtualMachineSizes_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L519 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L1459 |
|
| Based on the response model schema, operation 'Workspaces_ListOutboundNetworkDependenciesEndpoints' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L1821 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L713 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L759 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L812 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L893 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L947 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json#L1009 |
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/stable/2021-07-01/workspaceSkus.json |
| The JSON file has a circular reference. readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/stable/2022-05-01/machineLearningServices.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌ModelValidation: 10 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 45 Errors, 319 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-05-01/machineLearningServices.json compared with base:stable/2021-07-01/machineLearningServices.json
- current:stable/2022-05-01/machineLearningServices.json compared with base:preview/2022-02-01-preview/machineLearningServices.json
- current:stable/2022-05-01/mfe.json compared with base:preview/2022-02-01-preview/mfe.json
- current:stable/2022-05-01/workspaceFeatures.json compared with base:stable/2021-07-01/workspaceFeatures.json
- current:stable/2022-05-01/workspaceFeatures.json compared with base:preview/2022-02-01-preview/workspaceFeatures.json
Only 15 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 15 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌PoliCheck: 0 Errors, 0 Warnings failed [Detail]
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @erjms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 11, 2022
erjms
added
DoNotMerge
|
Hi, @erjms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
erjms
removed
the
WaitForARMFeedback
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
erjms
force-pushed
the
dev-machinelearning-Microsoft.MachineLearning-2022-05-01
branch
from
1d60367 to
ee1fe5b
Compare
…eLearning-2022-05-01-fixScheduleBase Add ScheduleBase types to machineLearningServices.json
This was referenced Apr 12, 2022
ArcturusZhang
requested changes
May 25, 2022
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2022-05-01/mfe.json
Outdated
Show resolved
Hide resolved
ruowan
approved these changes
May 25, 2022
ArcturusZhang
approved these changes
May 25, 2022
This was referenced May 25, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
May 25, 2022
…r Microsoft.MachineLearningServices to add version stable/2022-05-01 (#2385) Create to sync Azure/azure-rest-api-specs#18645 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/machinelearningservices?expand=1)
This was referenced May 25, 2022
gargankit-microsoft
pushed a commit
that referenced
this pull request
May 26, 2022
…to add version stable/2022-05-01 (#18645) * Adds base for updating Microsoft.MachineLearning from version stable/2019-10-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * add 2022-05-01 mfe.json * add 2022-02-01-preview mls.json * add workspaceFeatures.json from 2022-02-01-preview * add example files * update readme * Update mfe spec - Update discriminator values from PascalCase to snake_case - Remove job schedules - Add MLTable * Add ScheduleBase types to machineLearningServices.json * Updated custom-words.txt * Update examples * Update readme * add workspace connection v2 changes * Update readme * Update readme * fix example validation error * Update mfe swagger * Updated examples * Moved 2022-05-01 specs from machinelearning to machinelearningservices * Update readme * port 2022-02-01-preview mfe.json Schedule to machineLearningServices.json * update example w/ provisioningState * Rename workspace connection related auth type * description change to try to trigger pipelines * Revert "description change to try to trigger pipelines" This reverts commit 899cb59. * update missed common-types v2 -> v3 * Remove unnecessary Credentials properties * fix propertyBag schema * add x-ms-secret * remove checkNameAvailability api * remove traffic property from PartialOnlineEndpoint * prettier * Revert "port 2022-02-01-preview mfe.json Schedule to machineLearningServices.json" This reverts commit 4268210. * add v1LegacyMode to workpsace properties. * update description and add default value. * update description * [MLC] label sslConfiguration and virtualMachineImage as nullable * reduce PATCH to bare minimum * update examples w/ new spec * [MLC] Mark as null-able for properties Getting API * TEST enum as x-nullable * Revert "TEST enum as x-nullable" This reverts commit 616291c. * [MLC] Mark as null-able for properties of List API * remove x-nullable from properties with defaults * description update * enum ordering * fix XmsEnumValidation error for MLC * change x-ms-enum name of SSLConfiguration * update descriptions * change x-ms-client-name 'Details' to 'Properties' * removed x-ms-client-name 'Data' suffix * reorder SecretsType enum Co-authored-by: Teddy <[email protected]> Co-authored-by: zhaomuzhi <[email protected]> Co-authored-by: Xi Jin <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: Teddy Todorov <[email protected]> Co-authored-by: Bingchen Li <[email protected]>
11 tasks
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
May 2022
May 2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.