Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Back action UpdateHostname and UploadCertificate #1861

Merged
merged 6 commits into from
Oct 18, 2017

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Oct 13, 2017

We need to support updatehostname and uploadcertificate actions for one more version, to avoid customers breaking change in powershell which is built on .NET client.

These actions will be deprecated in next apiversion

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 22
After the PR: Warning(s): 0 Error(s): 24

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@solankisamir
Copy link
Member Author

@sarangan12 ping!

@sarangan12
Copy link
Member

@solankisamir Please take a look at https://travis-ci.org/Azure/azure-rest-api-specs/jobs/287657498. Your changes have caused 2 new errors which must be fixed. Please fix them and update PR

@solankisamir
Copy link
Member Author

@sarangan12 I will fix the description issue, but the other issue around certificate_password naming, we had to bring back, as we need that resource in our .NET Client, which gets integrated to powershell. To make a breaking change in powershell, we need it around for one more version.

@solankisamir
Copy link
Member Author

Opened issue on self #1881

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 22
After the PR: Warning(s): 0 Error(s): 23

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@solankisamir
Copy link
Member Author

@sarangan12 ping! on this. Let me know, if I am not clear.

@sarangan12 sarangan12 merged commit 7887c45 into Azure:current Oct 18, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants