Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add List Secrets for Dapr Components #18436

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add List Secrets for Dapr Components #18436

merged 1 commit into from
Apr 6, 2022

Conversation

vusause
Copy link
Contributor

@vusause vusause commented Mar 28, 2022 •
edited by leni-msft
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Note: This API has not been added yet and is a non-breaking change

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vusause Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.App/stable/2022-03-01/DaprComponents.json#L235:5
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Container Apps Secrets
    Location: Microsoft.App/stable/2022-03-01/DaprComponents.json#L281


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'daprComponents' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation.
    Location: Microsoft.App/stable/2022-03-01/DaprComponents.json#L311
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armapp - 0.1.0
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-app - 1.0.0b1
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 896960a. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-app        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsOperations.begin_update
info	[Changelog]   - Added operation DaprComponentsOperations.list_secrets
info	[Changelog]   - Added operation ManagedEnvironmentsOperations.begin_update
info	[Changelog]   - Added operation group NamespacesOperations
info	[Changelog]   - Model GithubActionConfiguration has a new parameter context_path
info	[Changelog]   - Model GithubActionConfiguration has a new parameter image
info	[Changelog]   - Model TrafficWeight has a new parameter label
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model GithubActionConfiguration no longer has parameter dockerfile_path
info	[Changelog]   - Operation ContainerAppsRevisionsOperations.list_revisions has a new signature
info	[Changelog]   - Removed operation ContainerAppsOperations.update
info	[Changelog]   - Removed operation ManagedEnvironmentsOperations.update
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]  
  
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 896960a. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armapp        [View full logs]         [Release SDK Changes]      
            Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `DaprComponentsClientListSecretsResponse`
info	[Changelog] - New struct `DaprComponentsClientListSecretsResult`
info	[Changelog] - New struct `DaprComponentsCollection`
info	[Changelog] - New struct `DaprMetadata`
info	[Changelog] - New struct `DaprSecretsCollection`
info	[Changelog] - New struct `DefaultAuthorizationPolicy`
info	[Changelog] - New struct `DefaultErrorResponse`
info	[Changelog] - New struct `DefaultErrorResponseError`
info	[Changelog] - New struct `DefaultErrorResponseErrorDetailsItem`
info	[Changelog] - New struct `EnvironmentVar`
info	[Changelog] - New struct `Facebook`
info	[Changelog] - New struct `ForwardProxy`
info	[Changelog] - New struct `GitHub`
info	[Changelog] - New struct `GithubActionConfiguration`
info	[Changelog] - New struct `GlobalValidation`
info	[Changelog] - New struct `Google`
info	[Changelog] - New struct `HTTPScaleRule`
info	[Changelog] - New struct `HTTPSettings`
info	[Changelog] - New struct `HTTPSettingsRoutes`
info	[Changelog] - New struct `IdentityProviders`
info	[Changelog] - New struct `Ingress`
info	[Changelog] - New struct `JwtClaimChecks`
info	[Changelog] - New struct `LogAnalyticsConfiguration`
info	[Changelog] - New struct `Login`
info	[Changelog] - New struct `LoginRoutes`
info	[Changelog] - New struct `LoginScopes`
info	[Changelog] - New struct `LogsConfiguration`
info	[Changelog] - New struct `ManagedEnvironment`
info	[Changelog] - New struct `ManagedEnvironmentProperties`
info	[Changelog] - New struct `ManagedEnvironmentStorage`
info	[Changelog] - New struct `ManagedEnvironmentStorageProperties`
info	[Changelog] - New struct `ManagedEnvironmentStoragesCollection`
info	[Changelog] - New struct `ManagedEnvironmentsClient`
info	[Changelog] - New struct `ManagedEnvironmentsClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientBeginDeleteOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientBeginUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePoller`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePoller`
info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientDeleteResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientGetOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientGetResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientGetResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupPager`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionPager`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientUpdatePoller`
info	[Changelog] - New struct `ManagedEnvironmentsClientUpdatePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsCollection`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClient`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResult`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResult`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResult`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `NamespacesClient`
info	[Changelog] - New struct `NamespacesClientCheckNameAvailabilityOptions`
info	[Changelog] - New struct `NamespacesClientCheckNameAvailabilityResponse`
info	[Changelog] - New struct `NamespacesClientCheckNameAvailabilityResult`
info	[Changelog] - New struct `Nonce`
info	[Changelog] - New struct `OpenIDConnectClientCredential`
info	[Changelog] - New struct `OpenIDConnectConfig`
info	[Changelog] - New struct `OpenIDConnectLogin`
info	[Changelog] - New struct `OpenIDConnectRegistration`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsClientListOptions`
info	[Changelog] - New struct `OperationsClientListPager`
info	[Changelog] - New struct `OperationsClientListResponse`
info	[Changelog] - New struct `OperationsClientListResult`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New struct `QueueScaleRule`
info	[Changelog] - New struct `Registration`
info	[Changelog] - New struct `RegistryCredentials`
info	[Changelog] - New struct `RegistryInfo`
info	[Changelog] - New struct `Replica`
info	[Changelog] - New struct `ReplicaCollection`
info	[Changelog] - New struct `ReplicaContainer`
info	[Changelog] - New struct `ReplicaProperties`
info	[Changelog] - New struct `Resource`
info	[Changelog] - New struct `Revision`
info	[Changelog] - New struct `RevisionCollection`
info	[Changelog] - New struct `RevisionProperties`
info	[Changelog] - New struct `Scale`
info	[Changelog] - New struct `ScaleRule`
info	[Changelog] - New struct `ScaleRuleAuth`
info	[Changelog] - New struct `Secret`
info	[Changelog] - New struct `SecretsCollection`
info	[Changelog] - New struct `SourceControl`
info	[Changelog] - New struct `SourceControlCollection`
info	[Changelog] - New struct `SourceControlProperties`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `Template`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New struct `TrafficWeight`
info	[Changelog] - New struct `Twitter`
info	[Changelog] - New struct `TwitterRegistration`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New struct `VnetConfiguration`
info	[Changelog] - New struct `Volume`
info	[Changelog] - New struct `VolumeMount`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 846 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 896960a. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-app        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Namespaces
info	[Changelog]   - Added operation ContainerApps.beginUpdate
info	[Changelog]   - Added operation ContainerApps.beginUpdateAndWait
info	[Changelog]   - Added operation DaprComponents.listSecrets
info	[Changelog]   - Added operation ManagedEnvironments.beginUpdate
info	[Changelog]   - Added operation ManagedEnvironments.beginUpdateAndWait
info	[Changelog]   - Added Interface CheckNameAvailabilityRequest
info	[Changelog]   - Added Interface CheckNameAvailabilityResponse
info	[Changelog]   - Added Interface DaprComponentsListSecretsOptionalParams
info	[Changelog]   - Added Interface DaprSecretsCollection
info	[Changelog]   - Added Interface NamespacesCheckNameAvailabilityOptionalParams
info	[Changelog]   - Added Type Alias CheckNameAvailabilityReason
info	[Changelog]   - Added Type Alias DaprComponentsListSecretsResponse
info	[Changelog]   - Added Type Alias NamespacesCheckNameAvailabilityResponse
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface ContainerAppsUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface ContainerAppsUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter contextPath
info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter image
info	[Changelog]   - Interface ManagedEnvironmentsUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface ManagedEnvironmentsUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface TrafficWeight has a new optional parameter label
info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter namespaces
info	[Changelog]   - Added Enum KnownCheckNameAvailabilityReason
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation ContainerApps.update
info	[Changelog]   - Removed operation ManagedEnvironments.update
info	[Changelog]   - Interface GithubActionConfiguration no longer has parameter dockerfilePath
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 896960a. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️app        [View full logs]       
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    NewApiVersionRequired reason:
     
    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.  

     EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Mar 28, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Mar 28, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    
    
    
    
      
    
    
    
    

      

          @openapi-workflow-bot
openapi-workflow-bot
bot



          added
  the 

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required
 label


      Mar 29, 2022

    
    
  
    





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi, @vusause your PR are labelled with  WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @JeffreyRichter
JeffreyRichter




          added
  the 

  Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
 label


      Apr 1, 2022

    
    
  
    





    

      
    
  
        
    
  
    
      
    
  rkmanda
  
    
  
              
    
            
                  rkmanda
  

            

            approved these changes


            
                
                  Apr 2, 2022
                
            
            
          
    

          
    


              
    View reviewed changes
  


          
    

    

    
          
    
  
  
  
                  
    
                        
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    
    
      @rkmanda

      
            rkmanda
  

      

      

      left a comment




      
    
    

  
    

    
                    

                        
    
  
    
  
 
    
  
    

    
    Choose a reason for hiding this comment
    

    
    
      The reason will be displayed to describe this comment to others. Learn more.
    
    

    
    
      
      

    

  

    

  
    
    
      
    :shipit:
    
    
    
      
  

    


                      
    
                    
  
    
    
  
    
    

  
    
  
    


    
                        
    
                      
                    
    


    

    

    
      
    
  
  
  
    

    

      
    

    



    

      
    
  
            
    
    
    
      
    
    
    
    

      

          @rkmanda
rkmanda




            added
      

  ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review

    and removed
      

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required

  labels


      Apr 2, 2022

    
    
  
    


  
    
  
    
    
  
    
  
    


        @leni-msft
  leni-msft



        merged commit 896960a
      into

      
  
    Azure:main
  


    Apr 6, 2022

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced Apr 6, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  

    
  
    
  
  
    
    
  FredericHeem 

      pushed a commit
        to grucloud/azure-rest-api-specs
      that referenced
      this pull request

    
      May 16, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @vusause
      
        @FredericHeem
  
    

    


      
    
        
          Add List Secrets for Dapr Components (Azure#18436)
        


      
    

      
    
          

    
    
    

  

      
    

      
    
      
    

      
      
    
        
          3d8c703
        
      
    
    
    
  
    

    

    
    
  
    

    

  
  



    





  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @rkmanda
  
    rkmanda



          
            
              
            
          
          rkmanda approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @leni-msft
  
    leni-msft
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
  

    ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review
  

    CI-BreakingChange-JavaScript



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      4 participants
    
    
    
    
        
          @vusause 
        
          @rkmanda 
        
          @JeffreyRichter 
        
          @leni-msft