Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Media to add version stable/2021-11-01 #18435

Merged
merged 5 commits into from
Jun 21, 2022
Merged

[Hub Generated] Review request for Microsoft.Media to add version stable/2021-11-01 #18435

merged 5 commits into from
Jun 21, 2022

Conversation

giakas
Copy link
Contributor

@giakas giakas commented Mar 28, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @giakas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022

    Swagger Validation Report

    ️❌BreakingChange: 13 Errors, 0 Warnings failed [Detail]
    Rule Message
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L881:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L912:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L952:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1193:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1243:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1296:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1340:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1390:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1434:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1589:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1639:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1693:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1759:5
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'MediaServiceOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1694


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L298
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L882
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1297
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1391
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MediaServiceProperties' for property 'mediaServiceId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L409
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MediaServiceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L630
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UserAssignedManagedIdentity' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L656
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L64
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L196
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L302
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L334
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useSystemAssignedIdentity
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L700
    ⚠️ R4000 - ParameterDescriptionRequired 'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1373
    ⚠️ R4000 - ParameterDescriptionRequired 'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1467
    ⚠️ R4000 - ParameterDescriptionRequired 'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1515
    ⚠️ R4000 - ParameterDescriptionRequired 'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1572
    ⚠️ R4021 - DescriptionAndTitleMissing 'storageAuthentication' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L423
    ⚠️ R4021 - DescriptionAndTitleMissing 'ListEdgePoliciesInput' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L569
    ⚠️ R4021 - DescriptionAndTitleMissing 'EdgeUsageDataEventHub' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L578
    ⚠️ R4021 - DescriptionAndTitleMissing 'EdgeUsageDataCollectionPolicy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L595
    ⚠️ R4021 - DescriptionAndTitleMissing 'EdgePolicies' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L616
    ⚠️ R4021 - DescriptionAndTitleMissing 'MediaServiceIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L624
    ⚠️ R4021 - DescriptionAndTitleMissing 'UserAssignedManagedIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L654
    ⚠️ R4021 - DescriptionAndTitleMissing 'KeyVaultProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L680
    ⚠️ R4021 - DescriptionAndTitleMissing 'ResourceIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L694
    ⚠️ R4021 - DescriptionAndTitleMissing 'AccountEncryption' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L710
    ⚠️ R4021 - DescriptionAndTitleMissing 'AccessControl' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L753
    ⚠️ R4021 - DescriptionAndTitleMissing 'KeyDelivery' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L787
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List all Media Services accounts
    Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1789
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armmediaservices - 2.0.0
    +	Function `*Client.CreateOrUpdate` has been removed
    +	Function `*Client.Update` has been removed
    +	Struct `ClientCreateOrUpdateOptions` has been removed
    +	Struct `ClientUpdateOptions` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-media - 9.0.0
    +	Removed operation MediaservicesOperations.create_or_update
    +	Removed operation MediaservicesOperations.update
    azure-sdk-for-js - @azure/arm-mediaservices - 12.0.0
    +	Removed operation Mediaservices.createOrUpdate
    +	Removed operation Mediaservices.update
    ️✔️azure-sdk-for-go - mediaservices/mgmt/2021-11-01/media - v65.0.0
    ️✔️azure-sdk-for-go - mediaservices/mgmt/2021-06-01/media - v65.0.0
    ️✔️azure-sdk-for-go - mediaservices/mgmt/2021-05-01/media - v65.0.0
    ️✔️azure-sdk-for-go - mediaservices/mgmt/2020-05-01/media - v65.0.0
    ️✔️azure-sdk-for-go - mediaservices/mgmt/2018-07-01/media - v65.0.0
    ️✔️azure-sdk-for-go - mediaservices/mgmt/2015-10-01/media - v65.0.0
    ️✔️azure-sdk-for-go - preview/mediaservices/mgmt/2019-05-01-preview/media - v65.0.0
    ️✔️azure-sdk-for-go - preview/mediaservices/mgmt/2018-06-01-preview/media - v65.0.0
    ️✔️azure-sdk-for-go - preview/mediaservices/mgmt/2018-03-30-preview/media - v65.0.0
    azure-sdk-for-go - armmediaservices - 2.0.0
    +	Function `*Client.CreateOrUpdate` has been removed
    +	Function `*Client.Update` has been removed
    +	Struct `ClientCreateOrUpdateOptions` has been removed
    +	Struct `ClientUpdateOptions` has been removed
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 96e52e2. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mediaservices/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 96e52e2. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-media [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation MediaservicesOperations.begin_create_or_update
      info	[Changelog]   - Added operation MediaservicesOperations.begin_update
      info	[Changelog]   - Added operation group MediaServiceOperationResultsOperations
      info	[Changelog]   - Added operation group MediaServiceOperationStatusesOperations
      info	[Changelog]   - Model MediaService has a new parameter private_endpoint_connections
      info	[Changelog]   - Model MediaService has a new parameter provisioning_state
      info	[Changelog]   - Model MediaServiceUpdate has a new parameter private_endpoint_connections
      info	[Changelog]   - Model MediaServiceUpdate has a new parameter provisioning_state
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation MediaservicesOperations.create_or_update
      info	[Changelog]   - Removed operation MediaservicesOperations.update
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 96e52e2. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
    • ️✔️azure-resourcemanager-mediaservices [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 96e52e2. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armmediaservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*Client.Update` has been removed
      info	[Changelog] - Function `*Client.CreateOrUpdate` has been removed
      info	[Changelog] - Struct `ClientCreateOrUpdateOptions` has been removed
      info	[Changelog] - Struct `ClientUpdateOptions` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `ProvisioningState` in struct `MediaServiceProperties`
      info	[Changelog] - New field `PrivateEndpointConnections` in struct `MediaServiceProperties`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 1 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 96e52e2. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-mediaservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group MediaServiceOperationResults
      info	[Changelog]   - Added operation group MediaServiceOperationStatuses
      info	[Changelog]   - Added operation Mediaservices.beginCreateOrUpdate
      info	[Changelog]   - Added operation Mediaservices.beginCreateOrUpdateAndWait
      info	[Changelog]   - Added operation Mediaservices.beginUpdate
      info	[Changelog]   - Added operation Mediaservices.beginUpdateAndWait
      info	[Changelog]   - Added Interface MediaServiceOperationResultsGetHeaders
      info	[Changelog]   - Added Interface MediaServiceOperationResultsGetOptionalParams
      info	[Changelog]   - Added Interface MediaServiceOperationStatus
      info	[Changelog]   - Added Interface MediaServiceOperationStatusesGetOptionalParams
      info	[Changelog]   - Added Interface MediaservicesCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface MediaservicesUpdateHeaders
      info	[Changelog]   - Added Type Alias MediaServiceOperationResultsGetResponse
      info	[Changelog]   - Added Type Alias MediaServiceOperationStatusesGetResponse
      info	[Changelog]   - Interface AzureMediaServicesOptionalParams has a new optional parameter apiVersion
      info	[Changelog]   - Interface MediaservicesCreateOrUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface MediaservicesCreateOrUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface MediaservicesUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface MediaservicesUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface MediaServiceUpdate has a new optional parameter privateEndpointConnections
      info	[Changelog]   - Interface MediaServiceUpdate has a new optional parameter provisioningState
      info	[Changelog]   - Class AzureMediaServices has a new parameter apiVersion
      info	[Changelog]   - Class AzureMediaServices has a new parameter mediaServiceOperationResults
      info	[Changelog]   - Class AzureMediaServices has a new parameter mediaServiceOperationStatuses
      info	[Changelog]   - Add parameters of MediaservicesCreateOrUpdateHeaders to TypeAlias MediaservicesCreateOrUpdateResponse
      info	[Changelog]   - Add parameters of MediaservicesUpdateHeaders to TypeAlias MediaservicesUpdateResponse
      info	[Changelog]   - Type Alias MediaService has a new parameter provisioningState
      info	[Changelog]   - Type Alias MediaService has a new parameter privateEndpointConnections
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation Mediaservices.createOrUpdate
      info	[Changelog]   - Removed operation Mediaservices.update
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 96e52e2. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️mediaservices [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 96e52e2. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.mediaservices [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @giakas, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @giakas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 25, 2022
    Copy link

    @raosuhas raosuhas left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @raosuhas raosuhas added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 28, 2022
    @ghost
    Copy link

    ghost commented May 15, 2022

    Hi, @giakas. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @giakas
    Copy link
    Contributor Author

    giakas commented Jun 3, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @giakas
    Copy link
    Contributor Author

    giakas commented Jun 16, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants