-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Media to add version stable/2021-11-01 #18435
[Hub Generated] Review request for Microsoft.Media to add version stable/2021-11-01 #18435
Conversation
…on change. can be ignored for review.
Hi, @giakas Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L881:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L912:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L952:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1193:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1243:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1296:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1340:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1390:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1434:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1589:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1639:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1693:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-11-01/Accounts.json#L1759:5 |
️⚠️
LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
Rule | Message |
---|---|
The operation 'MediaServiceOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1694 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L298 |
|
Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L882 |
|
Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1297 |
|
Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1391 |
|
Guid used in model definition 'MediaServiceProperties' for property 'mediaServiceId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L409 |
|
Guid used in model definition 'MediaServiceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L630 |
|
Guid used in model definition 'UserAssignedManagedIdentity' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L656 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L64 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L196 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L302 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L334 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useSystemAssignedIdentity Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L700 |
|
'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1373 |
|
'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1467 |
|
'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1515 |
|
'name' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1572 |
|
'storageAuthentication' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L423 |
|
'ListEdgePoliciesInput' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L569 |
|
'EdgeUsageDataEventHub' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L578 |
|
'EdgeUsageDataCollectionPolicy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L595 |
|
'EdgePolicies' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L616 |
|
'MediaServiceIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L624 |
|
'UserAssignedManagedIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L654 |
|
'KeyVaultProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L680 |
|
'ResourceIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L694 |
|
'AccountEncryption' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L710 |
|
'AccessControl' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L753 |
|
'KeyDelivery' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L787 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List all Media Services accounts Location: Microsoft.Media/stable/2021-11-01/Accounts.json#L1789 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Hi @giakas, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
Hi @giakas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
specification/mediaservices/resource-manager/Microsoft.Media/stable/2021-11-01/Accounts.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @giakas. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…t.Media to add version stable/2021-11-01 (#2435) Create to sync Azure/azure-rest-api-specs#18435 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/mediaservices?expand=1)
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.