refactor sc properties in 03-01 #18343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @xwang971 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'sourcecontrols' with immediate parent 'ContainerApp', must have a list by immediate parent operation. Location: Microsoft.App/preview/2022-01-01-preview/SourceControls.json#L264 |
|
| The child tracked resource, 'sourcecontrols' with immediate parent 'ContainerApp', must have a list by immediate parent operation. Location: Microsoft.App/stable/2022-03-01/SourceControls.json#L264 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2022-03-01/SourceControls.json compared with base:preview/2022-01-01-preview/SourceControls.json
| Rule | Message |
|---|---|
| The new version is missing a property found in the old version. Was 'dockerfilePath' renamed or removed? New: Microsoft.App/stable/2022-03-01/SourceControls.json#L312:7 Old: Microsoft.App/preview/2022-01-01-preview/SourceControls.json#L312:7 |
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
This reverts commit 4fe86bc.
|
@chunyu3 This PR is part of reverting breaking changes on the released api-version:https://github.com/Azure/azure-rest-api-specs/pull/18137. Could you approve it? |
msyyc
pushed a commit
that referenced
this pull request
Mar 25, 2022
* Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * refactore properties (#18137) * [Non Break Change]Update to use easy auth v2 same as Web App (#18143) (#18217) * Update auth config to use the same auth config in App Service * Update for spell check * Remove TokenStore/ConfigFilePath as not supported for ContainerApp * Copy AuthConfig from previous version (#18221) * Copy updated AuthConfig from previous version * Add suppression * Add API for checkNameAvailability in 2022-03-01 (#18204) * add API * update * fix * update * update * Add label property (#18280) * Add label property * fix prettier Co-authored-by: Juliehzl <[email protected]> * refactor sc properties in 03-01 (#18343) * refactor sc properties in 03-01 * Revert "refactore properties (#18137)" This reverts commit 4fe86bc. * add odata query (#18364) * Updating patch spec. (#18354) * Updating patch spec. * Fix linter * prettier fix * Adding x-ms-long-running-operation Co-authored-by: Ruslan Yakushev 🚴 <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> Co-authored-by: erich-wang <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: Vaclav Turecek <[email protected]>
visingl
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * refactore properties (#18137) * [Non Break Change]Update to use easy auth v2 same as Web App (#18143) (#18217) * Update auth config to use the same auth config in App Service * Update for spell check * Remove TokenStore/ConfigFilePath as not supported for ContainerApp * Copy AuthConfig from previous version (#18221) * Copy updated AuthConfig from previous version * Add suppression * Add API for checkNameAvailability in 2022-03-01 (#18204) * add API * update * fix * update * update * Add label property (#18280) * Add label property * fix prettier Co-authored-by: Juliehzl <[email protected]> * refactor sc properties in 03-01 (#18343) * refactor sc properties in 03-01 * Revert "refactore properties (#18137)" This reverts commit 4fe86bc. * add odata query (#18364) * Updating patch spec. (#18354) * Updating patch spec. * Fix linter * prettier fix * Adding x-ms-long-running-operation Co-authored-by: Ruslan Yakushev 🚴 <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> Co-authored-by: erich-wang <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: Vaclav Turecek <[email protected]>
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * refactore properties (Azure#18137) * [Non Break Change]Update to use easy auth v2 same as Web App (Azure#18143) (Azure#18217) * Update auth config to use the same auth config in App Service * Update for spell check * Remove TokenStore/ConfigFilePath as not supported for ContainerApp * Copy AuthConfig from previous version (Azure#18221) * Copy updated AuthConfig from previous version * Add suppression * Add API for checkNameAvailability in 2022-03-01 (Azure#18204) * add API * update * fix * update * update * Add label property (Azure#18280) * Add label property * fix prettier Co-authored-by: Juliehzl <[email protected]> * refactor sc properties in 03-01 (Azure#18343) * refactor sc properties in 03-01 * Revert "refactore properties (Azure#18137)" This reverts commit 4fe86bc. * add odata query (Azure#18364) * Updating patch spec. (Azure#18354) * Updating patch spec. * Fix linter * prettier fix * Adding x-ms-long-running-operation Co-authored-by: Ruslan Yakushev 🚴 <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> Co-authored-by: erich-wang <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: Vaclav Turecek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.