Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sc properties in 03-01 #18343

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

xwang971
Copy link
Contributor

@xwang971 xwang971 commented Mar 22, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@xwang971 xwang971 requested a review from ruslany March 22, 2022 17:58
@openapi-workflow-bot
Copy link

Hi, @xwang971 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 22, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sourcecontrols' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-01-01-preview/SourceControls.json#L264
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sourcecontrols' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/stable/2022-03-01/SourceControls.json#L264
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'dockerfilePath' renamed or removed?
    New: Microsoft.App/stable/2022-03-01/SourceControls.json#L312:7
    Old: Microsoft.App/preview/2022-01-01-preview/SourceControls.json#L312:7
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 22, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armapp - 0.1.0
    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-app - Approved - 1.0.0b1
    +	Model GithubActionConfiguration no longer has parameter dockerfile_path
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 49b72a564baf7ad87f16497249a9582d1abf36e1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New patch version of npm available! 8.5.0 -> 8.5.5
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-app [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group NamespacesOperations
      info	[Changelog]   - Model GithubActionConfiguration has a new parameter context_path
      info	[Changelog]   - Model GithubActionConfiguration has a new parameter image
      info	[Changelog]   - Model TrafficWeight has a new parameter label
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model GithubActionConfiguration no longer has parameter dockerfile_path
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 49b72a564baf7ad87f16497249a9582d1abf36e1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armapp [View full logs]  [Preview SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `DaprComponentsClientListPager`
      info	[Changelog] - New struct `DaprComponentsClientListResponse`
      info	[Changelog] - New struct `DaprComponentsClientListResult`
      info	[Changelog] - New struct `DaprComponentsCollection`
      info	[Changelog] - New struct `DaprMetadata`
      info	[Changelog] - New struct `DefaultAuthorizationPolicy`
      info	[Changelog] - New struct `DefaultErrorResponse`
      info	[Changelog] - New struct `DefaultErrorResponseError`
      info	[Changelog] - New struct `DefaultErrorResponseErrorDetailsItem`
      info	[Changelog] - New struct `EnvironmentVar`
      info	[Changelog] - New struct `Facebook`
      info	[Changelog] - New struct `ForwardProxy`
      info	[Changelog] - New struct `GitHub`
      info	[Changelog] - New struct `GithubActionConfiguration`
      info	[Changelog] - New struct `GlobalValidation`
      info	[Changelog] - New struct `Google`
      info	[Changelog] - New struct `HTTPScaleRule`
      info	[Changelog] - New struct `HTTPSettings`
      info	[Changelog] - New struct `HTTPSettingsRoutes`
      info	[Changelog] - New struct `IdentityProviders`
      info	[Changelog] - New struct `Ingress`
      info	[Changelog] - New struct `JwtClaimChecks`
      info	[Changelog] - New struct `LogAnalyticsConfiguration`
      info	[Changelog] - New struct `Login`
      info	[Changelog] - New struct `LoginRoutes`
      info	[Changelog] - New struct `LoginScopes`
      info	[Changelog] - New struct `LogsConfiguration`
      info	[Changelog] - New struct `ManagedEnvironment`
      info	[Changelog] - New struct `ManagedEnvironmentPatch`
      info	[Changelog] - New struct `ManagedEnvironmentProperties`
      info	[Changelog] - New struct `ManagedEnvironmentStorage`
      info	[Changelog] - New struct `ManagedEnvironmentStorageProperties`
      info	[Changelog] - New struct `ManagedEnvironmentStoragesCollection`
      info	[Changelog] - New struct `ManagedEnvironmentsClient`
      info	[Changelog] - New struct `ManagedEnvironmentsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientBeginDeleteOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePoller`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePollerResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePoller`
      info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePollerResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientDeleteResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientGetOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientGetResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientGetResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupPager`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionPager`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResult`
      info	[Changelog] - New struct `ManagedEnvironmentsCollection`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClient`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResult`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResult`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResult`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `NamespacesClient`
      info	[Changelog] - New struct `NamespacesClientCheckNameAvailabilityOptions`
      info	[Changelog] - New struct `NamespacesClientCheckNameAvailabilityResponse`
      info	[Changelog] - New struct `NamespacesClientCheckNameAvailabilityResult`
      info	[Changelog] - New struct `Nonce`
      info	[Changelog] - New struct `OpenIDConnectClientCredential`
      info	[Changelog] - New struct `OpenIDConnectConfig`
      info	[Changelog] - New struct `OpenIDConnectLogin`
      info	[Changelog] - New struct `OpenIDConnectRegistration`
      info	[Changelog] - New struct `OperationDetail`
      info	[Changelog] - New struct `OperationDisplay`
      info	[Changelog] - New struct `OperationsClient`
      info	[Changelog] - New struct `OperationsClientListOptions`
      info	[Changelog] - New struct `OperationsClientListPager`
      info	[Changelog] - New struct `OperationsClientListResponse`
      info	[Changelog] - New struct `OperationsClientListResult`
      info	[Changelog] - New struct `ProxyResource`
      info	[Changelog] - New struct `QueueScaleRule`
      info	[Changelog] - New struct `Registration`
      info	[Changelog] - New struct `RegistryCredentials`
      info	[Changelog] - New struct `RegistryInfo`
      info	[Changelog] - New struct `Replica`
      info	[Changelog] - New struct `ReplicaCollection`
      info	[Changelog] - New struct `ReplicaContainer`
      info	[Changelog] - New struct `ReplicaProperties`
      info	[Changelog] - New struct `Resource`
      info	[Changelog] - New struct `Revision`
      info	[Changelog] - New struct `RevisionCollection`
      info	[Changelog] - New struct `RevisionProperties`
      info	[Changelog] - New struct `Scale`
      info	[Changelog] - New struct `ScaleRule`
      info	[Changelog] - New struct `ScaleRuleAuth`
      info	[Changelog] - New struct `Secret`
      info	[Changelog] - New struct `SecretsCollection`
      info	[Changelog] - New struct `SourceControl`
      info	[Changelog] - New struct `SourceControlCollection`
      info	[Changelog] - New struct `SourceControlProperties`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New struct `Template`
      info	[Changelog] - New struct `TrackedResource`
      info	[Changelog] - New struct `TrafficWeight`
      info	[Changelog] - New struct `Twitter`
      info	[Changelog] - New struct `TwitterRegistration`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New struct `VnetConfiguration`
      info	[Changelog] - New struct `Volume`
      info	[Changelog] - New struct `VolumeMount`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 826 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 49b72a564baf7ad87f16497249a9582d1abf36e1. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-app [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 49b72a564baf7ad87f16497249a9582d1abf36e1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    Copy link
    Contributor

    @ruslany ruslany left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @xwang971
    Copy link
    Contributor Author

    @chunyu3 This PR is part of reverting breaking changes on the released api-version:https://github.com/Azure/azure-rest-api-specs/pull/18137. Could you approve it?

    @chunyu3 chunyu3 merged commit 2fb6801 into Microsoft.App-2022-03-01 Mar 23, 2022
    msyyc pushed a commit that referenced this pull request Mar 25, 2022
    * Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * refactore properties (#18137)
    
    * [Non Break Change]Update to use easy auth v2 same as Web App (#18143) (#18217)
    
    * Update auth config to use the same auth config in App Service
    
    * Update for spell check
    
    * Remove TokenStore/ConfigFilePath as not supported for ContainerApp
    
    * Copy AuthConfig from previous version (#18221)
    
    * Copy updated AuthConfig from previous version
    
    * Add suppression
    
    * Add API for checkNameAvailability in 2022-03-01 (#18204)
    
    * add API
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Add label property (#18280)
    
    * Add label property
    
    * fix prettier
    
    Co-authored-by: Juliehzl <[email protected]>
    
    * refactor sc properties in 03-01 (#18343)
    
    * refactor sc properties in 03-01
    
    * Revert "refactore properties (#18137)"
    
    This reverts commit 4fe86bc.
    
    * add odata query (#18364)
    
    * Updating patch spec. (#18354)
    
    * Updating patch spec.
    
    * Fix linter
    
    * prettier fix
    
    * Adding x-ms-long-running-operation
    
    Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
    
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Michael Dai <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    visingl pushed a commit that referenced this pull request Mar 30, 2022
    * Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * refactore properties (#18137)
    
    * [Non Break Change]Update to use easy auth v2 same as Web App (#18143) (#18217)
    
    * Update auth config to use the same auth config in App Service
    
    * Update for spell check
    
    * Remove TokenStore/ConfigFilePath as not supported for ContainerApp
    
    * Copy AuthConfig from previous version (#18221)
    
    * Copy updated AuthConfig from previous version
    
    * Add suppression
    
    * Add API for checkNameAvailability in 2022-03-01 (#18204)
    
    * add API
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Add label property (#18280)
    
    * Add label property
    
    * fix prettier
    
    Co-authored-by: Juliehzl <[email protected]>
    
    * refactor sc properties in 03-01 (#18343)
    
    * refactor sc properties in 03-01
    
    * Revert "refactore properties (#18137)"
    
    This reverts commit 4fe86bc.
    
    * add odata query (#18364)
    
    * Updating patch spec. (#18354)
    
    * Updating patch spec.
    
    * Fix linter
    
    * prettier fix
    
    * Adding x-ms-long-running-operation
    
    Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
    
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Michael Dai <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    * Adds base for updating Microsoft.App from version preview/2022-01-01-preview to version 2022-03-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * refactore properties (Azure#18137)
    
    * [Non Break Change]Update to use easy auth v2 same as Web App (Azure#18143) (Azure#18217)
    
    * Update auth config to use the same auth config in App Service
    
    * Update for spell check
    
    * Remove TokenStore/ConfigFilePath as not supported for ContainerApp
    
    * Copy AuthConfig from previous version (Azure#18221)
    
    * Copy updated AuthConfig from previous version
    
    * Add suppression
    
    * Add API for checkNameAvailability in 2022-03-01 (Azure#18204)
    
    * add API
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Add label property (Azure#18280)
    
    * Add label property
    
    * fix prettier
    
    Co-authored-by: Juliehzl <[email protected]>
    
    * refactor sc properties in 03-01 (Azure#18343)
    
    * refactor sc properties in 03-01
    
    * Revert "refactore properties (Azure#18137)"
    
    This reverts commit 4fe86bc.
    
    * add odata query (Azure#18364)
    
    * Updating patch spec. (Azure#18354)
    
    * Updating patch spec.
    
    * Fix linter
    
    * prettier fix
    
    * Adding x-ms-long-running-operation
    
    Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
    
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Michael Dai <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants