-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update confluent.json for LintDiff fixes #18261
Update confluent.json for LintDiff fixes #18261
Conversation
Hi, @krishnasriSomepalli Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L942 |
OperationId should contain the verb: 'orgvalidate' in:'Validations_ValidateOrganization'. Consider updating the operationId Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L473 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: accepted Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L559 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L649 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 33 Errors, 17 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2021-12-01/confluent.json compared with base:stable/2020-03-01/confluent.json
- current:stable/2021-12-01/confluent.json compared with base:preview/2021-09-01-preview/confluent.json
Only 30 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
@ArcturusZhang Could you take a look at the Go SDK breaking change ? |
… stable/2021-12-01 (#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (#17071) * Update confluent.json (#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (#18261)
… stable/2021-12-01 (#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (#17071) * Update confluent.json (#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (#18261)
… stable/2021-12-01 (Azure#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (Azure#17071) * Update confluent.json (Azure#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (Azure#18261)
Parent: #17070