New review request for Microsoft.ContainerService to add version 2022-01-01 #17814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2021-10-01 to version 2022-01-01
* update readme to help generate SDK * update readme
…Azure#17209) * Support query parameter 'format' in listClusterUserCredential handler * Add kubelogin to custom words * Fix enum lint * Fix typo * Fix typo * List admin credential should not have format parameter
This reverts commit 1d8f262.
…nerService-2022-01-01
FumingZhang
requested review from
msyyc,
BigCat20196 and
ArcturusZhang
as code owners
|
Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2817 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2910 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L4084 |
|
The response of operation:'ManagedClusters_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L428 |
|
The response of operation:'ManagedClusters_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L468 |
|
The response of operation:'ManagedClusters_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L584 |
|
The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L921 |
|
The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L968 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L1489 |
|
The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L1537 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L1193 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L654 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L1100 |
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L37 |
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L4886 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2222 |
|
The schema 'OperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2235 |
|
The schema 'OperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2255 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2280 |
|
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2319 |
|
The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2340 |
|
The schema 'ManagedClusterServicePrincipalProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2559 |
|
The schema 'ContainerServiceMasterProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2575 |
|
The schema 'ManagedClusterAgentPoolProfileProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2629 |
|
The schema '1' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2817 |
|
The schema 'AgentPoolListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2878 |
|
The schema 'AgentPoolUpgradeSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2895 |
|
The schema '1' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2910 |
|
The schema 'ManagedClusterWindowsProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2922 |
|
The schema 'ContainerServiceLinuxProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2022-01-01/managedClusters.json#L2988 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 9 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2022-01-01/managedClusters.json compared with base:stable/2021-10-01/managedClusters.json
- current:stable/2022-01-01/managedClusters.json compared with base:preview/2021-11-01-preview/managedClusters.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Feb 11, 2022
This was referenced Feb 11, 2022
25 tasks
|
Sorry have to close the previous PR #17578 and open this new one to fix the conflicts. The conflicts are caused by PR #17579 merged into main branch. We are shipping two new api versions and both of these PRs modified the readme files. I've merged the main branch into this dev branch and only modified the readme files to resolve the conflicts. Please help review, thanks a lot! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FumingZhang
added
the
WaitForARMFeedback
pilor
added
ARMSignedOff
weidongxu-microsoft
approved these changes
Feb 12, 2022
weidongxu-microsoft
added
the
Approved-OkToMerge
|
LGTM, I can merge after version rollout. |
|
Hi @weidongxu-microsoft, we've finished manifest rollout. Could you please help merge this PR? Thanks! |
|
We are doing monthly Java release today. Let me know your planned SDK release date. If not urgent (meaning you are OK for next month), ignore it. |
This was referenced Feb 14, 2022
FumingZhang
deleted the
fuming/dev-containerservice-Microsoft.ContainerService-2022-01-01
branch
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…-01-01 (Azure#17814) * Adds base for updating Microsoft.ContainerService from version stable/2021-10-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * Update readme to help generate SDK (Azure#17371) * update readme to help generate SDK * update readme * Support query parameter 'format' in listClusterUserCredential handler (Azure#17209) * Support query parameter 'format' in listClusterUserCredential handler * Add kubelogin to custom words * Fix enum lint * Fix typo * Fix typo * List admin credential should not have format parameter * Add adminUsers in aadprofile (Azure#17402) * Revert "Add adminUsers in aadprofile (Azure#17402)" (Azure#17523) This reverts commit 1d8f262. * fix conflict (Azure#17623) Co-authored-by: Tongyao Si <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.