Add x-ms-identifiers to reservations\resource-manager. #17761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @vukelich Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L934 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L988 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L1440 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L1452 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L1463 |
|
/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/resourceProviders/{providerId}/locations/{location}/serviceLimits/{resourceName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L37 |
|
/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/resourceProviders/{providerId}/locations/{location}/serviceLimits/{resourceName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L37 |
|
The integer type does not have a format, please add it. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L415 |
|
The integer type does not have a format, please add it. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L415 |
|
The integer type does not have a format, please add it. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L419 |
|
The integer type does not have a format, please add it. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L419 |
|
The integer type does not have a format, please add it. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L522 |
|
The integer type does not have a format, please add it. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L522 |
|
The schema 'ResourceName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L449 |
|
The schema 'ResourceName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L449 |
|
The schema 'QuotaLimits' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L464 |
|
The schema 'QuotaLimits' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L464 |
|
The schema 'QuotaLimitsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L483 |
|
The schema 'QuotaLimitsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L483 |
|
The parameters:reservationId,reservationOrderId should be kept in the same order as they present in the path. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L466 |
|
The parameters:reservationId,reservationOrderId should be kept in the same order as they present in the path. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L555 |
| Since operation 'ReservationOrder_ChangeDirectory' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L831 |
|
| 'PUT' operation 'ReservationOrder_Purchase' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L234 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L405 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L405 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L443 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L443 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L598 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2020-10-25/quota.json#L598 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2021-07-01/reservations.json#L1022 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/reservations/resource-manager/readme.md tag: specification/reservations/resource-manager/readme.md#tag-package-2021-07-01 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: Microsoft.Capacity/stable/2021-07-01/reservations.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
This was referenced Feb 10, 2022
|
Hi, @vukelich. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @vukelich. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @vukelich. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @vukelich. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @vukelich. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @vukelich. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
EXPLANATION OF THIS CHANGE
APIs will need to start indicating item uniqueness in
arrays. By default, uniqueness is thestringproperty called"id"of items in anarray. When that property does not exist, thex-ms-identifiersextension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.