Add Microsoft.SignalRService/signalr 2022-02-01 #17748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ArchangelSDY Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi, @ArchangelSDY your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Only 'application/json' content-type is supported by ARM. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L553 |
|
| Only 'application/json' content-type is supported by ARM. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L770 |
|
| 'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L578 |
|
| 'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L795 |
|
| The value provided for description is not descriptive enough. Accurate and descriptive description is essential for maintaining reference documentation. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L581 |
|
| The value provided for description is not descriptive enough. Accurate and descriptive description is essential for maintaining reference documentation. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L798 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Based on the response model schema, operation 'SignalR_ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L1503 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/stable/2022-02-01/signalr.json#L2109 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2022-02-01/signalr.json compared with base:stable/2021-10-01/signalr.json
- current:stable/2022-02-01/signalr.json compared with base:preview/2021-09-01-preview/signalr.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Swagger Generation Artifacts
|
|
Hi @ArchangelSDY, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 10, 2022
ArchangelSDY
force-pushed
the
signalr-2022-02-01
branch
from
a883c05 to
02c719c
Compare
pilor
reviewed
Feb 10, 2022
specification/signalr/resource-manager/Microsoft.SignalRService/stable/2022-02-01/signalr.json
Show resolved
Hide resolved
...Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_CreateOrUpdate.json
Outdated
Show resolved
Hide resolved
pilor
added
the
ARMChangesRequested
ArchangelSDY
force-pushed
the
signalr-2022-02-01
branch
from
4519a59 to
d5f7749
Compare
Updated with: |
pilor
added
ARMSignedOff
|
@ArchangelSDY The "API Readiness Check" failed. Is your service deployed to prod already? |
|
@leni-msft The manifest is still going through SDP rollout. Do we need to wait until it finishes before this can be merged? |
|
@ArchangelSDY yes, swagger cannot be merged until the API is ready. Merging swagger to main means the API is released, so can be consumed by downstream users. |
|
Hi, @ArchangelSDY. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
Hi @leni-msft any more comments for this PR? |
|
the new api-version is ready on Azure, could u plz try again? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@leni-msft CI passed. |
leni-msft
approved these changes
Mar 22, 2022
This was referenced Mar 22, 2022
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 22, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Prepare Microsoft.SignalRService/signalr 2022-02-01 * Add Microsoft.SignalRService/signalr 2022-02-01 * Address review comments * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.