SubscriptionListResult nextLink not required #17674

cataggar · 2022-02-04T21:18:48Z

Fix for #17621. This is the most straightforward fix for this quality issue.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-04T21:18:50Z

Hi, @cataggar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-02-04T21:18:51Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-04T21:18:52Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2016-06-01/subscriptions.json compared with base:stable/2016-06-01/subscriptions.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- subscription/resource-manager/readme.md tag:package-2021-10
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- subscription/resource-manager/readme.md tag:package-2021-10

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
`❌` R4037 - MissingTypeObject	The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
`❌` R4037 - MissingTypeObject	The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198
`❌` R4037 - MissingTypeObject	The schema 'Subscription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L210
`❌` R4037 - MissingTypeObject	The schema 'SubscriptionPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L254
`❌` R4037 - MissingTypeObject	The schema 'SubscriptionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L283
`❌` R4037 - MissingTypeObject	The schema 'TenantIdDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L299
`❌` R4037 - MissingTypeObject	The schema 'TenantListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L314
⚠️ R1005 - GetInOperationName	'GET' operation 'Subscription_AcceptOwnershipStatus' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L347
⚠️ R1006 - PutInOperationName	'PUT' operation 'SubscriptionPolicy_AddUpdatePolicyForTenant' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L380
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L643
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L721
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L820
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L926
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L975
⚠️ R2017 - PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Alias_Create' Request Model: 'PutAliasRequest' Response Model: 'SubscriptionAliasResponse' Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L155
⚠️ R2017 - PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'SubscriptionPolicy_AddUpdatePolicyForTenant' Request Model: 'PutTenantPolicyRequestProperties' Response Model: 'GetTenantPolicyResponse' Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L378
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'Alias_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L265
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L21
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L54
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L90
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L297
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L347
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L611
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: blockSubscriptionsLeavingTenant Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L888
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: blockSubscriptionsIntoTenant Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L892
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowTransfers Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L999

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/subscription/resource-manager/readme.md tag: specification/subscription/resource-manager/readme.md#tag-package-2021-10

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-04T21:18:53Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armsubscription - 0.3.0

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-subscription - 3.0.0
❌azure-sdk-for-go - subscription/mgmt/2020-09-01/subscription - v61.4.0

+	Field `Value` of struct `CanceledSubscriptionID` has been removed
+	Field `Value` of struct `EnabledSubscriptionID` has been removed
+	Field `Value` of struct `RenamedSubscriptionID` has been removed

️✔️azure-sdk-for-go - preview/subscription/mgmt/2019-10-01-preview/subscription - v61.4.0
️✔️azure-sdk-for-go - preview/subscription/mgmt/2018-03-01-preview/subscription - v61.4.0
️✔️azure-sdk-for-go - preview/subscription/mgmt/2017-11-01-preview/subscription - v61.4.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c21498. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/subscription/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Subscription [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Subscription.2.0.0.nupkg
- Microsoft.Azure.Management.Subscription.2.0.0.symbols.nupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c21498. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️subscription/mgmt/2020-09-01/subscription [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Value` of struct `CanceledSubscriptionID` has been removed
info	[Changelog] - Field `Value` of struct `RenamedSubscriptionID` has been removed
info	[Changelog] - Field `Value` of struct `EnabledSubscriptionID` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Code` in struct `ErrorResponseBody`
info	[Changelog] - New field `Message` in struct `ErrorResponseBody`
info	[Changelog] - New field `SubscriptionID` in struct `CanceledSubscriptionID`
info	[Changelog] - New field `SubscriptionID` in struct `RenamedSubscriptionID`
info	[Changelog] - New field `SubscriptionID` in struct `EnabledSubscriptionID`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).

️✔️preview/subscription/mgmt/2019-10-01-preview/subscription [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/subscription/mgmt/2018-03-01-preview/subscription [View full logs]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `OperationClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `OperationClient.GetResponder(*http.Response) (CreationResult, error)`
info	[Changelog] - New function `OperationClient.Get(context.Context, string) (CreationResult, error)`
info	[Changelog] - New function `NewOperationClient() OperationClient`
info	[Changelog] - New function `NewOperationClientWithBaseURI(string) OperationClient`
info	[Changelog] - New function `OperationClient.GetPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New struct `ErrorResponseBody`
info	[Changelog] - New struct `OperationClient`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 10 additive change(s).

️✔️preview/subscription/mgmt/2017-11-01-preview/subscription [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️❌ azure-sdk-for-go-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 0c21498. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[generator automation-v2] [ERROR] total 1 error(s):
cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'go: downloading github.com/Azure/azure-sdk-for-go v61.1.0+incompatible
cmderr	[generator automation-v2] [ERROR] �[33;1mWARNING: Unable to find version for /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription�[0m
cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/subscription/armsubscription, try to build in /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription
cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription
cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription
cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.0.6335; node: v14.19.0, max-memory: 8192 MB]
cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.5.1).
cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
cmderr	[generator automation-v2] [ERROR] NOTE: AutoRest core version selected from configuration: ~2.0.4413.
cmderr	[generator automation-v2] [ERROR] Loading AutoRest core      '/home/vsts/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4421)
cmderr	[generator automation-v2] [ERROR] Loading AutoRest extension '@autorest/go' (4.0.0-preview.36->4.0.0-preview.36)
cmderr	[generator automation-v2] [ERROR] Installing AutoRest extension '@microsoft.azure/autorest.go' (~2.1.47)
cmderr	[generator automation-v2] [ERROR] Failed to acquire 'require'd configuration 'file:///home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription/$%28this-folder%29/autorest-configuration.md'
cmderr	[generator automation-v2] [ERROR] Failed to install or start extension '@microsoft.azure/autorest.go' (~2.1.47)
cmderr	[generator automation-v2] [ERROR] Error: Could not read 'file:///home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription/$%28this-folder%29/autorest-configuration.md'.
cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh.exe": exit status 1
cmderr	[generator automation-v2] [ERROR] ': exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c21498. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-subscription [View full logs] [Release SDK Changes]
- azure_mgmt_subscription-1.0.0b1-py3-none-any.whl
- azure-mgmt-subscription-1.0.0b1.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c21498. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-subscriptions [View full logs] [Release SDK Changes]
- azure-arm-subscriptions-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c21498. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️subscription [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

cataggar · 2022-02-04T21:32:25Z

The reported Go breaking changes are not related. This PR looks good.

openapi-workflow-bot · 2022-02-07T16:13:03Z

Hi, @cataggar your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

cataggar · 2022-02-09T18:13:08Z

@pilor, thanks for signing off. Do you happen to know how to get someone assigned to this pull request? Usually the bot does so.

pilor · 2022-02-09T19:19:38Z

Probably related to checking "no refresh needed" in the SDK checklist in the PR description. Can change that or reach out to https://teams.microsoft.com/l/channel/19%3a02411a2d005b44f8903b6da2a7a31883%40thread.skype/Swagger%2520reviewers?groupId=da8d67c5-f19d-4799-b158-5dbbef868d49&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47

cataggar · 2022-02-10T17:52:57Z

@weidongxu-microsoft, can you help get this reviewed and merged? I'm not sure why the bot didn't assign anyone.

SubscriptionListResult nextLink not required

9285d41

openapi-workflow-bot bot added the FixS360 label Feb 4, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Feb 4, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 7, 2022

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 7, 2022

cataggar assigned weidongxu-microsoft Feb 10, 2022

weidongxu-microsoft approved these changes Feb 11, 2022

View reviewed changes

weidongxu-microsoft merged commit 0c21498 into Azure:main Feb 11, 2022

openapi-pipeline-app bot added CI-BreakingChange-Go-V2 and removed CI-BreakingChange-Go-V2 labels Feb 11, 2022

cataggar deleted the SubscriptionListResult branch February 11, 2022 09:16

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

SubscriptionListResult nextLink not required (Azure#17674)

6d7aa00

cataggar mentioned this pull request Apr 22, 2022

subscription Subscriptions_List requires nextLink #17621

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SubscriptionListResult nextLink not required #17674

SubscriptionListResult nextLink not required #17674

cataggar commented Feb 4, 2022 •

edited

Loading

openapi-workflow-bot bot commented Feb 4, 2022

openapi-workflow-bot bot commented Feb 4, 2022

openapi-pipeline-app bot commented Feb 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 4, 2022 •

edited

Loading

Breaking Changes Tracking

cataggar commented Feb 4, 2022

openapi-workflow-bot bot commented Feb 7, 2022

cataggar commented Feb 9, 2022

pilor commented Feb 9, 2022

cataggar commented Feb 10, 2022

SubscriptionListResult nextLink not required #17674

SubscriptionListResult nextLink not required #17674

Conversation

cataggar commented Feb 4, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 4, 2022

openapi-workflow-bot bot commented Feb 4, 2022

openapi-pipeline-app bot commented Feb 4, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 4, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

cataggar commented Feb 4, 2022

openapi-workflow-bot bot commented Feb 7, 2022

cataggar commented Feb 9, 2022

pilor commented Feb 9, 2022

cataggar commented Feb 10, 2022

cataggar commented Feb 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 4, 2022 •

edited

Loading