Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xms-ids for Commerce #17628

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

agalerrotaru
Copy link
Contributor

@agalerrotaru agalerrotaru commented Feb 2, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @agalerrotaru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'UsageAggregates_List'
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L21
    R2054 - SecurityDefinitionsStructure Every swagger/configuration must have a security definitions section and it must adhere to the structure described in: https://github.com/Azure/azure-openapi-validator/blob/master/docs/security-definitions-structure-validation.md
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L1
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'OfferDurableId', for definition: 'RateCardQueryParameters' must follow camelCase style. Example: 'offerDurableId'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L265
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Currency', for definition: 'RateCardQueryParameters' must follow camelCase style. Example: 'currency'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L270
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Locale', for definition: 'RateCardQueryParameters' must follow camelCase style. Example: 'locale'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L274
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'RegionInfo', for definition: 'RateCardQueryParameters' must follow camelCase style. Example: 'regionInfo'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L278
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Currency', for definition: 'ResourceRateCardInfo' must follow camelCase style. Example: 'currency'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L287
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Locale', for definition: 'ResourceRateCardInfo' must follow camelCase style. Example: 'locale'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L291
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'IsTaxIncluded', for definition: 'ResourceRateCardInfo' must follow camelCase style. Example: 'isTaxIncluded'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L295
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'OfferTerms', for definition: 'ResourceRateCardInfo' must follow camelCase style. Example: 'offerTerms'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L299
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Meters', for definition: 'ResourceRateCardInfo' must follow camelCase style. Example: 'meters'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L309
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterId', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterId'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L324
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterName', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterName'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L329
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterCategory', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterCategory'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L333
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterSubCategory', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterSubCategory'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L337
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Unit', for definition: 'MeterInfo' must follow camelCase style. Example: 'unit'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L341
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterTags', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterTags'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L345
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterRegion', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterRegion'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L352
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'MeterRates', for definition: 'MeterInfo' must follow camelCase style. Example: 'meterRates'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L356
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'EffectiveDate', for definition: 'MeterInfo' must follow camelCase style. Example: 'effectiveDate'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L364
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'IncludedQuantity', for definition: 'MeterInfo' must follow camelCase style. Example: 'includedQuantity'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L369
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Name', for definition: 'OfferTermInfo' must follow camelCase style. Example: 'name'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L383
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'EffectiveDate', for definition: 'OfferTermInfo' must follow camelCase style. Example: 'effectiveDate'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L396
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'Credit', for definition: 'MonetaryCredit' must follow camelCase style. Example: 'credit'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L412
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'ExcludedMeterIds', for definition: 'MonetaryCredit' must follow camelCase style. Example: 'excludedMeterIds'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L417
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'TieredDiscount', for definition: 'MonetaryCommitment' must follow camelCase style. Example: 'tieredDiscount'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L436
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'ExcludedMeterIds', for definition: 'MonetaryCommitment' must follow camelCase style. Example: 'excludedMeterIds'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L444
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'RecurringCharge', for definition: 'RecurringCharge' must follow camelCase style. Example: 'recurringCharge'.
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L463
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Commerce/UsageAggregates'
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L20
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Commerce/RateCard'
    Location: Microsoft.Commerce/preview/2015-06-01-preview/commerce.json#L103
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-commerce - 6.0.0
    ️✔️azure-sdk-for-go - preview/commerce/mgmt/2015-06-01-preview/commerce - v61.4.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8afcb7b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-commerce [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8afcb7b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-02-09 06:40:01 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-commerce;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2022-02-09 06:40:01 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2022-02-09 06:40:01 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/commerce/azure-resourcemanager-commerce --java.namespace=com.azure.resourcemanager.commerce   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/commerce/resource-manager/readme.md
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-commerce
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [POM][Skip] pom already has module azure-resourcemanager-commerce
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [POM][Skip] pom already has module sdk/commerce
      cmderr	[generate.py] 2022-02-09 06:40:22 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-commerce [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-02-09 06:41:18 DEBUG Got artifact_id: azure-resourcemanager-commerce
      cmderr	[Inst] 2022-02-09 06:41:18 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-02-09 06:41:18 DEBUG Got artifact: azure-resourcemanager-commerce-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2022-02-09 06:41:18 DEBUG Got artifact: azure-resourcemanager-commerce-1.0.0-beta.2.jar
      cmderr	[Inst] 2022-02-09 06:41:18 DEBUG Match jar package: azure-resourcemanager-commerce-1.0.0-beta.2.jar
      cmderr	[Inst] 2022-02-09 06:41:18 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17628/azure-sdk-for-java/azure-resourcemanager-commerce/azure-resourcemanager-commerce-1.0.0-beta.2.jar\" -o azure-resourcemanager-commerce-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-commerce -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-commerce-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8afcb7b. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/commerce/mgmt/2015-06-01-preview/commerce [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8afcb7b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-commerce [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8afcb7b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️commerce [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @agalerrotaru, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @dw511214992
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @agalerrotaru
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 17628 in repo Azure/azure-rest-api-specs

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants