Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johnema/copyprogress version #17486

Closed
wants to merge 10 commits into from
Closed

Johnema/copyprogress version #17486

wants to merge 10 commits into from

Conversation

johnemmanuelm
Copy link
Contributor

@johnemmanuelm johnemmanuelm commented Jan 25, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @johnemmanuelm Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 25, 2022
    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @ghost
    Copy link

    ghost commented Jan 25, 2022

    Thank you for your contribution johnemmanuelm! We will review the pull request and get back to you soon.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2022

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.StorSimple/operations' removed or restructured?
    Old: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L64:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L64:5
    ️❌LintDiff: 1 Errors, 1 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L92
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AvailableProviderOperationsModel'. Consider using the plural form of 'AvailableProviderOperations' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L70


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L46
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L141
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L193
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L255
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L302
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L358
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L407
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L466
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L532
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L587
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L644
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L704
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L773
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L828
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L884
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L950
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1004
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1071
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1128
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1194
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1265
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1332
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1412
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1469
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1535
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1608
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1670
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1727
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1793
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L1866
    ️❌Avocado: 1 Errors, 3 Warnings failed [Detail]
    Rule Message
    NO_JSON_FILE_FOUND The JSON file is not found but it is referenced from the readme file.
    readme: specification/alertsmanagement/resource-manager/readme.md
    json: preview/2021-08-08-preview/examples/AlertProcessingRules_Create_or_update_remove_all_action_groups_specific_VM_one-off_maintenance_window.json
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/alertsmanagement/resource-manager/readme.md
    tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/automation/resource-manager/readme.md
    tag: specification/automation/resource-manager/readme.md#tag-package-2021-06-22
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-11-01
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 51 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "hManagerForSDKTest", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L8300
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L5826
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L5826
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L5826
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "AcrForSDKTest", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "contractVersion": "V2012_12", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L8893
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "default", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "TieredFileShareForSDKTest", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7015
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7015
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7015
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6453
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6453
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6453
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "BackupSchGroupForSDKTest", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6535
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6535
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6535
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "ChapSettingForSDK", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6953
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6953
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6953
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "HSDK-4XY4FI2IVG", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7015
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7015
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7015
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name": "Auto-TestFileShare1", cannot be sent in the request.
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L6510
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: Client
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7263
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ResourceGroupName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7263
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: ManagerName
    Url: Microsoft.StorSimple/stable/2016-10-01/StorSimple.json#L7263
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️❌SpellCheck: 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Unknown word (Tera), please fix the error or add words to ./custom-words.txt
    path: Microsoft.DataBox/stable/2022-01-01/databox.json#L3050:28
    HowToFix Unknown word (Tera), please fix the error or add words to ./custom-words.txt
    path: Microsoft.DataBox/stable/2022-01-01/databox.json#L3059:28
    HowToFix Unknown word (Tera), please fix the error or add words to ./custom-words.txt
    path: Microsoft.DataBox/stable/2022-01-01/databox.json#L3368:28
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-resource-manager-schemas failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-java inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @johnemmanuelm, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @johnemmanuelm, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @akning-ms
    Copy link
    Contributor

    Hi @johnemmanuelm, Can you describe more about this PR? I saw there is over 300 files and few different RP in this PR

    @ghost
    Copy link

    ghost commented Feb 13, 2022

    Hi, @johnemmanuelm. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Feb 13, 2022
    @ghost ghost closed this Feb 28, 2022
    @ghost
    Copy link

    ghost commented Feb 28, 2022

    Hi, @johnemmanuelm. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Go-V2 CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization.
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants