Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing S360 swagger issues for billing RP promotions #17450

Closed
wants to merge 554 commits into from
Closed

Fixing S360 swagger issues for billing RP promotions #17450

wants to merge 554 commits into from

Conversation

rkapso
Copy link
Contributor

@rkapso rkapso commented Jan 21, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

krishnasriSomepalli and others added 30 commits October 29, 2021 16:28
@krishnasriSomepalli
[Hub Generated] Review request for Microsoft.Confluent to add version…
2970e41 
… preview/2021-09-01-preview (Azure#16048)

* Adds base for updating Microsoft.Confluent from version preview/2021-03-01-preview to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* Fixing spellcheck (Azure#16551)
@kesharma
update (Azure#16419)
2970400
@Jingshu923
Fix an issue “ServicePrincipalCredentialEnum” should be string rather…
ad3c2d9 
… than object (Azure#16322)
@rickysun93
[Data Factory]Change compressionType to type of object in ADF public …
a159bb4 
…swagger (Azure#16563)

* Change compressionType to type of object in ADF public swagger

* edit adf swagger

* resolve comment

Co-authored-by: Haoran Sun <[email protected]>
@yang-hai-feng
Merge IoT Central Public API Oct Release to main branch (Azure#16606)
a4a7566 
* Add new 2.0-preview.1 version for IoT Central

* fix typo on enum value

* rollback 1.0 changes, applied 2.0-preview.1

* fix typo

* remove non-used examples

* fix style

* update version from 2.0-preview.1 to 1.1-preview

* update code review comments, fix patch consumes with json-patch support, fix examples for fileupload

* add nextLink to collection of orgs

* fix typo

* fix wrong position of paging

* fix the paging

* add . to description

* update default to use enum for api-version

* add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching

* update examples

* fix lint error, model validation

* fix missing type in examples, remove url format

* fix ID case

* fix id case

* fix ID case

* add iotc query language reference

* fix typo
@audunn
[NetAppFiles] Apply s360 fix to operations result (Azure#16270)
c8b0b91 
* Apply s360 fix to operations resutl

* Fix apiversion in example

* Fix validation warning and errors

* Add missing encryptDCConnections propety to AcitiveDirectory

* fix api version

* fix througntputmips

* Clarify description throughputMibps

Co-authored-by: Audunn Baldvinsson <[email protected]>
@eladperets @ArcturusZhang
[Hub Generated] Review request for Microsoft.PolicyInsights to add ve…
4a2c1e8 
…rsion stable/2021-10-01 (Azure#16250)

* Adds base for updating Microsoft.PolicyInsights from version stable/2019-07-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Microsoft.PolicyInsights/remediations new API version: 2021-10-01

* Add Go tag

* Add Java tag

* Update specification/policyinsights/resource-manager/readme.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Remove Go SDK generation flag

Co-authored-by: Dapeng Zhang <[email protected]>
@pazinio
Cmk support for Azure healthbot (Azure#16520)
87c0c6e 
* adding cmk support

* healthbot - actual CMK changes

* readme update

* new line added
@alexgoldschmidt
Change summaries from Results to ProxyResults (Azure#16533)
f9bc474 
Co-authored-by: Alex Goldschmidt <[email protected]>
@vikramadityab72
[Hub Generated] Review request for Microsoft.Devices to add version p…
75abfdb 
…review/2021-07-02-preview (Azure#16493)

* Adds base for updating Microsoft.Devices from version preview/2021-07-01-preview to version 2021-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* adding the creation time in the version

* add data residency flag

* changing the version tag
@yanqiongchen
Backup admin update (Azure#16151)
12b2a95 
* Move preview-2018-09-01 to stable

* Add new api version 2021-09-01
@colawwj
correct-typescript-for-desktopVirtualization (Azure#16614)
920e768
@xunsun-commits
Fix S360 item for FSPG swagger by adding default value to backupReten…
9dc61b3 
…tionDays and maintenanceWindow (Azure#16502)

* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

* Change enum first letter to lower case

* Change to upper case

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs

* Fix S360 item by adding default value to backupRetentionDays and maintenanceWindow
@wanyang7
[Synapse] Add tag for Synapse Nov. release (Azure#16595)
d204913 
* add Nov. release tag

* fix
@sureleo @yang-hai-feng
Break down swagger into multiple files for better maintainability (Az…
9da36e8 
…ure#16611)

* IoT Central Public API 1.1-preview Oct Release (Azure#16514)

* Add new 2.0-preview.1 version for IoT Central

* fix typo on enum value

* rollback 1.0 changes, applied 2.0-preview.1

* fix typo

* remove non-used examples

* fix style

* update version from 2.0-preview.1 to 1.1-preview

* update code review comments, fix patch consumes with json-patch support, fix examples for fileupload

* add nextLink to collection of orgs

* fix typo

* fix wrong position of paging

* fix the paging

* add . to description

* update default to use enum for api-version

* add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching

* update examples

* fix lint error, model validation

* fix missing type in examples, remove url format

* fix ID case

* fix id case

* fix ID case

* add iotc query language reference

* fix typo

* Try to refactor swagger and see if it is breaking

* Fix casing in swagger

* fix

* fix semantic

* Adding spec and info

* aabb

* Add path

* fix prettier

Co-authored-by: Johnson Yang <[email protected]>
@Tianyun-G @JoshLove-msft
Add example events. (Azure#16404)
0c887b0 
* Add examples

* Rename certificate_new_version_created.json to secret_new_version_created.json

* Update geofence_entered.json

* Create geofence_entered.json

* Update geofence_entered.json

* Update geofence_entered.json

* Update geofence_entered.json

* Update geofence_result.json

* Update geofence_result.json

* Update keyvalue_deleted.json

Add syncToken for AppConfiguration.

* Update keyvalue_modified.json

Add syncToken for AppConfiguration.

* Delete chat_member_removed_from_thread_with_user.json

* Delete chat_member_added_to_thread_with_user.json

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/active_messages_available_periodic_notifications.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ServiceBus/stable/2018-01-01/examples/deadletter_messages_available_periodic_notification.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update specification/eventgrid/data-plane/Microsoft.ContainerService/stable/2018-01-01/examples/new_kubernetes_version_available.json

Co-authored-by: JoshLove-msft <[email protected]>

* Update placeholders

* Update app_service_plan_updated.json

* Update policy_state_changed.json

* Update new_kubernetes_version_available.json

Co-authored-by: JoshLove-msft <[email protected]>
@omrodrig
Removed property from sample response (Azure#16596)
c4838f2
@darkoa-msft
Internal Network resource - all properties are top level (PrivateEndp…
ab4df5f 
…ointConnectionProxy) (Azure#16628)

* Removed property bags from NRP proxy definition

* Added top level suppression

* Added provisioning state because of RPaaS validation

* Another try at supressions

* square Azure#1

* square #0

* another try
@avinashakka @markcowl
[Non-breaking change] Update diagnosticsProfile.bootDiagnostics.stora…
ac0ab10 
…geUri property description. (Azure#16430)

* Add blockchain to latest profile

* Add additional types

* Update property description.

Co-authored-by: Mark Cowlishaw <[email protected]>
@wanyang7
[Synapse] Decouple dependencies among Swagger specs (Azure#16616)
cf29869 
* extract workspaceNameParameter to common

* move some definitions to common folder

* workspaceNameParameter

* fix

* fix

* revert for libraryInfo

* fix for breaking change

* test for breaking change

* test for breaking change
@kerend
[Hub Generated] Review request for Microsoft.Security to add version …
d00bfb2 
…preview/2021-07-01-preview (Azure#16550)

* .

* .
@ruowan
Update issue_assignment.yml (Azure#16630)
99fe2a9
@bannama
adding parameters for dataflow activity (Azure#16602)
0fba9ba 
Co-authored-by: Bhaskar Annamalai <[email protected]>
@mariohdez
Update the CSharp output directory. (Azure#16640)
c078a73
@sashahdo
Corrected Alert field to include ProxyResource. (Azure#16572)
cb69408
@leigharubin @zhenglaizhang
DPS RP API version for AZn+0 (Azure#16538)
e86c039 
* Initial commit, copying all files from last API version

* Add changes for new API version

* Update DPSCertificateCreateOrUpdate.json

* Update DPSCreate.json

* Update iotdps.json

* Update cSpell.json

* fix prettier issue

* Add tag for new API

* Update readme.md

* Add 'systemData'

* Move systemData

Co-authored-by: Zhenglai Zhang <[email protected]>
@yangyuan
Cognitive Services Resource Provider API Version 2021-10-01 (Azure#16418
e0b5060 
)

* Adds base for updating Microsoft.CognitiveServices from version stable/2021-04-30 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Changes for 2021-10-01

* Use 201 instead of 202 for Put, Add x-ms-pageable for List.

* address comments
@darkoa-msft
Added unexpected internal-only Network RP properties (Azure#16644)
451824d 
* Added suppression because Network RP is sending undocumented properties

* Removed suppression and added properties from NRP request

* Adding operations status to the NRP Proxy resource
@BigCat20196
config readme (Azure#16645)
a81eacc
@zesluo @markcowl
[Synapse]Add auto gen readme files for cli kusto support (Azure#16581)
64b91c0 
* Add blockchain to latest profile

* Add additional types

* addclikustosupportautogenfiles

* removealias

* addrepo

Co-authored-by: Mark Cowlishaw <[email protected]>
This was referenced Jan 21, 2022
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@asarkar84 asarkar84 Awaiting requested review from asarkar84

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore grizzlytheodore is a code owner

@haagha haagha Awaiting requested review from haagha haagha is a code owner

@hyonholee hyonholee Awaiting requested review from hyonholee

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@kjeur kjeur Awaiting requested review from kjeur kjeur is a code owner

@madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

@MehaKaushik MehaKaushik Awaiting requested review from MehaKaushik

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs is a code owner

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@ofirmanor ofirmanor Awaiting requested review from ofirmanor

@orieldar orieldar Awaiting requested review from orieldar

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@RAY-316 RAY-316 Awaiting requested review from RAY-316

@Sandido Sandido Awaiting requested review from Sandido Sandido is a code owner

@shahabhijeet shahabhijeet Awaiting requested review from shahabhijeet shahabhijeet is a code owner

@shawnxzq shawnxzq Awaiting requested review from shawnxzq

@solankisamir solankisamir Awaiting requested review from solankisamir solankisamir is a code owner

@stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

@wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft is a code owner

@wmengmsft wmengmsft Awaiting requested review from wmengmsft

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

Assignees

@akning-ms akning-ms

Labels
CI-FixRequiredOnFailure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.