Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsof.app 2022 01 01 preview/add custom domains #17385
Microsof.app 2022 01 01 preview/add custom domains #17385
Changes from 11 commits
98de6eb
8f6cb60
925c9c6
6e3b5a4
b716fd1
d47481b
436f0b7
b00c1f0
e4b0d0f
86c094e
3fce21c
7609023
b37c3ac
b9f3846
8c1cd8b
34300f3
5d9fe2c
b1f5004
8da8fa5
0fbec14
4ccd72d
a98ac1a
755f670
1a697d0
cbb2b95
64dab7a
72b90e7
3ecab2b
e9b4877
cdb52dd
6792d83
7eddc6e
37c0880
1ee5c24
cdb9674
2058c97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to support IpBased for containerapps? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will once we support the "reservedIP" feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not supported for GA then I think it is better not to have it in swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed IPBasedEnabled