[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2022-01-01 #17377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @sanray-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.AzureStackHCI/stable/2022-01-01/operations.json#L38 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoUpgradeMinorVersion Location: Microsoft.AzureStackHCI/stable/2022-01-01/extensions.json#L458 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: common-types/resource-management/v2/types.json#L359 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.AzureStackHCI' for api version '2022-01-01'. The supported api-versions are '2020-03-01-preview, 2020-10-01, 2020-11-01-preview, 2021-01-01-preview, 2021-07-01-preview, 2021-09-01-preview, 2021-09-01'." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 1 Errors, 1 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2022-01-01/arcSettings.json compared with base:stable/2021-09-01/arcSettings.json
- current:stable/2022-01-01/arcSettings.json compared with base:preview/2021-01-01-preview/arcSettings.json
- current:stable/2022-01-01/clusters.json compared with base:stable/2021-09-01/clusters.json
- current:stable/2022-01-01/clusters.json compared with base:preview/2021-01-01-preview/clusters.json
- current:stable/2022-01-01/extensions.json compared with base:stable/2021-09-01/extensions.json
- current:stable/2022-01-01/extensions.json compared with base:preview/2021-01-01-preview/extensions.json
- current:stable/2022-01-01/operations.json compared with base:stable/2021-09-01/operations.json
- current:stable/2022-01-01/operations.json compared with base:preview/2021-01-01-preview/operations.json
| Rule | Message |
|---|---|
|
The read only property has changed from 'true' to 'false'. New: Microsoft.AzureStackHCI/stable/2022-01-01/arcSettings.json#L280:9 Old: Microsoft.AzureStackHCI/stable/2021-09-01/arcSettings.json#L280:9 |
The following breaking changes are detected by comparison with latest preview version:
| Rule | Message |
|---|---|
| The read only property has changed from 'true' to 'false'. New: Microsoft.AzureStackHCI/stable/2022-01-01/arcSettings.json#L280:9 Old: Microsoft.AzureStackHCI/preview/2021-01-01-preview/arcSettings.json#L280:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @sanray-ms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 17, 2022
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @sanray-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
j5lim
added
ARMSignedOff
|
Hi @sanray-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@raych1 , Work item link for breaking change using the template -> https://msazure.visualstudio.com/One/_workitems/edit/13061339 This is assigned to our service PM Justification in short -> Making one read-only field to writable. |
JeffreyRichter
added
the
Approved-BreakingChange
raych1
approved these changes
Jan 25, 2022
|
Talked with @sanray-ms offline, this PR has to be merged to generate manifest. So, ignore api readiness check. |
This was referenced Jan 25, 2022
This was referenced Jan 25, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jan 25, 2022
…t.AzureStackHCI to add version stable/2022-01-01 (#2186) Create to sync Azure/azure-rest-api-specs#17377 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/azurestackhci?expand=1)
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
…sion stable/2022-01-01 (Azure#17377) * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * remove readonly attribute * added example file * Format the files
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…sion stable/2022-01-01 (Azure#17377) * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * remove readonly attribute * added example file * Format the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has only one change from the last public API version. We made a readonly properly to writable.
Changelog
Add a changelog entry for this PR by answering the following questions:
January 2022
January 2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.