-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing package 2021-11-01 for Go SDK #17219
Conversation
Hi, @tokaplan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37 |
R3026 - TrackedResourcePatchOperation |
Tracked resource 'Workbook' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L473 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L37 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L85 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Insights/stable/2021-10-14/aiOperations_API.json#L51 |
R4015 - NestedResourcesMustHaveListOperation |
The nested resource 'ComponentLinkedStorageAccounts' does not have list operation, please add it. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L240 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Insights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Insights/stable/2021-10-14/aiOperations_API.json#L31 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2021-10-14/aiOperations_API.json#L98 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2021-10-14/aiOperations_API.json#L117 |
R4037 - MissingTypeObject |
The schema 'AnnotationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentAnnotations_API.json#L244 |
R4037 - MissingTypeObject |
The schema 'ApplicationInsightsComponentAPIKeyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentApiKeys_API.json#L209 |
R4037 - MissingTypeObject |
The schema 'WorkItemConfigurationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json#L290 |
R4037 - MissingTypeObject |
The schema 'ApplicationInsightsComponentFavorite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/favorites_API.json#L240 |
R4037 - MissingTypeObject |
The schema 'ApplicationInsightsWebTestLocationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTestLocations_API.json#L75 |
R4037 - MissingTypeObject |
The schema 'WebtestsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L285 |
R4037 - MissingTypeObject |
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L310 |
R4037 - MissingTypeObject |
The schema 'TagsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L323 |
R4037 - MissingTypeObject |
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L325 |
R4037 - MissingTypeObject |
The schema 'webTestListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L334 |
R4037 - MissingTypeObject |
The schema 'WebTest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L353 |
R4037 - MissingTypeObject |
The schema 'WebTestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L381 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L252 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplatesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L291 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L303 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L318 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L357 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateLocalizedGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L383 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L399 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateErrorFieldContract' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L416 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2021-11-01 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️❌
ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: description Url: Microsoft.Insights/stable/2021-10-14/aiOperations_API.json#L98 JsonUrl: stable/2021-10-14/examples/Operations_List.json |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: origin Url: Microsoft.Insights/stable/2021-10-14/aiOperations_API.json#L90 JsonUrl: stable/2021-10-14/examples/Operations_List.json |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
- remove duplicate operation from livetoken_API.json - create new SDK package 2022-01-04
Hi @tokaplan, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @tokaplan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.