Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] Azure Synapse Correctness #17116

Merged
merged 13 commits into from
Dec 27, 2021
Merged

[Synapse] Azure Synapse Correctness #17116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b4a1b5a
[Synapse] Azure Synapse Correctness
Dec 16, 2021
fd75167
roundtripCorrectnessFixes
Dec 19, 2021
e09606f
Prettier and Semantic fix
Dec 20, 2021
2445124
Model, Semantic and Prettier fix
Dec 20, 2021
6dd9c72
More Correctness changes
Dec 20, 2021
6cea235
More Correctness changes
Dec 21, 2021
5a94d86
Lint changes
Dec 21, 2021
cf4c3f6
Lint Diff Fix
Dec 21, 2021
6fdef7c
Suggestions Incoporation
Dec 22, 2021
2fc1d36
Review Comment Incoporation
Dec 23, 2021
00eda9b
Review Comments Incoporation 1
Dec 23, 2021
e83a12b
Semantic fix
Dec 23, 2021
bafcc3c
Review Comment Incoporation
Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...on/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,8 @@
"creationDate": {
"type": "string",
"format": "date-time",
"description": "The time when the Big Data pool was created."
"description": "The time when the Big Data pool was created.",
"readOnly": true
},
"autoPause": {
"$ref": "#/definitions/AutoPauseProperties",
Expand Down Expand Up @@ -544,6 +545,16 @@
"enabled": {
"type": "boolean",
"description": "Indicates whether Dynamic Executor Allocation is enabled or not."
},
"minExecutors": {
"type": "integer",
"format": "int32",
"description": "The minimum number of executors alloted"
},
"maxExecutors": {
"type": "integer",
"format": "int32",
"description": "The maximum number of executors alloted"
}
}
},
Expand Down
2 changes: 0 additions & 2 deletions ...resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/CreateSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,10 @@
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"provisioningState": "Provisioning",
"status": "Paused",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z",
"storageAccountType": "LRS"
}
Expand Down
8 changes: 1 addition & 7 deletions ...resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/UpdateSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,7 @@
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z"
"restorePointInTime": "1970-01-01T00:00:00.000Z"
}
}
},
Expand All @@ -39,12 +35,10 @@
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"provisioningState": "Provisioning",
"status": "Paused",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z",
"storageAccountType": "GRS"
}
Expand Down
35 changes: 35 additions & 0 deletions ...pse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,6 +1386,11 @@
"description": "Managed integration runtime properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/ManagedIntegrationRuntimeTypeProperties"
},
"managedVirtualNetwork": {
"description": "Managed integration runtime managed virtual network.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/ManagedIntegrationRuntimeManagedVirtualNetworkReference"
}
},
"required": [
Expand All @@ -1406,6 +1411,24 @@
}
}
},
"ManagedIntegrationRuntimeManagedVirtualNetworkReference": {
"description": "Managed integration runtime managed virtual network reference.",
"type": "object",
"properties": {
"referenceName": {
"description": "The reference name of the managed virtual network.",
"type": "string"
},
"type": {
"description": "The type of the managed virtual network.",
"type": "string"
},
"id": {
"description": "The id of the managed virtual network.",
"type": "string"
}
}
},
"IntegrationRuntimeComputeProperties": {
"description": "The compute resource properties for managed integration runtime.",
"type": "object",
Expand Down Expand Up @@ -2236,6 +2259,18 @@
"type": "string",
"format": "date-time",
"readOnly": true
},
"serviceRegion": {
"description": "The service region of the integration runtime",
"type": "string"
},
"newerVersions": {
"description": "The newer versions on download center.",
"type": "array",
"items": {
"description": "The newer versions",
"type": "string"
}
}
}
},
Expand Down
24 changes: 17 additions & 7 deletions ...cation/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5330,7 +5330,11 @@
},
"sourceDatabaseId": {
"type": "string",
"description": "Source database to create from"
"description": "Source database to create from",
"x-ms-mutability": [
"create",
"update"
]
},
"recoverableDatabaseId": {
"type": "string",
Expand All @@ -5342,7 +5346,8 @@
},
"status": {
"type": "string",
"description": "Resource status"
"description": "Resource status",
"readOnly": true
},
"restorePointInTime": {
"type": "string",
Expand All @@ -5361,19 +5366,23 @@
"x-ms-enum": {
"name": "createMode",
"modelAsString": true
}
},
"x-ms-mutability": [
"create",
"update"
]
},
"creationDate": {
"type": "string",
"description": "Date the SQL pool was created",
"format": "date-time"
"format": "date-time",
"readOnly": true
},
"storageAccountType": {
"description": "The storage account type used to store backups for this sql pool.",
"enum": [
"GRS",
"LRS",
"ZRS"
"LRS"
],
"type": "string",
"x-ms-enum": {
Expand Down Expand Up @@ -5409,7 +5418,8 @@
"syncIntervalInMinutes": {
"type": "integer",
"format": "int32",
"description": "The Sync Interval in minutes."
"description": "The Sync Interval in minutes.",
"readOnly": true
}
},
"x-ms-client-flatten": true
Expand Down
8 changes: 6 additions & 2 deletions ...tion/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,14 +1487,18 @@
},
"ServerVulnerabilityAssessmentProperties": {
"description": "Properties of a server Vulnerability Assessment.",
"type": "object",
"required": [
"storageContainerPath"
niks02 marked this conversation as resolved.
Show resolved Hide resolved
],
"type": "object",
"properties": {
"storageContainerPath": {
"description": "A blob storage container path to hold the scan results (e.g. https://myStorage.blob.core.windows.net/VaScans/).",
"type": "string"
"type": "string",
"x-ms-mutability": [
"create",
"read"
]
},
"storageContainerSasKey": {
"description": "A shared access signature (SAS Key) that has read and write access to the blob container specified in 'storageContainerPath' parameter. If 'storageAccountAccessKey' isn't specified, StorageContainerSasKey is required.",
Expand Down
18 changes: 16 additions & 2 deletions ...tion/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,11 @@
"properties": {
"accountUrl": {
"description": "Account URL",
"type": "string"
"type": "string",
"x-ms-mutability": [
"create",
"read"
]
},
"filesystem": {
"description": "Filesystem name",
Expand Down Expand Up @@ -1170,7 +1174,11 @@
"properties": {
"initialWorkspaceAdminObjectId": {
"description": "AAD object ID of initial workspace admin",
"type": "string"
"type": "string",
"x-ms-mutability": [
"create",
"read"
]
}
}
},
Expand Down Expand Up @@ -1282,6 +1290,7 @@
"Disabled"
],
"description": "Enable or Disable public network access to workspace",
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "WorkspacePublicNetworkAccess",
Expand All @@ -1303,6 +1312,11 @@
"azureADOnlyAuthentication": {
"description": "Enable or Disable AzureADOnlyAuthentication on All Workspace subresource",
"type": "boolean"
},
"trustedServiceBypassEnabled": {
"description": "Is trustedServiceBypassEnabled for the workspace",
"type": "boolean",
"default": false
}
}
},
Expand Down
48 changes: 46 additions & 2 deletions specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/bigDataPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,8 @@
"creationDate": {
"type": "string",
"format": "date-time",
"description": "The time when the Big Data pool was created."
"description": "The time when the Big Data pool was created.",
"readOnly": true
},
"autoPause": {
"$ref": "#/definitions/AutoPauseProperties",
Expand Down Expand Up @@ -450,7 +451,7 @@
}
},
"sparkConfigProperties": {
"$ref": "#/definitions/LibraryRequirements",
"$ref": "#/definitions/SparkConfigProperties",
"description": "Spark configuration file to specify additional properties"
},
"sparkVersion": {
Expand Down Expand Up @@ -544,6 +545,16 @@
"enabled": {
"type": "boolean",
"description": "Indicates whether Dynamic Executor Allocation is enabled or not."
},
"minExecutors": {
"type": "integer",
"format": "int32",
"description": "The minimum number of executors alloted"
},
"maxExecutors": {
"type": "integer",
"format": "int32",
"description": "The maximum number of executors alloted"
}
}
},
Expand Down Expand Up @@ -606,6 +617,39 @@
"description": "The filename of the library requirements file."
}
}
},
"SparkConfigProperties": {
"type": "object",
"description": "SparkConfig Properties for a Big Data pool powered by Apache Spark",
"title": "Spark pool Config Properties",
"properties": {
"time": {
"type": "string",
"format": "date-time",
"readOnly": true,
"description": "The last update time of the spark config properties file."
},
"content": {
"type": "string",
"description": "The spark config properties."
},
"filename": {
"type": "string",
"description": "The filename of the spark config properties file."
},
"configurationType": {
"enum": [
"File",
"Artifact"
],
"type": "string",
niks02 marked this conversation as resolved.
Show resolved Hide resolved
"description": "The type of the spark config properties file.",
"x-ms-enum": {
"name": "ConfigurationType",
"modelAsString": true
}
}
}
}
}
}
1 change: 1 addition & 0 deletions ...e/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/CreateIpFirewallRule.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
}
}
},
"202": {},
"default": {
"body": {
"error": {
Expand Down
2 changes: 0 additions & 2 deletions .../synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/CreateSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,10 @@
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"provisioningState": "Provisioning",
"status": "Paused",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z",
"storageAccountType": "LRS"
}
Expand Down
8 changes: 1 addition & 7 deletions .../synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/UpdateSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,7 @@
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z"
"restorePointInTime": "1970-01-01T00:00:00.000Z"
}
}
},
Expand All @@ -39,12 +35,10 @@
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"provisioningState": "Provisioning",
"status": "Paused",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z",
"storageAccountType": "GRS"
}
Expand Down
3 changes: 3 additions & 0 deletions specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/firewallRule.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@
},
"description": ""
},
"202": {
"description": ""
},
"default": {
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
Expand Down
Loading