Added listServicePrincipalId #17068
Added listServicePrincipalId #17068
Conversation
|
Hi, @ikanni Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L1287:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L1332:5 |
️⚠️LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: authorizationSet Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L1746 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @ikanni your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
|
Hi @ikanni, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
|
Hi @ikanni, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@ikanni, ARM review is waiting until the NewApiVersionRequired label has been addressed. If you want to add a new API to an existing API version, you will need to get breaking change approval. I've added the breaking change label which gives the instructions for requesting breaking change approval. Otherwise, please put the new API into a new API version. |
| "x-ms-client-flatten": true, | ||
| "$ref": "#/definitions/ServicePrincipalProperties", | ||
| "description": "The Service Principal properties for the subscription" | ||
| } |
There was a problem hiding this comment.
Yes it is a Proxy resource. We have updated in Manifest
There was a problem hiding this comment.
No like reference a ProxyResource object. For example you can see how other swaggers reference : https://github.com/Azure/azure-rest-api-specs-pr/blob/main/specification/common-types/resource-management/v3/types.json#L91
There was a problem hiding this comment.
Thank you got it! I will fix it now
There was a problem hiding this comment.
@raosuhas When I reference ProxyResource, I got the below error for RequiredReadOnlySystemData
Since we are doing get only, Can we return systemData.createdBy as SYSTEM and systemData.createdAt as "0001-01-01T00:00:00.00Z" ?
There was a problem hiding this comment.
@raosuhas Above comment is fixed and I will resolve once you answer for the above question.
.../automanage/resource-manager/Microsoft.Automanage/preview/2021-04-30-preview/automanage.json
Show resolved
Hide resolved
raosuhas
added
WaitForARMRevisit
and removed
ARMSignedOff
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
NewApiVersionRequired
labels
pilor
added
ARMSignedOff
|
@ruowan Could you please help in merging this PR? Let me know If I need to get any approvals before merging. |
* Added listServicePrincipalId * Fixed few errors * Fixed spelling * Fixed few errors * Fixed few errors * Added listServicePrincipalId * Fixed one error * Fixed few errors * Fixed error * Fixed error * Updated tag to trigger a build * Fixed spelling * Fixed comment * Changed from Post to get to work in ARM template * fixed failure * fixed failure * fixed warning * Refferred ProxyResource * Fixed ProxyResource and another comment * Added systemData for ServicePrincipal * Added Collection GET for Singleton * Fixed error and warnings * Fixed PrettierCheck error
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[X] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.