Exposing membershipType property from Access review APIs #16919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamguptacal
requested review from
BigCat20196,
msyyc,
RAY-316 and
stankovski
as code owners
|
Hi, @shubhamguptacal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
shubhamguptacal
changed the title
|
Hi @shubhamguptacal, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 30, 2021
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
from
39c183f to
5cf9749
Compare
This was referenced Nov 30, 2021
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
from
5cf9749 to
e564ab4
Compare
openapi-pipeline-app
bot
added
CI-BreakingChange-Go
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
2 times, most recently
from
a9a0f72 to
8f3eba7
Compare
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
2 times, most recently
from
107ae28 to
0bdcf45
Compare
openapi-pipeline-app
bot
removed
CI-BreakingChange-Go
CI-BreakingChange-Python-Track2
labels
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
2 times, most recently
from
40373a0 to
931ef6b
Compare
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
from
931ef6b to
e8f66d4
Compare
shubhamguptacal
force-pushed
the
shugup/expose_membershiptype
branch
from
e8f66d4 to
2cc4506
Compare
openapi-pipeline-app
bot
removed
CI-FixRequiredOnFailure
CI-BreakingChange-Python-Track2
labels
ruowan
approved these changes
Jun 30, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 30, 2022
[ReleasePR track2_azure-mgmt-authorization] Update readme.python.md
Azure/azure-sdk-for-python#24660
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 30, 2022
…operty from Access review APIs (#2447) Create to sync Azure/azure-rest-api-specs#16919 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/authorization_resource-manager?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Context
Access reviews allow you to create reviews of azure subscription roles In access review APIs. Every access review has decision items(Collection of "AccessReviewDecision" entities) which represent items that need to be reviewed. Every decision item has two core properties : "principal" and "resource". The "principal" property defines details about the user/SP being reviewed and the "resource" property defines details about the role for which the prinicipal's access is being reviewed. What's missing today is that we don't surface up details about the kind of membership the principal has to the resource. To do so, we want to add a new property "principalResourceMembership" which contains details about the membership itself. To get started, we're exposing one property : "membershipTypes" inside "principalResourceMembership" to indicate the kinds of membership a principal can have to the resource. A principal can have direct and/or indirect access(through a nested group for example) to a resource.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.