Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Factory] adding parameters for dataflow activity #16603

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

bannama
Copy link
Contributor

@bannama bannama commented Oct 29, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @bannama Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 29, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    1045 - AddedOptionalProperty The new version has a new optional property 'parameters' that was not found in the old version.
    New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6692:7
    Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6692:7
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 29, 2021

    Swagger Generation Artifacts

    ️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=261743&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - v59.0.0
    -	Const `TypeBasicDatasetCompressionTypeBZip2` has been removed
    -	Const `TypeBasicDatasetCompressionTypeDatasetCompression` has been removed
    -	Const `TypeBasicDatasetCompressionTypeDeflate` has been removed
    -	Const `TypeBasicDatasetCompressionTypeGZip` has been removed
    -	Const `TypeBasicDatasetCompressionTypeTarGZip` has been removed
    -	Const `TypeBasicDatasetCompressionTypeTar` has been removed
    -	Const `TypeBasicDatasetCompressionTypeZipDeflate` has been removed
    -	Function `*DatasetBZip2Compression.UnmarshalJSON` has been removed
    -	Function `*DatasetDeflateCompression.UnmarshalJSON` has been removed
    -	Function `*DatasetGZipCompression.UnmarshalJSON` has been removed
    -	Function `*DatasetTarCompression.UnmarshalJSON` has been removed
    -	Function `*DatasetTarGZipCompression.UnmarshalJSON` has been removed
    -	Function `*DatasetZipDeflateCompression.UnmarshalJSON` has been removed
    -	Function `DatasetBZip2Compression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetCompression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetTarCompression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetBZip2Compression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetBZip2Compression.MarshalJSON` has been removed
    -	Function `DatasetCompression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetCompression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetCompression.AsDatasetCompression` has been removed
    -	Function `DatasetCompression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetCompression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetCompression.AsDatasetTarCompression` has been removed
    -	Function `DatasetCompression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetCompression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetDeflateCompression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetCompression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetTarCompression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetDeflateCompression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetDeflateCompression.MarshalJSON` has been removed
    -	Function `DatasetGZipCompression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetCompression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetTarCompression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetGZipCompression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetGZipCompression.MarshalJSON` has been removed
    -	Function `DatasetTarCompression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetTarCompression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetTarCompression.AsDatasetCompression` has been removed
    -	Function `DatasetTarCompression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetTarCompression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetTarCompression.AsDatasetTarCompression` has been removed
    -	Function `DatasetTarCompression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetTarCompression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetTarCompression.MarshalJSON` has been removed
    -	Function `DatasetTarGZipCompression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetCompression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetTarCompression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetTarGZipCompression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetTarGZipCompression.MarshalJSON` has been removed
    -	Function `DatasetZipDeflateCompression.AsBasicDatasetCompression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetBZip2Compression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetCompression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetDeflateCompression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetGZipCompression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetTarCompression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetTarGZipCompression` has been removed
    -	Function `DatasetZipDeflateCompression.AsDatasetZipDeflateCompression` has been removed
    -	Function `DatasetZipDeflateCompression.MarshalJSON` has been removed
    -	Function `PossibleTypeBasicDatasetCompressionValues` has been removed
    -	Struct `DatasetBZip2Compression` has been removed
    -	Struct `DatasetDeflateCompression` has been removed
    -	Struct `DatasetGZipCompression` has been removed
    -	Struct `DatasetTarCompression` has been removed
    -	Struct `DatasetTarGZipCompression` has been removed
    -	Struct `DatasetZipDeflateCompression` has been removed
    -	Type of `AmazonS3DatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `AzureBlobDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `AzureBlobFSDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `AzureDataLakeStoreDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `BinaryDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `DatasetCompression.Type` has been changed from `TypeBasicDatasetCompression` to `interface{}`
    -	Type of `ExcelDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `FileShareDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `HTTPDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `JSONDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    -	Type of `XMLDatasetTypeProperties.Compression` has been changed from `BasicDatasetCompression` to `*DatasetCompression`
    azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - v59.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3e1fbc1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model DataFlowReference has a new parameter parameters
      info	[Changelog]   - Model PowerQuerySource has a new parameter flowlet
      info	[Changelog]   - Model DataFlowSink has a new parameter flowlet
      info	[Changelog]   - Model DataFlowDebugPackage has a new parameter data_flows
      info	[Changelog]   - Model DatasetCompression has a new parameter level
      info	[Changelog]   - Model Transformation has a new parameter flowlet
      info	[Changelog]   - Model Transformation has a new parameter linked_service
      info	[Changelog]   - Model Transformation has a new parameter dataset
      info	[Changelog]   - Model DataFlowSource has a new parameter flowlet
      info	[Changelog]   - Model MappingDataFlow has a new parameter script_lines
      info	[Changelog]   - Model PowerQuerySink has a new parameter flowlet
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3e1fbc1. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-11-11 09:32:41 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datafactory;1.0.0-beta.7;1.0.0-beta.8"
      cmderr	[generate.py] 2021-11-11 09:32:41 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.8"
      cmderr	[generate.py] 2021-11-11 09:32:41 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datafactory/azure-resourcemanager-datafactory --java.namespace=com.azure.resourcemanager.datafactory   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-datafactory
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [POM][Skip] pom already has module azure-resourcemanager-datafactory
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [POM][Skip] pom already has module sdk/datafactory
      cmderr	[generate.py] 2021-11-11 09:34:02 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] 2021-11-11 09:35:31 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-datafactory [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-11-11 09:35:35 DEBUG Got artifact_id: azure-resourcemanager-datafactory
      cmderr	[Inst] 2021-11-11 09:35:35 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-11-11 09:35:35 ERROR Unmatch any jar in artifacts
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3e1fbc1. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetTarGZipCompression` has been removed
      info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetDeflateCompression` has been removed
      info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetTarCompression` has been removed
      info	[Changelog] - Function `DatasetDeflateCompression.AsDatasetTarCompression` has been removed
      info	[Changelog] - Function `DatasetGZipCompression.AsDatasetTarGZipCompression` has been removed
      info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetBZip2Compression` has been removed
      info	[Changelog] - Function `DatasetGZipCompression.AsBasicDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetCompression.AsDatasetDeflateCompression` has been removed
      info	[Changelog] - Function `DatasetDeflateCompression.AsDatasetGZipCompression` has been removed
      info	[Changelog] - Function `DatasetZipDeflateCompression.AsBasicDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetDeflateCompression.AsBasicDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetTarCompression.AsDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetDeflateCompression.AsDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetGZipCompression.AsDatasetCompression` has been removed
      info	[Changelog] - Function `DatasetCompression.AsDatasetTarGZipCompression` has been removed
      info	[Changelog] - Function `DatasetCompression.AsDatasetTarCompression` has been removed
      info	[Changelog] - Function `DatasetZipDeflateCompression.AsDatasetTarCompression` has been removed
      info	[Changelog] - Function `DatasetGZipCompression.AsDatasetTarCompression` has been removed
      info	[Changelog] - Struct `DatasetBZip2Compression` has been removed
      info	[Changelog] - Struct `DatasetDeflateCompression` has been removed
      info	[Changelog] - Struct `DatasetGZipCompression` has been removed
      info	[Changelog] - Struct `DatasetTarCompression` has been removed
      info	[Changelog] - Struct `DatasetTarGZipCompression` has been removed
      info	[Changelog] - Struct `DatasetZipDeflateCompression` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `TypeBasicDataFlowTypeFlowlet`
      info	[Changelog] - New function `*Flowlet.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `Flowlet.AsBasicDataFlow() (BasicDataFlow, bool)`
      info	[Changelog] - New function `Flowlet.AsDataFlow() (*DataFlow, bool)`
      info	[Changelog] - New function `Flowlet.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `Flowlet.AsWranglingDataFlow() (*WranglingDataFlow, bool)`
      info	[Changelog] - New function `DataFlowReference.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `DataFlow.AsFlowlet() (*Flowlet, bool)`
      info	[Changelog] - New function `MappingDataFlow.AsFlowlet() (*Flowlet, bool)`
      info	[Changelog] - New function `WranglingDataFlow.AsFlowlet() (*Flowlet, bool)`
      info	[Changelog] - New function `Flowlet.AsFlowlet() (*Flowlet, bool)`
      info	[Changelog] - New function `Flowlet.AsMappingDataFlow() (*MappingDataFlow, bool)`
      info	[Changelog] - New struct `Flowlet`
      info	[Changelog] - New struct `FlowletTypeProperties`
      info	[Changelog] - New struct `PowerQuerySinkMapping`
      info	[Changelog] - New field `Dataset` in struct `Transformation`
      info	[Changelog] - New field `LinkedService` in struct `Transformation`
      info	[Changelog] - New field `Flowlet` in struct `Transformation`
      info	[Changelog] - New field `Flowlet` in struct `PowerQuerySink`
      info	[Changelog] - New field `Level` in struct `DatasetCompression`
      info	[Changelog] - New field `Queries` in struct `ExecutePowerQueryActivityTypeProperties`
      info	[Changelog] - New field `Parameters` in struct `DataFlowReference`
      info	[Changelog] - New field `Flowlet` in struct `DataFlowSink`
      info	[Changelog] - New field `DataFlows` in struct `DataFlowDebugPackage`
      info	[Changelog] - New field `ScriptLines` in struct `MappingDataFlowTypeProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `FactoryUpdateParameters`
      info	[Changelog] - New field `Flowlet` in struct `DataFlowSource`
      info	[Changelog] - New field `DocumentLocale` in struct `PowerQueryTypeProperties`
      info	[Changelog] - New field `Flowlet` in struct `PowerQuerySource`
      info	[Changelog]
      info	[Changelog] Total 100 breaking change(s), 31 additive change(s).
      info	[Changelog]
    • ️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logsBreaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Insert`
      info	[Changelog] - New const `LOCALQUORUM`
      info	[Changelog] - New const `IntegrationRuntimeStateLimited`
      info	[Changelog] - New const `QueryAll`
      info	[Changelog] - New const `IntegrationRuntimeStateStopped`
      info	[Changelog] - New const `Int64`
      info	[Changelog] - New const `Disabled`
      info	[Changelog] - New const `ALL`
      info	[Changelog] - New const `Recycling`
      info	[Changelog] - New const `ONE`
      info	[Changelog] - New const `IntegrationRuntimeStateOnline`
      info	[Changelog] - New const `Optimal`
      info	[Changelog] - New const `IntegrationRuntimeStateOffline`
      info	[Changelog] - New const `TWO`
      info	[Changelog] - New const `Boolean`
      info	[Changelog] - New const `IntegrationRuntimeStateStopping`
      info	[Changelog] - New const `Upsert`
      info	[Changelog] - New const `IntegrationRuntimeStateStarting`
      info	[Changelog] - New const `Upload`
      info	[Changelog] - New const `Percentage`
      info	[Changelog] - New const `Available`
      info	[Changelog] - New const `Date`
      info	[Changelog] - New const `Merge`
      info	[Changelog] - New const `Int`
      info	[Changelog] - New const `GUID`
      info	[Changelog] - New const `Decimal`
      info	[Changelog] - New const `LOCALONE`
      info	[Changelog] - New const `String`
      info	[Changelog] - New const `SERIAL`
      info	[Changelog] - New const `QUORUM`
      info	[Changelog] - New const `Query`
      info	[Changelog] - New const `LOCALSERIAL`
      info	[Changelog] - New const `Unavailable`
      info	[Changelog] - New const `IntegrationRuntimeStateNeedRegistration`
      info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorUpdate`
      info	[Changelog] - New const `IntegrationRuntimeStateInitial`
      info	[Changelog] - New const `EACHQUORUM`
      info	[Changelog] - New const `IntegrationRuntimeStateStarted`
      info	[Changelog] - New const `OnPremisesWithIfd`
      info	[Changelog] - New const `THREE`
      info	[Changelog] - New const `Fastest`
      info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorInsert`
      info	[Changelog] - New const `Value`
      info	[Changelog] - New const `Office365`
      info	[Changelog] - New const `Ifd`
      info	[Changelog] - New function `PossibleCassandraSourceReadConsistencyLevelsValues() []CassandraSourceReadConsistencyLevels`
      info	[Changelog] - New function `PossibleAzureSearchIndexWriteBehaviorTypeValues() []AzureSearchIndexWriteBehaviorType`
      info	[Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel`
      info	[Changelog] - New function `PossibleSapCloudForCustomerSinkWriteBehaviorValues() []SapCloudForCustomerSinkWriteBehavior`
      info	[Changelog] - New function `PossibleDynamicsAuthenticationTypeValues() []DynamicsAuthenticationType`
      info	[Changelog] - New function `PossibleStoredProcedureParameterTypeValues() []StoredProcedureParameterType`
      info	[Changelog] - New function `PossibleDynamicsDeploymentTypeValues() []DynamicsDeploymentType`
      info	[Changelog] - New function `PossiblePolybaseSettingsRejectTypeValues() []PolybaseSettingsRejectType`
      info	[Changelog] - New function `PossibleSalesforceSourceReadBehaviorValues() []SalesforceSourceReadBehavior`
      info	[Changelog] - New function `PossibleSalesforceSinkWriteBehaviorValues() []SalesforceSinkWriteBehavior`
      info	[Changelog]
      info	[Changelog] Total 28 breaking change(s), 55 additive change(s).
      info	[Changelog]
    ️❌ azure-sdk-for-go-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 3e1fbc1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
      cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/datafactory/armdatafactory, try to build in /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
      cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
      cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
      cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.2.3; node: v14.18.1, max-memory: 8192 MB]
      cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
      cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
      cmderr	[generator automation-v2] [ERROR] NOTE: AutoRest core version selected from configuration: 3.6.2.
      cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.4.2).
      cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/vsts/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.6.2)
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest extension '@autorest/go' (4.0.0-preview.31->4.0.0-preview.31)
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest extension '@autorest/modelerfour' (4.21.1->4.21.1)
      cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PipelineRun > properties > invokedBy)
      cmderr	[generator automation-v2] [ERROR] keys: [ �[32m'readOnly'�[39m ]
      cmderr	[generator automation-v2] [ERROR] - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json:5789:9
      cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
      cmderr	[generator automation-v2] [ERROR] error   | DiscriminatorNotRequired | Semantic violation: Discriminator must be a required property. (components > schemas > DataFlow)
      cmderr	[generator automation-v2] [ERROR] discriminator: { propertyName: �[32m'type'�[39m }
      cmderr	[generator automation-v2] [ERROR] - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/DataFlow.json:20:5
      cmderr	[generator automation-v2] [ERROR] Error: Semantic validation failed. There was some errors
      cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
      cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh.exe": exit status 1
      cmderr	[generator automation-v2] [ERROR] ': exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3e1fbc1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datafactory [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 1, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants