Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations #16590

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations #16590

merged 3 commits into from
Dec 16, 2021

Conversation

kamusta-msft
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • [X ] update existing version for new feature
    • [ X] update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @kamusta-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 28, 2021

    Swagger Validation Report

    ️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'timeCreated' renamed or removed?
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L8372:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L8345:7
    1041 - AddedPropertyInResponse The new version has a new property 'allowExtensionOperations' in response that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L12593:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L12558:7
    1041 - AddedPropertyInResponse The new version has a new property 'protectedSettingsFromKeyVault' in response that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L13350:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L13311:7
    1045 - AddedOptionalProperty The new version has a new optional property 'provisioningDetails' that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L8372:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L8345:7
    1045 - AddedOptionalProperty The new version has a new optional property 'protectedSettingsFromKeyVault' that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L9515:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L9488:7
    1045 - AddedOptionalProperty The new version has a new optional property 'protectedSettingsFromKeyVault' that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L9569:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L9538:7
    1045 - AddedOptionalProperty The new version has a new optional property 'allowExtensionOperations' that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L12593:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L12558:7
    1045 - AddedOptionalProperty The new version has a new optional property 'protectedSettingsFromKeyVault' that was not found in the old version.
    New: Microsoft.Compute/stable/2021-07-01/compute.json#L13350:7
    Old: Microsoft.Compute/stable/2021-07-01/compute.json#L13311:7
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowExtensionOperations
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L12625


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L49
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L100
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L151
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L188
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L225
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L257
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L297
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L339
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L390
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L447
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L489
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L535
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L565
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L605
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L661
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L718
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L755
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L807
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L844
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L872
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L930
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L995
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1040
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1103
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1147
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1175
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1210
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1261
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1318
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-11-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️🔄SDK Track2 Validation inProgress [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Compute label Oct 28, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 28, 2021

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armcompute - 0.2.2
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 23.1.0
    ️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v60.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v60.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v60.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2021-07-01/compute - v60.2.0
    ⚠️azure-sdk-for-go - compute/mgmt/2021-04-01/compute - v60.2.0
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ⚠️azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v60.2.0
    +	Field `ConsistencyMode` of struct `RestorePoint` has been removed
    +	Field `ExcludeDisks` of struct `RestorePoint` has been removed
    +	Field `ProvisioningDetails` of struct `RestorePoint` has been removed
    +	Field `ProvisioningState` of struct `RestorePoint` has been removed
    +	Field `PublicIPAddressSkuName` of struct `PublicIPAddressSku` has been removed
    +	Field `PublicIPAddressSkuTier` of struct `PublicIPAddressSku` has been removed
    +	Field `SourceMetadata` of struct `RestorePoint` has been removed
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ️✔️azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v60.2.0
    ⚠️azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v60.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v60.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v60.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v60.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v60.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v60.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v60.2.0
    ️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v60.2.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v60.2.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v60.2.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.Compute [View full logs]  [Preview SDK Changes]
      cmderr	[msbuild] Could not execute because the application was not found or a compatible .NET SDK is not installed.
      cmderr	[msbuild] Possible reasons for this include:
      cmderr	[msbuild]   * You intended to execute a .NET program:
      cmderr	[msbuild]       The application 'msbuild' does not exist.
      cmderr	[msbuild]   * You intended to execute a .NET SDK command:
      cmderr	[msbuild]       A compatible installed .NET SDK for global.json version [6.0.100] from [/home/vsts/work/1/s/azure-sdk-for-net/global.json] was not found.
      cmderr	[msbuild]       Install the [6.0.100] .NET SDK or update [/home/vsts/work/1/s/azure-sdk-for-net/global.json] with an installed .NET SDK:
      error	Script return with result [failed] code [145] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model VirtualMachineExtension has a new parameter protected_settings_from_key_vault
      info	[Changelog]   - Model VirtualMachineExtensionUpdate has a new parameter protected_settings_from_key_vault
      info	[Changelog]   - Model VirtualMachineScaleSetExtension has a new parameter protected_settings_from_key_vault
      info	[Changelog]   - Model VirtualMachineScaleSetExtensionUpdate has a new parameter protected_settings_from_key_vault
      info	[Changelog]   - Model VirtualMachineScaleSetOSProfile has a new parameter allow_extension_operations
      info	[Changelog]   - Model VirtualMachineScaleSetVMExtension has a new parameter protected_settings_from_key_vault
      info	[Changelog]   - Model VirtualMachineScaleSetVMExtensionUpdate has a new parameter protected_settings_from_key_vault
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-12-16 18:56:46 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
      cmderr	[generate.py] 2021-12-16 18:56:46 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-12-16 18:56:46 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[generate.py] 2021-12-16 18:58:18 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-12-16 18:58:18 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-12-16 18:58:18 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
      cmderr	[generate.py] 2021-12-16 18:58:18 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-12-16 18:58:18 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-12-16 18:58:18 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-12-16 19:02:31 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16590/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] npm notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-compute [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2021-07-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `ProtectedSettingsFromKeyVault` in struct `VirtualMachineExtensionProperties`
      info	[Changelog] - New field `ProtectedSettingsFromKeyVault` in struct `VirtualMachineScaleSetExtensionProperties`
      info	[Changelog] - New field `ProtectedSettingsFromKeyVault` in struct `VirtualMachineExtensionUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2021-04-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `PublicNetworkAccess` in struct `DiskProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `SnapshotUpdateProperties`
      info	[Changelog] - New field `AutoKeyRotationError` in struct `EncryptionSetProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 15 additive change(s).
    • ️✔️compute/mgmt/2021-03-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `Name` in struct `PublicIPAddressSku`
      info	[Changelog] - New field `Location` in struct `RestorePointSourceMetadata`
      info	[Changelog] - New anonymous field `*RestorePointProperties` in struct `RestorePoint`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 21 additive change(s).
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2020-06-30/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `LogAnalyticsInputBase`
      info	[Changelog] - New field `GroupByUserAgent` in struct `LogAnalyticsInputBase`
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
    • ️✔️compute/mgmt/2020-06-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `LogAnalyticsInputBase`
      info	[Changelog] - New field `GroupByUserAgent` in struct `LogAnalyticsInputBase`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
    • ️✔️compute/mgmt/2019-12-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2019-07-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2019-03-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcompute [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 7f36f33f49108eacc85b5cb41b0f59bc47be2e19. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @kamusta-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @ghost
    Copy link

    ghost commented Nov 14, 2021

    Hi, @kamusta-msft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @openapi-workflow-bot
    Copy link

    Hi @kamusta-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @grizzlytheodore grizzlytheodore added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 3, 2021
    @grizzlytheodore
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @grizzlytheodore grizzlytheodore merged commit 220cfd0 into Azure:feature/cplat-2021-11-01 Dec 16, 2021
    grizzlytheodore added a commit that referenced this pull request Dec 16, 2021
    grizzlytheodore added a commit that referenced this pull request Dec 16, 2021
    grizzlytheodore pushed a commit that referenced this pull request Jan 3, 2022
    …16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    grizzlytheodore added a commit that referenced this pull request Jan 3, 2022
    ArcturusZhang added a commit that referenced this pull request Jan 19, 2022
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (#16570)" (#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * suppress bodyTopLevelProperties
    
    * Add VMSS filter to List VMs (#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * add suppression for required properties
    
    * Revert "Add VMSS filter to List VMs (#16813)" (#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (#16544)
    
    * Downmerging change from Azure:main (#16654)
    
    Co-authored-by: Avinash Akka <[email protected]>
    
    * Added CVM settings for version 2021-11-01 (#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (#17041)
    
    * save (#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - #10190
    
    * add vmss filter to list  (#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)" (#17121)
    
    This reverts commit 220cfd0.
    
    * fix CI failures, and run prettier on added examples
    
    * for credscan. change password example
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * make new api call long-running-operation
    
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (#16570)" (#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * Add VMSS filter to List VMs (#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * Revert "Add VMSS filter to List VMs (#16813)" (#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (#16544)
    
    * Added CVM settings for version 2021-11-01 (#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (#17041)
    
    * save (#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - #10190
    
    * add vmss filter to list  (#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * fix CI failures, and run prettier on added examples
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)" (#17121)
    
    This reverts commit 220cfd0.
    
    * for credscan. change password example
    
    * make new api call long-running-operation
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * update Repair action to enum and update readme
    
    * rebase to main since 2021-08-01 merged. update readme
    
    * update x-ms-enum name for RepairType
    
    * add default response to operations
    
    * update
    
    * put back 'required' tag for Resource.Location property
    and use a new object for VM_LIST return object
    
    * fix json format
    
    * update examples
    
    * run prettier on updated examples
    
    * update example for credScan
    
    * add VirtualMachineResource for toplevel property suppression.
    
    * lint diff errors
    
    * lint diff fix update
    
    * remove change for VMextensions.location bug
    
    * return readme file and examples before vm.vmextension.location change
    
    Co-authored-by: sukodava <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: xielexie <[email protected]>
    Co-authored-by: Mike Richmond <[email protected]>
    Co-authored-by: Avinash <[email protected]>
    Co-authored-by: Avinash Akka <[email protected]>
    Co-authored-by: ms-saypaul <[email protected]>
    Co-authored-by: Raktima Das <[email protected]>
    Co-authored-by: kamusta-msft <[email protected]>
    Co-authored-by: frank-pang-msft <[email protected]>
    Co-authored-by: Chase VanBuskirk <[email protected]>
    Co-authored-by: Chase Van Buskirk <[email protected]>
    Co-authored-by: vbhasker-msft <[email protected]>
    Co-authored-by: avjai <[email protected]>
    Co-authored-by: kangsun-ctrl <[email protected]>
    Co-authored-by: karthikka4820 <[email protected]>
    Co-authored-by: LexieXie <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * suppress bodyTopLevelProperties
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * add suppression for required properties
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Downmerging change from Azure:main (Azure#16654)
    
    Co-authored-by: Avinash Akka <[email protected]>
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * fix CI failures, and run prettier on added examples
    
    * for credscan. change password example
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * make new api call long-running-operation
    
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * fix CI failures, and run prettier on added examples
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * for credscan. change password example
    
    * make new api call long-running-operation
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * update Repair action to enum and update readme
    
    * rebase to main since 2021-08-01 merged. update readme
    
    * update x-ms-enum name for RepairType
    
    * add default response to operations
    
    * update
    
    * put back 'required' tag for Resource.Location property
    and use a new object for VM_LIST return object
    
    * fix json format
    
    * update examples
    
    * run prettier on updated examples
    
    * update example for credScan
    
    * add VirtualMachineResource for toplevel property suppression.
    
    * lint diff errors
    
    * lint diff fix update
    
    * remove change for VMextensions.location bug
    
    * return readme file and examples before vm.vmextension.location change
    
    Co-authored-by: sukodava <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: xielexie <[email protected]>
    Co-authored-by: Mike Richmond <[email protected]>
    Co-authored-by: Avinash <[email protected]>
    Co-authored-by: Avinash Akka <[email protected]>
    Co-authored-by: ms-saypaul <[email protected]>
    Co-authored-by: Raktima Das <[email protected]>
    Co-authored-by: kamusta-msft <[email protected]>
    Co-authored-by: frank-pang-msft <[email protected]>
    Co-authored-by: Chase VanBuskirk <[email protected]>
    Co-authored-by: Chase Van Buskirk <[email protected]>
    Co-authored-by: vbhasker-msft <[email protected]>
    Co-authored-by: avjai <[email protected]>
    Co-authored-by: kangsun-ctrl <[email protected]>
    Co-authored-by: karthikka4820 <[email protected]>
    Co-authored-by: LexieXie <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * suppress bodyTopLevelProperties
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * add suppression for required properties
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Downmerging change from Azure:main (Azure#16654)
    
    Co-authored-by: Avinash Akka <[email protected]>
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * fix CI failures, and run prettier on added examples
    
    * for credscan. change password example
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * make new api call long-running-operation
    
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * fix CI failures, and run prettier on added examples
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * for credscan. change password example
    
    * make new api call long-running-operation
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * update Repair action to enum and update readme
    
    * rebase to main since 2021-08-01 merged. update readme
    
    * update x-ms-enum name for RepairType
    
    * add default response to operations
    
    * update
    
    * put back 'required' tag for Resource.Location property
    and use a new object for VM_LIST return object
    
    * fix json format
    
    * update examples
    
    * run prettier on updated examples
    
    * update example for credScan
    
    * add VirtualMachineResource for toplevel property suppression.
    
    * lint diff errors
    
    * lint diff fix update
    
    * remove change for VMextensions.location bug
    
    * return readme file and examples before vm.vmextension.location change
    
    Co-authored-by: sukodava <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: xielexie <[email protected]>
    Co-authored-by: Mike Richmond <[email protected]>
    Co-authored-by: Avinash <[email protected]>
    Co-authored-by: Avinash Akka <[email protected]>
    Co-authored-by: ms-saypaul <[email protected]>
    Co-authored-by: Raktima Das <[email protected]>
    Co-authored-by: kamusta-msft <[email protected]>
    Co-authored-by: frank-pang-msft <[email protected]>
    Co-authored-by: Chase VanBuskirk <[email protected]>
    Co-authored-by: Chase Van Buskirk <[email protected]>
    Co-authored-by: vbhasker-msft <[email protected]>
    Co-authored-by: avjai <[email protected]>
    Co-authored-by: kangsun-ctrl <[email protected]>
    Co-authored-by: karthikka4820 <[email protected]>
    Co-authored-by: LexieXie <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-FixRequiredOnFailure Compute DoNotMerge <valid label in PR review process> use to hold merge after approval
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants