Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repair action to automatic repairs api #16535

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add repair action to automatic repairs api #16535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion specification/compute/resource-manager/Microsoft.Compute/stable/2021-11-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11281,7 +11281,11 @@
},
"gracePeriod": {
"type": "string",
"description": "The amount of time for which automatic repairs are suspended due to a state change on VM. The grace time starts after the state change has completed. This helps avoid premature or accidental repairs. The time duration should be specified in ISO 8601 format. The minimum allowed grace period is 30 minutes (PT30M), which is also the default value. The maximum allowed grace period is 90 minutes (PT90M)."
"description": "The amount of time for which automatic repairs are suspended due to a state change on VM. The grace time starts after the state change has completed. This helps avoid premature or accidental repairs. The time duration should be specified in ISO 8601 format. The minimum allowed grace period is 10 minutes (PT10M), which is also the default value. The maximum allowed grace period is 90 minutes (PT90M)."
},
"repairAction": {
"type": "string",
"description": "Type of repair action (replace, restart, reimage) that will be used for repairing unhealthy virtual machines in the scale set. Default value is replace."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per @pilor (ARM reviewer):
this should be a string enum since it has constrained values according to the description

}
},
"description": "Specifies the configuration parameters for automatic repairs on the virtual machine scale set."
Expand Down
6 changes: 3 additions & 3 deletions ...osoft.Compute/stable/2021-11-01/examples/compute/CreateAScaleSetWithAutomaticRepairs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
},
"automaticRepairsPolicy": {
"enabled": true,
"gracePeriod": "PT30M"
"gracePeriod": "PT10M"
grizzlytheodore marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Expand Down Expand Up @@ -136,7 +136,7 @@
},
"automaticRepairsPolicy": {
"enabled": true,
"gracePeriod": "PT30M"
"gracePeriod": "PT10M"
},
"provisioningState": "Creating"
},
Expand Down Expand Up @@ -214,7 +214,7 @@
},
"automaticRepairsPolicy": {
"enabled": true,
"gracePeriod": "PT30M"
"gracePeriod": "PT10M"
},
"provisioningState": "Creating"
},
Expand Down