-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Notification Hubs Revert Namespace List Keys Change #16221
Conversation
Hi, @mpodwysocki Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.OperationalInsights/operations' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/tables' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Tables.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/tables/{tableName}' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Tables.json#L82:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.OperationalInsights/workspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L76:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L118:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.OperationalInsights/deletedWorkspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L319:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/deletedWorkspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L358:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Schema' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'SearchResults' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'RestoredLogs' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ResultStatistics' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'TableProperties' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Table' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceSku' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceCapping' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceFeatures' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspacePatch' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PublicNetworkAccessType' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'TableNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2021-06 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @mpodwysocki, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
Hi @mpodwysocki, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@mpodwysocki , can you paste the previous PR which you revert? |
@raych1 The commit that contained the changes is here Updating swagger for Notification Hubs to add examples which added the regression for the list keys which has been fixed in this PR |
The previous PR is merged in 2018. If that is the change you want to revert, then this PR needs to go through breaking change review. Please follow the action in above comment. |
Hi, @mpodwysocki. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @mpodwysocki. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
/azp run |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.