Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.ExtendedLocations listoperations example #16070

Merged

Conversation

aditimalladi
Copy link
Contributor

@aditimalladi aditimalladi commented Sep 16, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify : Updating the ListOperations Example only. No change in Swagger
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @aditimalladi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 16, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 16, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - extendedlocation/mgmt/2021-08-15/extendedlocation - v57.3.0
    ️✔️azure-sdk-for-go - preview/extendedlocation/mgmt/2021-03-15-preview/extendedlocation - v57.3.0
    azure-sdk-for-python-track2 - track2_azure-mgmt-extendedlocation - 1.0.0b2
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c6c9e02. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-extendedlocation [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model CustomLocation has a new parameter identity
      info	[Changelog]   - Model PatchableCustomLocations has a new parameter identity
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation CustomLocationsOperations.update has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c6c9e02. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-22 02:19:56 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-extendedlocation"
      cmderr	[generate.py] 2021-09-22 02:19:56 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-09-22 02:19:56 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/extendedlocation/azure-resourcemanager-extendedlocation --java.namespace=com.azure.resourcemanager.extendedlocation   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/extendedlocation/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-22 02:20:33 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-09-22 02:20:33 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-22 02:20:33 INFO [POM][Skip] pom already has module azure-resourcemanager-extendedlocation
      cmderr	[generate.py] 2021-09-22 02:20:33 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-22 02:20:33 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-22 02:20:33 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-extendedlocation [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-22 02:21:52 DEBUG Got artifact_id: azure-resourcemanager-extendedlocation
      cmderr	[Inst] 2021-09-22 02:21:52 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-22 02:21:52 DEBUG Got artifact: azure-resourcemanager-extendedlocation-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-22 02:21:52 DEBUG Match jar package: azure-resourcemanager-extendedlocation-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-22 02:21:52 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16070/azure-sdk-for-java/azure-resourcemanager-extendedlocation/azure-resourcemanager-extendedlocation-1.0.0-beta.1.jar\" -o azure-resourcemanager-extendedlocation-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-extendedlocation -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-extendedlocation-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c6c9e02. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️extendedlocation/mgmt/2021-08-15/extendedlocation [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/extendedlocation/mgmt/2021-03-15-preview/extendedlocation [View full logs
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c6c9e02. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/extendedlocation/resource-manager/readme.md
    • ️✔️@azure/arm-extendedlocation [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/customLocations.js → ./dist/arm-extendedlocation.js...
      cmderr	[npmPack] created ./dist/arm-extendedlocation.js in 237ms
    Posted by Swagger Pipeline | How to fix these errors?

    @aditimalladi aditimalladi changed the title Amalladi/update listoperations example Microsoft.ExtendedLocations listoperations example Sep 16, 2021
    @ruowan ruowan self-assigned this Sep 18, 2021
    @ruowan
    Copy link
    Member

    ruowan commented Sep 18, 2021

    LGTM, If ready, pls ping me to merge

    @aditimalladi
    Copy link
    Contributor Author

    @ruowan Ready to merge this in! Thank you

    @ruowan ruowan merged commit c6c9e02 into Azure:main Sep 22, 2021
    Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
    * Updating list operations example
    
    * Revert "Updating list operations example"
    
    This reverts commit 65e9f1a.
    
    * Update the ListOperations example
    
    * Prettier format fix
    
    Co-authored-by: Aditi <[email protected]>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * Updating list operations example
    
    * Revert "Updating list operations example"
    
    This reverts commit 65e9f1a.
    
    * Update the ListOperations example
    
    * Prettier format fix
    
    Co-authored-by: Aditi <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants