Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 202 Accepted for deletion call #15874

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

sureleo
Copy link
Contributor

@sureleo sureleo commented Aug 31, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: We are leveraging K8Bridge and RPaas to handle resource deletion. RPaas and K8bridge are returning 202 all along but we did not define this response in the swagger. RPaas has acknowledged this bug in the response validation.
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sureleo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 31, 2021

    Swagger Validation Report

    ️❌BreakingChange: 14 Errors, 0 Warnings failed [Detail]
    Rule Message
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L276:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L572:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L868:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1116:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L276:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L572:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L820:11
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L247:7
    Old: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L247:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L543:7
    Old: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L539:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L839:7
    Old: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L831:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1088:7
    Old: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1076:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L247:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L247:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L543:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L539:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L792:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L784:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L733
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L796
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L844
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L888
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1029
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1092
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1140
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1184
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'DataControllers_PutDataController' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L733
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'DataControllers_PutDataController' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1029
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'DataControllers_PatchDataController' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L888
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'DataControllers_PatchDataController' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1184
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1837
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: name
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L975
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: name
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1271
    ⚠️ R3017 - GuidUsage Guid used in model definition 'OnPremiseProperty' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1437
    ⚠️ R3017 - GuidUsage Guid used in model definition 'LogAnalyticsWorkspaceConfig' for property 'workspaceId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1936
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UploadServicePrincipal' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1956
    ⚠️ R3017 - GuidUsage Guid used in model definition 'OnPremiseProperty' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1748
    ⚠️ R3017 - GuidUsage Guid used in model definition 'LogAnalyticsWorkspaceConfig' for property 'workspaceId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L2208
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UploadServicePrincipal' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L2228
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L948
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L995
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1118
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1244
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1291
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1437
    ⚠️ R3027 - TrackedResourceListByResourceGroup The tracked resource, 'DataControllerResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1249
    ⚠️ R3027 - TrackedResourceListByResourceGroup The tracked resource, 'DataControllerResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1568
    ⚠️ R3028 - TrackedResourceListBySubscription The tracked resource, 'DataControllerResource', must have a list by subscriptions operation.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1249
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
    "tag":"package-2021-08-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
    "tag":"package-2021-08-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
    "tag":"package-2021-08-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
    "tag":"package-preview-2021-07-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
    "tag":"package-preview-2021-07-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 31, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azurearcdata - first release
    ️✔️azure-sdk-for-go - azurearcdata/mgmt/2021-08-01/azurearcdata - v57.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e23a590. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-15 05:40:32 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-azurearcdata;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-15 05:40:32 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-15 05:40:32 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/azurearcdata/azure-resourcemanager-azurearcdata --java.namespace=com.azure.resourcemanager.azurearcdata   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/azurearcdata/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-azurearcdata
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [POM][Skip] pom already has module azure-resourcemanager-azurearcdata
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [POM][Skip] pom already has module sdk/azurearcdata
      cmderr	[generate.py] 2021-09-15 05:40:59 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-azurearcdata [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG Got artifact_id: azure-resourcemanager-azurearcdata
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG Got artifact: azure-resourcemanager-azurearcdata-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG Got artifact: azure-resourcemanager-azurearcdata-1.0.0-beta.2-javadoc.jar
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG Got artifact: azure-resourcemanager-azurearcdata-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG Match jar package: azure-resourcemanager-azurearcdata-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-15 05:42:47 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15874/azure-sdk-for-java/azure-resourcemanager-azurearcdata/azure-resourcemanager-azurearcdata-1.0.0-beta.2.jar\" -o azure-resourcemanager-azurearcdata-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-azurearcdata -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-azurearcdata-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e23a590. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️azurearcdata/mgmt/2021-08-01/azurearcdata [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e23a590. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/azurearcdata/resource-manager/readme.md
    • ️✔️@azure/arm-azurearcdata [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/azureArcDataManagementClient.js → ./dist/arm-azurearcdata.js...
      cmderr	[npmPack] created ./dist/arm-azurearcdata.js in 341ms
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e23a590. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/azurearcdata/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.AzureArcData [View full logs]  [Release SDK Changes]
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e23a590. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️azurearcdata [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @sureleo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @sureleo
    Copy link
    Contributor Author

    sureleo commented Sep 1, 2021

    https://msazure.visualstudio.com/One/_workitems/edit/10744495

    Breaking change review intake created.

    @sureleo
    Copy link
    Contributor Author

    sureleo commented Sep 1, 2021

    Also adding email from @sanjaiganesh

    RpaaS is missing swagger validation in DELETE path. We need to add it, in a non-breaking way. Send out announcement to give time to partners and possibly enforcing in canary first.
    Filed Product Backlog Item 10741831: Add swagger validation for DELETEs

    Thanks
    Sanjai

    @lirenhe
    Copy link
    Member

    lirenhe commented Sep 1, 2021

    @sureleo, as your PR contains breaking change, please follow http://aka.ms/bcforapi to get it reviewed.

    @sureleo
    Copy link
    Contributor Author

    sureleo commented Sep 1, 2021

    @sureleo, as your PR contains breaking change, please follow http://aka.ms/bcforapi to get it reviewed.

    Thanks. I have already created breaking change intake.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 13, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Reviewed-FeedbackProvided
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants