Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NetAppFiles] Add missing features, quotaLimits and Rotterdam networkFeatures to API version 2021-06-02 #15850

Merged
merged 9 commits into from
Sep 14, 2021
Merged

[NetAppFiles] Add missing features, quotaLimits and Rotterdam networkFeatures to API version 2021-06-02 #15850

merged 9 commits into from
Sep 14, 2021

Conversation

audunn
Copy link
Member

@audunn audunn commented Aug 30, 2021 •
edited
Loading

This adds features that where missing from the original 2021-06-01 PR API Spec update but are included in the service. This was found in our internal review. API spec should be updated otherwise we will have s360 validation issues.
This PR adds new quotaLimits operation and networkFeatures, networkSiblingSetId, storageToNetworkProximity properties to volumeProperties to support Rotterdam networking.

Note .net SDK, Azure CLI and Powershell modules have not been released yet for 2021-06-01.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 30, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 11 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L210:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L250:5
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'networkSiblingSetId' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3854:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3691:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'storageToNetworkProximity' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3854:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3691:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'enableRegionalMdmAccount' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2930:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2844:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'isInternal' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2930:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2844:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'logSpecifications' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2912:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2832:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'networkFeatures' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3854:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3691:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'networkFeatures' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3854:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3691:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'networkSiblingSetId' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3854:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3691:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'storageToNetworkProximity' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3854:7
    Old: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3691:7
    ️⚠️LintDiff: 6 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2973
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInternal
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3008
    ⚠️ R4021 - DescriptionAndTitleMissing 'logSpecifications' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2920
    ⚠️ R4021 - DescriptionAndTitleMissing 'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3018
    ⚠️ R4021 - DescriptionAndTitleMissing 'displayName' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3021
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: QuotaLimits
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L283


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Pools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L610
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Volumes_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L861
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Snapshots_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1565
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'SnapshotPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1853
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'AccountBackups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2171
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Backups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2311
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2591
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Pools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L651
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Volumes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L905
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Snapshots_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1612
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'SnapshotPolicies_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1876
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Backups_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2358
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupPolicies_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2632
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Pools_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L711
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Volumes_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L971
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Snapshots_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1675
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'SnapshotPolicies_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1917
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Backups_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2427
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupPolicies_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2695
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L484
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L792
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L1061
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L40
    ❌ R4037 - MissingTypeObject The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2849
    ❌ R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2869
    ❌ R4037 - MissingTypeObject The schema 'OperationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2901
    ❌ R4037 - MissingTypeObject The schema 'ServiceSpecification' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2910
    ❌ R4037 - MissingTypeObject The schema 'MetricSpecification' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L2928
    ❌ R4037 - MissingTypeObject The schema 'Dimension' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L3026
    ❌ R4037 - MissingTypeObject The schema 'dataProtection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.NetApp/stable/2021-06-01/netapp.json#L4028
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 30, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-netapp - 5.0.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2021-06-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2021-04-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2021-02-01/netapp - v57.2.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-12-01/netapp - v57.2.0
    +	Const `Auto` has been removed
+	Const `Manual` type has been changed from `QosType` to `BackupType`
+	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ❌azure-sdk-for-go - netapp/mgmt/2020-11-01/netapp - v57.2.0
    +	Const `Auto` has been removed
+	Const `Manual` type has been changed from `QosType` to `BackupType`
+	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ❌azure-sdk-for-go - netapp/mgmt/2020-09-01/netapp - v57.2.0
    +	Const `Auto` has been removed
+	Const `Manual` type has been changed from `QosType` to `BackupType`
+	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ❌azure-sdk-for-go - netapp/mgmt/2020-08-01/netapp - v57.2.0
    +	Const `Auto` has been removed
+	Const `Manual` type has been changed from `QosType` to `BackupType`
+	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ❌azure-sdk-for-go - netapp/mgmt/2020-07-01/netapp - v57.2.0
    +	Const `Auto` has been removed
+	Const `Manual` type has been changed from `QosType` to `BackupType`
+	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ❌azure-sdk-for-go - netapp/mgmt/2020-06-01/netapp - v57.2.0
    +	Const `Auto` has been removed
+	Const `Manual` type has been changed from `QosType` to `BackupType`
+	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ❌azure-sdk-for-go - netapp/mgmt/2020-05-01/netapp - v57.2.0
    +	Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
    ️✔️azure-sdk-for-go - netapp/mgmt/2020-03-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2020-02-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-11-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-10-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-08-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-07-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-06-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-05-01/netapp - v57.2.0
    ️✔️azure-sdk-for-go - preview/netapp/mgmt/2021-04-01-preview/netapp - v57.2.0
    ️✔️azure-sdk-for-go - preview/netapp/mgmt/2017-08-15/netapp - v57.2.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6b95b0f. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ServiceSpecification has a new parameter log_specifications
info	[Changelog]   - Model MetricSpecification has a new parameter enable_regional_mdm_account
info	[Changelog]   - Model MetricSpecification has a new parameter is_internal
info	[Changelog]   - Model Volume has a new parameter storage_to_network_proximity
info	[Changelog]   - Model Volume has a new parameter network_features
info	[Changelog]   - Model Volume has a new parameter network_sibling_set_id
info	[Changelog]   - Added operation group NetAppResourceQuotaLimitsOperations
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6b95b0f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.NetApp [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6b95b0f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
    • ️✔️@azure/arm-netapp [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
cmderr	[npmPack] created ./dist/arm-netapp.js in 605ms
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6b95b0f. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️netapp/mgmt/2021-06-01/netapp [View full logs]  [Release SDK Changes]
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `StorageToNetworkProximity` in struct `VolumeProperties`
info	[Changelog] - New field `NetworkSiblingSetID` in struct `VolumeProperties`
info	[Changelog] - New field `LogSpecifications` in struct `ServiceSpecification`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 45 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2021-04-01/netapp [View full logs] 
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `EncryptionType` in struct `PoolProperties`
info	[Changelog] - New field `SystemData` in struct `BackupPolicy`
info	[Changelog] - New field `Etag` in struct `BackupPolicy`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 19 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2021-02-01/netapp [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-12-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `Scheduled`
info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-11-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `Scheduled`
info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-09-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-08-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-07-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New const `Scheduled`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-06-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-05-01/netapp [View full logs]  Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `Scheduled`
info	[Changelog] - New const `Manual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 3 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-03-01/netapp [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-02-01/netapp [View full logs] 
      Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-11-01/netapp [View full logs] 
      Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-10-01/netapp [View full logs] 
      Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-08-01/netapp [View full logs] 
      Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-07-01/netapp [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2019-06-01/netapp [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2019-05-01/netapp [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/netapp/mgmt/2021-04-01-preview/netapp [View full logs]  
      info	[Changelog] This is a new package
    • ️✔️preview/netapp/mgmt/2017-08-15/netapp [View full logs]  
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6b95b0f. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-09-14 01:59:21 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-netapp;1.0.0-beta.5;1.0.0-beta.6"
cmderr	[generate.py] 2021-09-14 01:59:21 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.6"
cmderr	[generate.py] 2021-09-14 01:59:21 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/netapp/azure-resourcemanager-netapp --java.namespace=com.azure.resourcemanager.netapp   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-netapp
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [POM][Skip] pom already has module azure-resourcemanager-netapp
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [POM][Skip] pom already has module sdk/netapp
cmderr	[generate.py] 2021-09-14 01:59:52 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-netapp [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-09-14 02:02:41 DEBUG Got artifact_id: azure-resourcemanager-netapp
cmderr	[Inst] 2021-09-14 02:02:41 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-09-14 02:02:41 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.6-javadoc.jar
cmderr	[Inst] 2021-09-14 02:02:41 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.6-sources.jar
cmderr	[Inst] 2021-09-14 02:02:41 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.6.jar
cmderr	[Inst] 2021-09-14 02:02:41 DEBUG Match jar package: azure-resourcemanager-netapp-1.0.0-beta.6.jar
cmderr	[Inst] 2021-09-14 02:02:41 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15850/azure-sdk-for-java/azure-resourcemanager-netapp/azure-resourcemanager-netapp-1.0.0-beta.6.jar\" -o azure-resourcemanager-netapp-1.0.0-beta.6.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-netapp -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-netapp-1.0.0-beta.6.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6b95b0f. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2535) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 4)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 5)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 6)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 7)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 8)
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2535) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 9)
    • ️✔️netapp [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 30, 2021
    This was referenced Aug 30, 2021
    Closed
    Closed
    This was referenced Aug 30, 2021
    Closed
    Closed
    Closed
    @audunn audunn changed the title [NetAppFiles] Add missing features, quotaLimits and Rotterdam networkFeatures [NetAppFiles] Add missing features, quotaLimits and Rotterdam networkFeatures to API version 2021-06-02 Aug 30, 2021
    @jorgecotillo
    Copy link
    Contributor

    Your API is flagged as a breaking change, you'll need to get an approval from the breaking change board prior an API review.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 30, 2021
    @audunn
    Copy link
    Member Author

    audunn commented Aug 31, 2021

    @jorgecotillo Breaking change approved, are we clear to proceed ?

    jorgecotillo
    jorgecotillo reviewed Aug 31, 2021
    View reviewed changes
    specification/netapp/resource-manager/Microsoft.NetApp/stable/2021-06-01/netapp.json
    @@ -207,6 +207,43 @@
    }
    }
    },
    "/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/quotaLimits": {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    quotaLimits

    Per API contract this API must return a collection GET and expose another API to return a single item (singleton), see here: https://github.com/Azure/azure-resource-manager-rpc/blob/770933ab2af1ece1eba2835f7a03bbfde47bb793/v1.0/common-api-contracts.md#singleton-resources

    Copy link
    Member Author

    @audunn audunn Aug 31, 2021 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks like this will require a service side change. As that would likely delay the release of SDK's, Azure CLI, Powershell etc. is is possible to add collection GET in the new api version ? Or perhaps change this API to return collection as noted and add the single GET in next api-version as that would include more work presumably (additional manifest change).

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @jorgecotillo We have updated the spec with proposed implementation to address this. Can you take another look?

    @jorgecotillo jorgecotillo added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 31, 2021
    @openapi-workflow-bot
    Copy link

    Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @audunn
    Copy link
    Member Author

    audunn commented Sep 8, 2021

    Thought, would this QuotaLimits be better suited modeled as a POST that returns a list?

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 8, 2021
    Draft
    majastrz
    majastrz reviewed Sep 8, 2021
    View reviewed changes
    specification/netapp/resource-manager/Microsoft.NetApp/stable/2021-06-01/netapp.json
    }
    }
    },
    "SubscriptionQuotaItem": {
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    SubscriptionQuotaItem

    Why isn't this a standard ARM resource payload. You should have id, name, type properties and a properties property at a minimum.

    Copy link
    Member Author

    @audunn audunn Sep 9, 2021 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    That is why I am wondering as this is not strictly a "resource" if a POST to list the quota values would be a better fit here?

    "/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/quotaLimits": {
   "post": {
      "tags": [
        "NetApp Resource"
      ],
      "summary": "Get quota limits",
      "description": "Get the default and current limits for quotas",
      "operationId": "NetAppResourceQuotaLimits_List",
      "parameters": [
        {
          "$ref": "#/parameters/SubscriptionId"
        },
        {
          "$ref": "#/parameters/location"
        },
        {
          "$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
        }
      ],
      "responses": {
        "200": {
          "description": "OK",
          "schema": {
            "$ref": "#/definitions/SubscriptionQuotaItemList"
          }
        },
        "default": {
          "description": "Error response describing why the operation failed."
        }
      },
      "x-ms-examples": {
        "QuotaLimits": {
          "$ref": "examples/QuotaLimits_List.json"
        }
      }
    }
  },

    If that does not fit this scenario I will make those changes you suggest.

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi, @majastrz can you take another look?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The problem with POST is that identities with Reader role aren't able to invoke them, which causes some frustration. It's also harder to discover POST actions like that. My suggestion would be to stick with GET and just adjust the payloads to match ARM resources. It should be a pretty minor change.

    Copy link
    Member Author

    @audunn audunn Sep 10, 2021 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @majastrz , @jorgecotillo yes I was thinking it used along with authorizationActionMappings.
    Note we have updated GET in the spec with regards to your comment.

    @audunn audunn added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Sep 9, 2021
    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2021
    majastrz
    majastrz approved these changes Sep 10, 2021
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @audunn
    Copy link
    Member Author

    audunn commented Sep 10, 2021

    @msyyc ARMSignedOff can we move this along?

    @audunn
    Copy link
    Member Author

    audunn commented Sep 13, 2021

    @msyyc can we move this along?

    @msyyc msyyc merged commit 6b95b0f into Azure:main Sep 14, 2021
    This was referenced Sep 14, 2021
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 14, 2021
    [ReleasePR netapp] [NetAppFiles] Add missing features, quotaLimits an…
    a4c9b8f 
    …d Rotterdam networkFeatures to API version 2021-06-02 (#1897)

Create to sync Azure/azure-rest-api-specs#15850
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/netapp?expand=1)
    @audunn audunn mentioned this pull request Sep 20, 2021
    Merged
    11 tasks
    @audunn audunn mentioned this pull request Oct 4, 2021
    Merged
    25 tasks
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @audunn @LeiWang3
    [NetAppFiles] Add missing features, quotaLimits and Rotterdam network…
    3674411 
    …Features to API version 2021-06-02 (Azure#15850)

* Add missing features, quotaLimist and Rotterdam networkFeatures

* Update quotaLimits get and add get list

* Update description for volume type

* S360 Add missing serviceSpecification and metricsSpecification properties

* Remove quotalimit response no longer used

* pagable

* Update to use common type proxy resource

* pretty

* systemdata

Co-authored-by: Audunn Baldvinsson <[email protected]>
    @audunn audunn mentioned this pull request May 18, 2022
    Merged
    25 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jorgecotillo jorgecotillo jorgecotillo left review comments

    @majastrz majastrz majastrz approved these changes

    Assignees

    @msyyc msyyc

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @audunn @jorgecotillo @majastrz @JeffreyRichter @msyyc