[Synapse] Modify kusto pool related operation id to make it clearer #15816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @wonner Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The operation id has been changed from 'AttachedDatabaseConfigurations_ListByKustoPool' to 'KustoPoolAttachedDatabaseConfigurations_ListByKustoPool'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L875:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L875:7 |
|
The operation id has been changed from 'AttachedDatabaseConfigurations_Get' to 'KustoPoolAttachedDatabaseConfigurations_Get'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L923:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L923:7 |
|
The operation id has been changed from 'AttachedDatabaseConfigurations_CreateOrUpdate' to 'KustoPoolAttachedDatabaseConfigurations_CreateOrUpdate'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L969:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L969:7 |
|
The operation id has been changed from 'AttachedDatabaseConfigurations_Delete' to 'KustoPoolAttachedDatabaseConfigurations_Delete'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1037:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1037:7 |
|
The operation id has been changed from 'Databases_ListByKustoPool' to 'KustoPoolDatabases_ListByKustoPool'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1089:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1089:7 |
|
The operation id has been changed from 'Databases_Get' to 'KustoPoolDatabases_Get'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1137:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1137:7 |
|
The operation id has been changed from 'Databases_CreateOrUpdate' to 'KustoPoolDatabases_CreateOrUpdate'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1183:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1183:7 |
|
The operation id has been changed from 'Databases_Update' to 'KustoPoolDatabases_Update'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1245:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1245:7 |
|
The operation id has been changed from 'Databases_Delete' to 'KustoPoolDatabases_Delete'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1307:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1307:7 |
|
The operation id has been changed from 'DataConnections_CheckNameAvailability' to 'KustoPoolDataConnections_CheckNameAvailability'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1359:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1359:7 |
|
The operation id has been changed from 'DataConnections_dataConnectionValidation' to 'KustoPoolDataConnections_dataConnectionValidation'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1416:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1416:7 |
|
The operation id has been changed from 'DataConnections_ListByDatabase' to 'KustoPoolDataConnections_ListByDatabase'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1480:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1480:7 |
|
The operation id has been changed from 'DataConnections_Get' to 'KustoPoolDataConnections_Get'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1531:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1531:7 |
|
The operation id has been changed from 'DataConnections_CreateOrUpdate' to 'KustoPoolDataConnections_CreateOrUpdate'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1580:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1580:7 |
|
The operation id has been changed from 'DataConnections_Update' to 'KustoPoolDataConnections_Update'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1645:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1645:7 |
|
The operation id has been changed from 'DataConnections_Delete' to 'KustoPoolDataConnections_Delete'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1710:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1710:7 |
|
The operation id has been changed from 'DatabasePrincipalAssignments_CheckNameAvailability' to 'KustoPoolDatabasePrincipalAssignments_CheckNameAvailability'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2027:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2027:7 |
|
The operation id has been changed from 'DatabasePrincipalAssignments_List' to 'KustoPoolDatabasePrincipalAssignments_List'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2084:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2084:7 |
|
The operation id has been changed from 'DatabasePrincipalAssignments_Get' to 'KustoPoolDatabasePrincipalAssignments_Get'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2135:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2135:7 |
|
The operation id has been changed from 'DatabasePrincipalAssignments_CreateOrUpdate' to 'KustoPoolDatabasePrincipalAssignments_CreateOrUpdate'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2184:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2184:7 |
|
The operation id has been changed from 'DatabasePrincipalAssignments_Delete' to 'KustoPoolDatabasePrincipalAssignments_Delete'. This will impact generated code. New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2249:7 Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2249:7 |
️⚠️LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
| Rule | Message |
|---|---|
| Since operation 'KustoPoolDataConnections_dataConnectionValidation' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1420 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
Operations API must be implemented for '/providers/Microsoft.Synapse/operations'. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L17 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2998 |
|
| Based on the response model schema, operation 'KustoPools_ListByWorkspace' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L139 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'KustoPoolModel'. Consider using the plural form of 'KustoPool' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L62 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: kustoPoolsStop Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L467 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v1 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-kusto-pool-2021-06-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-kusto-pool-2021-06-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-kusto-pool-2021-06-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
ghost
added
the
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=250892&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.0.0️✔️azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v57.0.0️✔️azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v57.0.0️✔️azure-sdk-for-go - preview/synapse/mgmt/2021-06-01-preview/synapse - v57.0.0❌azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v57.0.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Synapse [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
️✔️@azure/arm-synapse [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js... cmderr [npmPack] created ./dist/arm-synapse.js in 1.1s
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-09-03 03:28:23 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.1;1.0.0-beta.2" cmderr [generate.py] 2021-09-03 03:28:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2" cmderr [generate.py] 2021-09-03 03:28:23 INFO autorest --version=3.4.5 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [generate.py] Error: $ref to original location 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#/components/schemas/SubResource' is not found in the new refs collection cmderr [generate.py] 2021-09-03 03:28:51 ERROR [GENERATE] Autorest fail cmderr [generate.py] 2021-09-03 03:30:28 ERROR [COMPILE] Maven build fail
️✔️azure-resourcemanager-synapse [View full logs] [Release SDK Changes]cmderr [Inst] 2021-09-03 03:30:31 DEBUG Got artifact_id: azure-resourcemanager-synapse cmderr [Inst] 2021-09-03 03:30:31 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-09-03 03:30:31 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2.jar cmderr [Inst] 2021-09-03 03:30:31 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.2.jar cmderr [Inst] 2021-09-03 03:30:31 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15816/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.2.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-synapse [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model SqlPool has a new parameter source_database_deletion_date info [Changelog] - Model ManagedIdentity has a new parameter user_assigned_identities info [Changelog] - Model SqlPoolPatchInfo has a new parameter source_database_deletion_date info [Changelog] - Model IntegrationRuntimeVNetProperties has a new parameter subnet_id info [Changelog] - Model IntegrationRuntimeDataFlowProperties has a new parameter cleanup info [Changelog] - Model DataLakeStorageAccountDetails has a new parameter resource_id info [Changelog] - Model DataLakeStorageAccountDetails has a new parameter create_managed_private_endpoint info [Changelog] - Model CustomerManagedKeyDetails has a new parameter kek_identity info [Changelog] - Model Workspace has a new parameter azure_ad_only_authentication info [Changelog] - Model Workspace has a new parameter settings info [Changelog] - Model Workspace has a new parameter csp_workspace_admin_properties info [Changelog] - Added operation IntegrationRuntimesOperations.list_outbound_network_dependencies_endpoints info [Changelog] - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get info [Changelog] - Added operation group SparkConfigurationsOperations info [Changelog] - Added operation group SparkConfigurationOperations info [Changelog] - Added operation group AzureADOnlyAuthenticationsOperations
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️synapse/mgmt/2021-03-01/synapse [View full logs] [Release SDK Changes]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU` info [Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA` info [Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsResponder(*http.Response) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)` info [Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpoints(context.Context, string, string, string) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)` info [Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsPreparer(context.Context, string, string, string) (*http.Request, error)` info [Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsSender(*http.Request) (*http.Response, error)` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse` info [Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 15 additive change(s). info [Changelog]
- Only show 30 items here, please refer to log for details.
️✔️synapse/mgmt/2020-12-01/synapse [View full logs]info [Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient` info [Changelog] - New function `LibraryListResponse.IsEmpty() bool` info [Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)` info [Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient` info [Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse` info [Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsResponder(*http.Response) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)` info [Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage` info [Changelog] - New function `*LibraryListResponseIterator.Next() error` info [Changelog] - New function `*LibraryListResponsePage.Next() error` info [Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse` info [Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)` info [Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource` info [Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error` info [Changelog] - New function `NewLibrariesClient(string) LibrariesClient` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails` info [Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse` info [Changelog] - New struct `LibrariesClient` info [Changelog] - New struct `LibraryClient` info [Changelog] - New struct `LibraryListResponse` info [Changelog] - New struct `LibraryListResponseIterator` info [Changelog] - New struct `LibraryListResponsePage` info [Changelog] - New struct `LibraryResource` info [Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 55 additive change(s). info [Changelog]
️✔️preview/synapse/mgmt/2021-06-01-preview/synapse [View full logs]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 1 additive change(s). info [Changelog]
- Only show 30 items here, please refer to log for details.
️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] Breaking Change Detectedinfo [Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New struct `RecommendedSensitivityLabelUpdate` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateList` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties` info [Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient` info [Changelog] - New struct `SQLPoolMaintenanceWindowsClient` info [Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New struct `SensitivityLabelUpdate` info [Changelog] - New struct `SensitivityLabelUpdateList` info [Changelog] - New struct `SensitivityLabelUpdateProperties` info [Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `ClientID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `ClientSecret` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties` info [Changelog] - New field `TableName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties` info [Changelog] - New field `Rank` in struct `SensitivityLabelProperties` info [Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties` info [Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime` info [Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties` info [Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties` info [Changelog] - New field `ManagedBy` in struct `SensitivityLabel` info [Changelog] info [Changelog] Total 1 breaking change(s), 122 additive change(s). info [Changelog]
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️synapse [View full logs] [Release Schema Changes]
|
Hi @wonner, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Aug 27, 2021
This was referenced Aug 27, 2021
amitelran
reviewed
Aug 30, 2021
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Outdated
Show resolved
Hide resolved
idear1203
approved these changes
Sep 2, 2021
JeffreyRichter
added
the
Approved-BreakingChange
ruowan
approved these changes
Sep 3, 2021
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.