-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Add data plane Datalake Storage swagger #15789
Conversation
* Adding Azure Storage Dataplane REST API Specs These are all Preview swagger specs and we do expect to make changes. - Add readme.md files to suppress --azure-validator rules - Fix trivial error about an x-ms-client-name mathing a name that won't change the code generation - We'll need to fix the semantic/avocado pipeline issues and get this properly reviewed before merging from the `storage-dataplane-preview` fork into `master`.
* Fixed blob swagger for CPK
* Add share permission body to storage files * Add produces to getPermission * Move response body from create to get
1. create of Page Blob is missing tier parameter. 2. For upload_pages_from_url of Page Blob, the generated code doesn’t extract header encryption-key-sha256 from raw response, which resulted in the response to client doesn’t have encryption-key-sha256 info. 3. For append_block_from_url of Append Blob, currently the generated code is not extracting the response header request-server-encrypted from raw response(server returned response) which resulted in client doesn’t have request-server-encrypted info. 4. get_permission of Storage File has file_permission_key parameter which should be required instead of optional
* Additional DataLake swagger updates
* Updated ContentMD5 parameter in DataLake swagger * separated contentMD5 from transactionalContentMD5
Hi, @tasherif-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Hi @tasherif-msft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Add a swagger spec for the 2020-06-12 version of Datalake Storage.