Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add data plane Datalake Storage swagger #15789

Merged
merged 169 commits into from
Sep 7, 2021
Merged

Conversation

tasherif-msft
Copy link
Contributor

Add a swagger spec for the 2020-06-12 version of Datalake Storage.

tg-msft and others added 30 commits August 26, 2019 15:14
* Adding Azure Storage Dataplane REST API Specs

These are all Preview swagger specs and we do expect to make changes.

- Add readme.md files to suppress --azure-validator rules
- Fix trivial error about an x-ms-client-name mathing a name that won't change the
code generation
- We'll need to fix the semantic/avocado pipeline issues and get this properly reviewed before merging from the `storage-dataplane-preview` fork into `master`.
* Fixed blob swagger for CPK
* Add share permission body to storage files

* Add produces to getPermission

* Move response body from create to get
1.	create of Page Blob is missing tier parameter.
2.	For upload_pages_from_url of Page Blob, the generated code doesn’t extract header encryption-key-sha256 from raw response, which resulted in the response to client doesn’t have encryption-key-sha256 info.
3.	For append_block_from_url of Append Blob, currently the generated code is not extracting the response header request-server-encrypted from raw response(server returned response) which resulted in client doesn’t have request-server-encrypted info.
4.	get_permission of Storage File has file_permission_key parameter which should be required instead of optional
* Additional DataLake swagger updates
* Updated ContentMD5 parameter in DataLake swagger

* separated contentMD5 from transactionalContentMD5
@openapi-workflow-bot
Copy link

Hi, @tasherif-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌LintDiff: 0 Errors, 0 Warnings failed [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    AutoRest exception "readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"default",
    "details":"swagger-document-override/md-override-loader - FAILED"
    AutoRest exception "readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"default",
    "details":"Error: Could not read 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/storage/data-plane/Microsoft.StorageDataLake/$%28this-folder%29/stable/2019-10-31/DataLakeStorage.json'."
    AutoRest exception "readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"default",
    "details":"swagger-document/loader - FAILED"
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 89 Errors, 169 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/plain' as a request body format.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L764:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L897:9
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ErrorResponse' removed or renamed?
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L151:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DataLakeStorageError' removed or renamed?
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L2992:3
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L69:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Version' removed or renamed?
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L2376:3
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L40:3
    1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_List' to 'Service_ListFileSystems'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L36:7
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L172:7
    1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_Create' to 'FileSystem_Create'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L131:7
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L287:7
    1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_SetProperties' to 'FileSystem_SetProperties'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L193:7
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L339:7
    1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_GetProperties' to 'FileSystem_GetProperties'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L256:7
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L490:7
    1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_Delete' to 'FileSystem_Delete'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L318:7
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L537:7
    1010 - AddingRequiredParameter The required parameter 'mode' was added in the new version.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L770:9
    1010 - AddingRequiredParameter The required parameter 'body' was added in the new version.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L770:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'checkAccess' from the old version.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L1429:11
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L1717:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L47:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L264:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L85:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L187:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L138:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L618:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L147:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L298:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L156:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L306:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L385:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L392:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L618:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L215:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L350:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L224:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L358:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L267:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L501:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L276:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L509:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L360:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L568:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L360:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L575:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L360:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L618:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L340:15
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L557:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L613:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L849:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L613:9
    Old: Microsoft.StorageDataLake/stable/2019-10-31/DataLakeStorage.json#L856:11


    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/plain' as a request body format.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L764:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L887:9
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ErrorResponse' removed or renamed?
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L151:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DataLakeStorageError' removed or renamed?
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L2992:3
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L69:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Version' removed or renamed?
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L2376:3
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L40:3
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_List' to 'Service_ListFileSystems'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L36:7
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L172:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_Create' to 'FileSystem_Create'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L131:7
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L287:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_SetProperties' to 'FileSystem_SetProperties'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L193:7
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L339:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_GetProperties' to 'FileSystem_GetProperties'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L256:7
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L483:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Filesystem_Delete' to 'FileSystem_Delete'. This will impact generated code.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L318:7
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L530:7
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'mode' was added in the new version.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L770:9
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'body' was added in the new version.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L770:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L47:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L217:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L138:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L329:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L377:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L360:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L560:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L613:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L679:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L770:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L979:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L1001:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L1252:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L1179:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L1512:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L1428:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L1656:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L1597:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L1735:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L47:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L264:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L85:15
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L187:15
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L138:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L608:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L147:15
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L298:15
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L156:15
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L306:15
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L385:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L392:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L200:9
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L608:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageDataLake/preview/2020-06-12/DataLakeStorage.json#L215:15
    Old: Microsoft.StorageDataLake/preview/2018-06-17/DataLakeStorage.json#L350:15
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2019-10",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2019-10",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2020-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2020-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2019-10",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2018-11",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2018-11",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2018-06-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.StorageDataLake/readme.md",
    "tag":"package-2018-06-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @tasherif-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    Copy link
    Member

    @tg-msft tg-msft left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks great

    @tasherif-msft tasherif-msft reopened this Aug 31, 2021
    @tjprescott tjprescott removed their request for review September 3, 2021 16:47
    @tg-msft tg-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 3, 2021
    @anuchandy anuchandy merged commit 771d318 into main Sep 7, 2021
    @JackTn JackTn deleted the fileshare-spec branch June 16, 2022 00:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff CI-FixRequiredOnFailure
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.