-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synapse] - Remove readonly for uploadtimestamp #15765
[Synapse] - Remove readonly for uploadtimestamp #15765
Conversation
Hi, @idear1203 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1029 - ReadonlyPropertyChanged |
The read only property has changed from 'true' to 'false'. New: Microsoft.Synapse/preview/2019-06-01-preview/bigDataPool.json#L565:9 Old: Microsoft.Synapse/preview/2019-06-01-preview/bigDataPool.json#L565:9 |
1029 - ReadonlyPropertyChanged |
The read only property has changed from 'true' to 'false'. New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L567:9 Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L567:9 |
️⚠️
LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/firewallRule.json#L203 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L85 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/keys.json#L75 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/library.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateEndpointConnections.json#L46 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L75 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L175 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privatelinkhub.json#L86 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolMetadataSyncConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L520 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolGeoBackupPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L851 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolDataWarehouseUserActivities_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L921 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolReplicationLinks_GetByName' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1172 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolMaintenanceWindows_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1233 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolMaintenanceWindowOptions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1356 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolTransparentDataEncryptions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1414 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1619 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolSensitivityLabels_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L2290 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolConnectionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L2739 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolSecurityAlertPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3130 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolVulnerabilityAssessmentRuleBaselines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3449 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolVulnerabilityAssessments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3535 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'ExtendedSqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3747 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'DataMaskingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4007 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'DataMaskingRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4148 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolSchemas_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4323 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolTables_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4380 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity" |
|
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1325", properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:872" " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:876" " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1175", properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'CloudError' -> 'CloudErrorAutoGenerated'" |
|
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @idear1203, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.