[Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview #15507

betrigg · 2021-08-03T23:13:30Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…1 to version 2017-04-01-preview

openapi-workflow-bot · 2021-08-03T23:13:32Z

Hi, @betrigg Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-08-03T23:13:33Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-08-03T23:13:34Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 11 Errors, 15 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- azureactivedirectory/resource-manager/readme.md tag:package-preview-2017-04
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- azureactivedirectory/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.aadiam' doesn't match the namespace. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L40
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.aadiam' doesn't match the namespace. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L73
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.aadiam' doesn't match the namespace. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L106
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.aadiam' doesn't match the namespace. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L219
`❌` R4037 - MissingTypeObject	The schema 'ProxyOnlyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L254
`❌` R4037 - MissingTypeObject	The schema 'RetentionPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L275
`❌` R4037 - MissingTypeObject	The schema 'LogSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L294
`❌` R4037 - MissingTypeObject	The schema 'DiagnosticSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L322
`❌` R4037 - MissingTypeObject	The schema 'DiagnosticSettingsResourceCollection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L370
`❌` R4037 - MissingTypeObject	The schema 'DiagnosticSettingsCategory' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L484
`❌` R4037 - MissingTypeObject	The schema 'DiagnosticSettingsCategoryResourceCollection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L517
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L465
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L41
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'DiagnosticSettings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L74
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'DiagnosticSettingsCategory_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L220
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiagnosticSettingsModel'. Consider using the plural form of 'DiagnosticSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L78
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiagnosticSettingsModel'. Consider using the plural form of 'DiagnosticSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L111
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiagnosticSettingsModel'. Consider using the plural form of 'DiagnosticSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L145
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiagnosticSettingsModel'. Consider using the plural form of 'DiagnosticSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L188
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiagnosticSettingsCategoryModel'. Consider using the plural form of 'DiagnosticSettingsCategory' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L224
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L277
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L308
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L453
⚠️ R4006 - DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L7
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'DiagnosticSettingsCategoryResource' does not have get operation, please add it. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L501
⚠️ R4024 - PreviewVersionOverOneYear	The API version:2017-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L4

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L382
`❌` R4037 - MissingTypeObject	The schema 'ErrorDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json#L391

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2017-04-01-preview/azureactivedirectory.json compared with base:stable/2017-04-01/azureactivedirectory.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

azureactivedirectory/resource-manager/readme.md#package-preview-2017-04

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"azureactivedirectory/resource-manager/readme.md",
"tag":"package-preview-2017-04",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"azureactivedirectory/resource-manager/readme.md",
"tag":"package-preview-2017-04",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"azureactivedirectory/resource-manager/readme.md",
"tag":"package-preview-2017-04",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-08-03T23:13:34Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - aad/mgmt/2017-04-01/aad - v57.0.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azureactivedirectory - first release

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 60a7ec1. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/azureactivedirectory/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No package detected after generation

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 60a7ec1. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-azureactivedirectory [View full logs] [Release SDK Changes]
- azure-mgmt-azureactivedirectory-1.0.0b1.zip
- azure_mgmt_azureactivedirectory-1.0.0b1-py2.py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 60a7ec1. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-09-02 03:18:37 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-azureactivedirectory"
cmderr	[generate.py] 2021-09-02 03:18:37 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-09-02 03:18:37 INFO autorest --version=3.4.5 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/azureactivedirectory/azure-resourcemanager-azureactivedirectory --java.namespace=com.azure.resourcemanager.azureactivedirectory   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/azureactivedirectory/resource-manager/readme.md
cmderr	[generate.py] 2021-09-02 03:19:06 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-09-02 03:19:06 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-09-02 03:19:06 INFO [POM][Skip] pom already has module azure-resourcemanager-azureactivedirectory
cmderr	[generate.py] 2021-09-02 03:19:06 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-09-02 03:19:06 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-09-02 03:19:06 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-azureactivedirectory [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-09-02 03:20:17 DEBUG Got artifact_id: azure-resourcemanager-azureactivedirectory
cmderr	[Inst] 2021-09-02 03:20:17 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-09-02 03:20:17 DEBUG Got artifact: azure-resourcemanager-azureactivedirectory-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-09-02 03:20:17 DEBUG Got artifact: azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar
cmderr	[Inst] 2021-09-02 03:20:17 DEBUG Match jar package: azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar
cmderr	[Inst] 2021-09-02 03:20:17 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15507/azure-sdk-for-java/azure-resourcemanager-azureactivedirectory/azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar\" -o azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-azureactivedirectory -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 60a7ec1. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️aad/mgmt/2017-04-01/aad [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 60a7ec1. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/azureactivedirectory/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 60a7ec1. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2514) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 4)
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 5)
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 6)
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2514) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 7)

️✔️azureactivedirectory [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-03T23:19:56Z

Hi @betrigg, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-08-04T02:05:23Z

Hi, @betrigg your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

betrigg · 2021-08-04T02:07:25Z

Errors in Swagger LinktDiff and ModelValidation would be breaking changes since this is a preview version to an already created stable one (s360 is requiring us to do this one).

...ctory/resource-manager/Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json

pilor · 2021-08-17T18:29:13Z

The spec itself is questionable but since this is just a copy of 2017-04-01 which already exists I'm not going to block it

qwordy · 2021-09-01T02:27:50Z

@betrigg Is this PR ready to merge?

betrigg · 2021-09-01T18:03:34Z

@qwordy yes this is ready to merge.

…icrosoft.Aadiam to add version preview/2017-04-01-preview (#1878) Create to sync Azure/azure-rest-api-specs#15507 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/azureactivedirectory?expand=1)

betrigg added 3 commits August 3, 2021 14:42

Adds base for updating Microsoft.Aadiam from version stable/2017-04-0…

c484ad8

…1 to version 2017-04-01-preview

Updates readme

9b5bd8d

Updates API version in new specs and examples

8d5c6d5

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 3, 2021

betrigg marked this pull request as ready for review August 4, 2021 01:55

openapi-assignment-bot bot assigned qwordy Aug 4, 2021

openapi-workflow-bot bot added FixS360 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 4, 2021

betrigg removed the CI-FixRequiredOnFailure label Aug 4, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 4, 2021

chiragg4u reviewed Aug 4, 2021

View reviewed changes

...ctory/resource-manager/Microsoft.Aadiam/preview/2017-04-01-preview/azureactivedirectory.json Show resolved Hide resolved

betrigg requested a review from chiragg4u August 4, 2021 18:19

betrigg removed the CI-FixRequiredOnFailure label Aug 4, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 4, 2021

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 17, 2021

qwordy approved these changes Aug 18, 2021

View reviewed changes

Try to resolve ModelValidation errors

8326d25

openapi-sdkautomation bot mentioned this pull request Aug 23, 2021

[AutoPR azureactivedirectory] [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview AzureSDKAutomation/azure-resource-manager-schemas#4511

Closed

Another try for ModelValidation

a20ebdd

betrigg added 2 commits August 23, 2021 12:21

Fix model validation

d216f1c

Remove breaking change

d490496

jianyexi added the Approved-LintDiff label Aug 31, 2021

Try python fix

8af466c

betrigg requested review from 00Kai0, jsntcy, msyyc and RAY-316 as code owners August 31, 2021 02:06

Fix python job failure

cd6f01e

openapi-sdkautomation bot mentioned this pull request Aug 31, 2021

[AutoPR track2_azure-mgmt-azureactivedirectory] [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview AzureSDKAutomation/azure-sdk-for-python#7164

Closed

qwordy merged commit 60a7ec1 into Azure:main Sep 2, 2021

betrigg deleted the dev-azureactivedirectory-Microsoft.Aadiam-2017-04-01-preview-2 branch September 30, 2021 01:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview #15507

[Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview #15507

betrigg commented Aug 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Aug 3, 2021

openapi-workflow-bot bot commented Aug 3, 2021

openapi-pipeline-app bot commented Aug 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 3, 2021

openapi-workflow-bot bot commented Aug 4, 2021

betrigg commented Aug 4, 2021

pilor commented Aug 17, 2021

qwordy commented Sep 1, 2021

betrigg commented Sep 1, 2021

[Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview #15507

[Hub Generated] Review request for Microsoft.Aadiam to add version preview/2017-04-01-preview #15507

Conversation

betrigg commented Aug 3, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Aug 3, 2021

openapi-workflow-bot bot commented Aug 3, 2021

openapi-pipeline-app bot commented Aug 3, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 3, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 3, 2021

openapi-workflow-bot bot commented Aug 4, 2021

betrigg commented Aug 4, 2021

pilor commented Aug 17, 2021

qwordy commented Sep 1, 2021

betrigg commented Sep 1, 2021

betrigg commented Aug 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2021 •

edited

Loading