[Hub Generated] Review request for Microsoft.Media to add version stable/2021-06-01- Part 2 #15097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @giakas Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-06-01/Encoding.json#L2518:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-06-01/Encoding.json#L2585:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-06-01/Encoding.json#L2791:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-06-01/Encoding.json#L2874:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Media/stable/2021-06-01/Encoding.json#L3102:5 |
️⚠️LintDiff: 7 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
| Rule | Message |
|---|---|
| Per the Noun_Verb convention for Operation Ids, the noun 'Jobs' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L3106 |
|
| The child tracked resource, 'transforms' with immediate parent 'MediaService', must have a list by immediate parent operation. Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L1767 |
|
| The child tracked resource, 'jobs' with immediate parent 'Transform', must have a list by immediate parent operation. Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L2376 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: adaptiveBFrame Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L186 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sceneChangeDetection Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L329 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: adaptiveBFrame Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L1078 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sceneChangeDetection Location: Microsoft.Media/stable/2021-06-01/Encoding.json#L1187 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1209 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1303 |
|
The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1351 |
| Since operation 'Assets_GetEncryptionKey' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Media/stable/2021-06-01/AssetsAndAssetFilters.json#L836 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L290 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1112 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1165 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1209 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1259 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1303 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"mediaservices/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"mediaservices/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"mediaservices/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
This was referenced Jul 6, 2021
This was referenced Jul 6, 2021
johndeu
reviewed
Jul 6, 2021
specification/mediaservices/resource-manager/Microsoft.Media/stable/2021-06-01/Encoding.json
Outdated
Show resolved
Hide resolved
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @giakas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
giakas
changed the title
|
What is your base api-version? Your first commit / push must be your base api-version content as is so we can focus on the changes only, failing to do it implies in PR review delays. |
jorgecotillo
reviewed
Jul 8, 2021
...urce-manager/Microsoft.Media/stable/2021-06-01/examples/jobs-list-all-filter-by-created.json
Outdated
Show resolved
Hide resolved
jorgecotillo
added
ARMSignedOff
This was referenced Jul 13, 2021
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…ble/2021-06-01- Part 2 (Azure#15097) * Copy 2020-05-01 version of the encoding swagger. * Update encoder swagger to 2021-06-01 version. * fix 404 response on Encoding swagger * fixed a description and removed 404 reponses from examples. * update example files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.