[Hub Generated] Review request for Microsoft.DataMigration to add version stable/2021-06-30 #14898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…018-07-15-preview to version 2021-06-30
|
Hi, @temandr Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=226460&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-datamigration - 9.0.0️✔️azure-sdk-for-go - datamigration/mgmt/2018-04-19/datamigration - v55.3.0️✔️azure-sdk-for-go - preview/datamigration/mgmt/2018-07-15-preview/datamigration - v55.3.0️✔️azure-sdk-for-go - preview/datamigration/mgmt/2018-03-31-preview/datamigration - v55.3.0️✔️azure-sdk-for-go - preview/datamigration/mgmt/2017-11-15-preview/datamigration - v55.3.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datamigration/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.DataMigration [View full logs] [Preview SDK Changes]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-datamigration [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] - Model ApiError has a new parameter system_data info [Changelog] - Model ConnectToTargetAzureDbForMySqlTaskInput has a new parameter is_offline_migration info [Changelog] - Model ProjectTask has a new parameter system_data info [Changelog] - Model ProjectFile has a new parameter system_data info [Changelog] - Model ConnectToSourceMySqlTaskInput has a new parameter is_offline_migration info [Changelog] - Model Project has a new parameter system_data info [Changelog] - Model DataMigrationService has a new parameter system_data info [Changelog] - Model DataMigrationService has a new parameter virtual_nic_id info [Changelog] - Model MySqlConnectionInfo has a new parameter encrypt_connection
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-datamigration [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model ConnectToSourceMySqlTaskInput has a new parameter is_offline_migration info [Changelog] - Model ApiError has a new parameter system_data info [Changelog] - Model Project has a new parameter system_data info [Changelog] - Model ProjectTask has a new parameter system_data info [Changelog] - Model MySqlConnectionInfo has a new parameter encrypt_connection info [Changelog] - Model ProjectFile has a new parameter system_data info [Changelog] - Model ConnectToTargetAzureDbForMySqlTaskInput has a new parameter is_offline_migration info [Changelog] - Model DataMigrationService has a new parameter system_data info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Parameter result_type of model MigrateSchemaSqlServerSqlDbTaskOutputDatabaseLevel is now required info [Changelog] - Parameter result_type of model MigrateSchemaSqlServerSqlDbTaskOutputMigrationLevel is now required info [Changelog] - Parameter result_type of model MigrateSchemaSqlTaskOutputError is now required info [Changelog] - Parameter result_type of model MigrateSchemaSqlServerSqlDbTaskOutput is now required info [Changelog] - Parameter result_type of model MigrateSchemaSqlServerSqlDbTaskOutputError is now required
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️datamigration/mgmt/2018-04-19/datamigration [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/datamigration/mgmt/2018-07-15-preview/datamigration [View full logs]info [Changelog] No exported changes
️✔️preview/datamigration/mgmt/2018-03-31-preview/datamigration [View full logs]info [Changelog] No exported changes
️✔️preview/datamigration/mgmt/2017-11-15-preview/datamigration [View full logs]info [Changelog] No exported changes
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/datamigration/resource-manager/readme.md
️✔️@azure/arm-datamigration [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/dataMigrationServiceClient.js → ./dist/arm-datamigration.js... cmderr [npmPack] created ./dist/arm-datamigration.js in 821ms
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-06-22 06:55:13 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datamigration;1.0.0-beta.1;1.0.0-beta.2" cmderr [generate.py] 2021-06-22 06:55:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2" cmderr [generate.py] 2021-06-22 06:55:13 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datamigration/azure-resourcemanager-datamigration --java.namespace=com.azure.resourcemanager.datamigration --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/datamigration/resource-manager/readme.md cmderr [generate.py] 2021-06-22 06:55:56 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-datamigration cmderr [generate.py] 2021-06-22 06:55:56 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-06-22 06:55:56 INFO [POM][Skip] pom already has module azure-resourcemanager-datamigration cmderr [generate.py] 2021-06-22 06:55:56 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-06-22 06:55:56 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-06-22 06:55:56 INFO [POM][Skip] pom already has module sdk/datamigration cmderr [generate.py] 2021-06-22 06:55:56 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-datamigration [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-datamigration-1.0.0-beta.2.jar
- azure-resourcemanager-datamigration-1.0.0-beta.2-javadoc.jar
- azure-resourcemanager-datamigration-1.0.0-beta.2-sources.jar
cmderr [Inst] 2021-06-22 06:57:43 DEBUG Got artifact_id: azure-resourcemanager-datamigration cmderr [Inst] 2021-06-22 06:57:43 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-06-22 06:57:43 DEBUG Got artifact: azure-resourcemanager-datamigration-1.0.0-beta.2.jar cmderr [Inst] 2021-06-22 06:57:43 DEBUG Match jar package: azure-resourcemanager-datamigration-1.0.0-beta.2.jar cmderr [Inst] 2021-06-22 06:57:43 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14898/azure-sdk-for-java/azure-resourcemanager-datamigration/azure-resourcemanager-datamigration-1.0.0-beta.2.jar\" -o azure-resourcemanager-datamigration-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-datamigration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-datamigration-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 3d1b32f136742e28eb1f0bfb988514d86f350760. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] cmderr [initScript.sh] The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] cmderr [initScript.sh] This is a one-time fix-up, please be patient... cmderr [initScript.sh] warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️datamigration [View full logs] [Preview Schema Changes]
This was referenced Jun 20, 2021
This was referenced Jun 20, 2021
…solving model validation build errors
|
This change is ready for review, but is not ready to be checked in until the manifest is deployed. Looks like the model validation is failing due to the properties not being set to required even though they are. |
swjain23
reviewed
Jun 23, 2021
swjain23
reviewed
Jun 23, 2021
...on/resource-manager/Microsoft.DataMigration/stable/2021-06-30/examples/ServiceTasks_Get.json
Show resolved
Hide resolved
swjain23
approved these changes
Jun 25, 2021
hitenjava
reviewed
Jul 2, 2021
hitenjava
approved these changes
Jul 2, 2021
|
@jianyexi The manifest has been deployed, this change can now be checked in. |
|
@jianyexi Any updates? |
jianyexi
added
the
WaitForARMFeedback
mentat9
added
the
ARMChangesRequested
|
Please fill out the submission checklist including all sections. Also, since you are adding a new API version, you will need to create a new PR that follows this requirement: Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently. |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.