Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Storage Swaggers to Master #14877

Closed
wants to merge 190 commits into from
Closed

Migrate Storage Swaggers to Master #14877

wants to merge 190 commits into from

Conversation

tasherif-msft
Copy link
Contributor

@tasherif-msft tasherif-msft commented Jun 17, 2021

The purpose of this PR is to merge the most recent swaggers with the most recent service versions.
The packages are:

  • Azure Storage Blobs
  • Azure Storage Fileshares
  • Azure Storage Datalake
  • Azure Storage Queues

We have been working off of a branch called storage-dataplane-preview and we are now aiming to work off master.

tg-msft and others added 30 commits August 26, 2019 15:14
* Adding Azure Storage Dataplane REST API Specs

These are all Preview swagger specs and we do expect to make changes.

- Add readme.md files to suppress --azure-validator rules
- Fix trivial error about an x-ms-client-name mathing a name that won't change the
code generation
- We'll need to fix the semantic/avocado pipeline issues and get this properly reviewed before merging from the `storage-dataplane-preview` fork into `master`.
* Fixed blob swagger for CPK
* Add share permission body to storage files

* Add produces to getPermission

* Move response body from create to get
1.	create of Page Blob is missing tier parameter.
2.	For upload_pages_from_url of Page Blob, the generated code doesn’t extract header encryption-key-sha256 from raw response, which resulted in the response to client doesn’t have encryption-key-sha256 info.
3.	For append_block_from_url of Append Blob, currently the generated code is not extracting the response header request-server-encrypted from raw response(server returned response) which resulted in client doesn’t have request-server-encrypted info.
4.	get_permission of Storage File has file_permission_key parameter which should be required instead of optional
* Additional DataLake swagger updates
* Updated ContentMD5 parameter in DataLake swagger

* separated contentMD5 from transactionalContentMD5
@tasherif-msft tasherif-msft marked this pull request as draft June 28, 2021 19:59
@tasherif-msft tasherif-msft changed the base branch from storage-dataplane-preview to master June 28, 2021 20:01
@tasherif-msft tasherif-msft reopened this Jun 28, 2021
@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @tasherif-msft. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

2 similar comments
@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @tasherif-msft. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @tasherif-msft. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn JackTn deleted the swagger-work branch July 5, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.