Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ResourceGraph to add version preview/2021-06-01-preview #14765

Conversation

johnthcall
Copy link
Member

@johnthcall johnthcall commented Jun 10, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Latest improvements:


### Contribution checklist: - [ ] I have reviewed the [documentation](https://github.com/Azure/adx-documentation-pr/wiki/Overall-basic-flow) for the workflow. - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR. - [x] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps. ### ARM API Review Checklist - [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. - adding/removing APIs. - adding/removing properties. - adding/removing API-version. - adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-workflow-bot
Copy link

Hi, @johnthcall Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 10, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ResourceGraph/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L113
    R4037 - MissingTypeObject The schema 'QueryRequestOptions' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L191
    R4037 - MissingTypeObject The schema 'FacetRequestOptions' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L263
    R4037 - MissingTypeObject The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L545
    R4037 - MissingTypeObject The schema 'Operation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L557
    R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L564
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowPartialScopes
    Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L224
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 6 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L211:9
    Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L207:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managementGroupId' renamed or removed?
    New: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L154:7
    Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L154:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managementGroupId' renamed or removed?
    New: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourceshistory.json#L87:7
    Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourceshistory.json#L82:7
    1036 - ConstraintChanged The new version has a different 'maximum' value than the previous one.
    New: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourceshistory.json#L122:9
    Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourceshistory.json#L107:9
    1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourceshistory.json#L122:9
    Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourceshistory.json#L107:9
    1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourceshistory.json#L129:9
    Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourceshistory.json#L111:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"resourcegraph/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"resourcegraph/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"resourcegraph/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 10, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - resourcegraph/mgmt/2021-03-01/resourcegraph - v55.2.0
    ️✔️azure-sdk-for-go - resourcegraph/mgmt/2019-04-01/resourcegraph - v55.2.0
    ️✔️azure-sdk-for-go - preview/resourcegraph/mgmt/2021-03-01-preview/resourcegraph - v55.2.0
    azure-sdk-for-go - preview/resourcegraph/mgmt/2018-09-01/resourcegraph - v55.2.0
    +	Field `ETag` of struct `GraphQueryResource` has been removed
    +	Field `ETag` of struct `GraphQueryUpdateParameters` has been removed
    +	Field `ETag` of struct `Resource` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-resourcegraph - 8.1.0b1
    +	Model ResourcesHistoryRequest no longer has parameter management_group_id
    +	Removed operation ResourceGraphClientOperationsMixin.resource_change_details
    +	Removed operation ResourceGraphClientOperationsMixin.resource_changes
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3234d01. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resourcegraph/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.ResourceGraph [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3234d01. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-resourcegraph [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model QueryRequestOptions has a new parameter authorization_scope_filter
      info	[Changelog]   - Model ResourcesHistoryRequest has a new parameter management_groups
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model ResourcesHistoryRequest no longer has parameter management_group_id
      info	[Changelog]   - Removed operation ResourceGraphClientOperationsMixin.resource_changes
      info	[Changelog]   - Removed operation ResourceGraphClientOperationsMixin.resource_change_details
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3234d01. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-22 08:39:47 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-resourcegraph;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-06-22 08:39:47 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-06-22 08:39:47 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resourcegraph/azure-resourcemanager-resourcegraph --java.namespace=com.azure.resourcemanager.resourcegraph   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/resourcegraph/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-resourcegraph
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [POM][Skip] pom already has module azure-resourcemanager-resourcegraph
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [POM][Skip] pom already has module sdk/resourcegraph
      cmderr	[generate.py] 2021-06-22 08:40:21 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-resourcegraph [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-22 08:42:40 DEBUG Got artifact_id: azure-resourcemanager-resourcegraph
      cmderr	[Inst] 2021-06-22 08:42:40 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-22 08:42:40 DEBUG Got artifact: azure-resourcemanager-resourcegraph-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-06-22 08:42:40 DEBUG Match jar package: azure-resourcemanager-resourcegraph-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-06-22 08:42:40 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14765/azure-sdk-for-java/azure-resourcemanager-resourcegraph/azure-resourcemanager-resourcegraph-1.0.0-beta.3.jar\" -o azure-resourcemanager-resourcegraph-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resourcegraph -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resourcegraph-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3234d01. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️resourcegraph/mgmt/2021-03-01/resourcegraph [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️resourcegraph/mgmt/2019-04-01/resourcegraph [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resourcegraph/mgmt/2021-03-01-preview/resourcegraph [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resourcegraph/mgmt/2018-09-01/resourcegraph [View full logsBreaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Field `ETag` of struct `GraphQueryUpdateParameters` has been removed
      info	[Changelog] - Field `ETag` of struct `Resource` has been removed
      info	[Changelog] - Field `ETag` of struct `GraphQueryResource` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `Etag` in struct `Resource`
      info	[Changelog] - New field `Etag` in struct `GraphQueryUpdateParameters`
      info	[Changelog] - New field `Etag` in struct `GraphQueryResource`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 3 additive change(s).
      info	[Changelog]
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs]Release - Generate from 3234d01. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resourcegraph/resource-manager/readme.md
    • @azure/arm-resourcegraph [View full logs]  [Release SDK Changes]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/resourcegraph/arm-resourcegraph]: npm pack --silent
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3234d01. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️resourcegraph [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @johnthcall johnthcall marked this pull request as ready for review June 10, 2021 18:53
    @PhoenixHe-NV
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @johnthcall
    Copy link
    Member Author

    @PhoenixHe-msft Is there anything you need from me on this PR?

    • The ConstraintChanged are matching the constraints that are in the stable version for these same properties.
    • For the RemovedProperty we are bringing forward the same change that was done as part of Add 2021-03-01 API version with the GA version changes #13380 when this was considered a warning and not an error.
    • DefaultValueChanged is also using the same default value as the latest stable version where it changed.

    @PhoenixHe-NV PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2021
    @PhoenixHe-NV
    Copy link
    Contributor

    @johnthcall ARM review is required for new api version

    @chiragg4u
    Copy link
    Contributor

    Reviewed the version changes from ARM perspective. Marking ARMSignedOff.

    @chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 21, 2021
    @PhoenixHe-NV PhoenixHe-NV merged commit 3234d01 into Azure:master Jun 22, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …sion preview/2021-06-01-preview (Azure#14765)
    
    * Adds base for updating Microsoft.ResourceGraph from version stable/2021-03-01 to version 2021-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add history and AuthorizationScopeFilter
    
    * Add history to readme
    
    * Fixing Linting
    
    * Fixing format
    
    * Remove ResultFormat default
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants