Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReplicationLinks.json in 2021-02-01-preview #14744

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Update ReplicationLinks.json in 2021-02-01-preview #14744

merged 3 commits into from
Jun 15, 2021

Conversation

ericshape
Copy link
Contributor

@ericshape ericshape commented Jun 9, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

We update 2021-02-01 ReplicationLinks.json to match the 2014-04-01 ReplicationLinks.json API contract: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/stable/2014-04-01/replicationLinks.json. Otherwise, it will break customers.

replicationLinkName -> linkId

Rule Message
❌ 1009 - RemovedRequiredParameter The required parameter 'replicationLinkName' was removed in the new version.Old: Microsoft.Sql/preview/2021-02-01-preview/ReplicationLinks.json#L97:11
❌ 1010 - AddingRequiredParameter The required parameter 'linkId' was added in the new version.New: Microsoft.Sql/preview/2021-02-01-preview/ReplicationLinks.json#L81:11

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      Have stated in the top.
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.

  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.

  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

This can be treated as breaking change, but we change it back to the API contract as 2014-04-01.
The new replication link GET APIs were in prod but based on our monitoring, there is no customer uses it.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 9, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @ghost ghost added the SQL label Jun 9, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 9, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️⌛[Staging] SDK Breaking Change Tracking pending [Detail]
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 47ed02d. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.Sql [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(104,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(105,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(114,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(115,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(104,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(105,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(114,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/DatabaseReplicationLinkScenarioTests.cs(115,29): error CS0019: Operator '==' cannot be applied to operands of type 'ReplicationRole?' and 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/Microsoft.Azure.Management.Sql.Tests.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47ed02d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model BackupShortTermRetentionPolicy has a new parameter diff_backup_interval_in_hours
      info	[Changelog]   - Model ServerUpdate has a new parameter restrict_outbound_network_access
      info	[Changelog]   - Model ServerUpdate has a new parameter federated_client_id
      info	[Changelog]   - Model Server has a new parameter restrict_outbound_network_access
      info	[Changelog]   - Model Server has a new parameter federated_client_id
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ReplicationLinksOperations.get has a new signature
      info	[Changelog]   - Operation BackupShortTermRetentionPoliciesOperations.create_or_update has a new signature
      info	[Changelog]   - Operation BackupShortTermRetentionPoliciesOperations.update has a new signature
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47ed02d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Server has a new parameter restrict_outbound_network_access
      info	[Changelog]   - Model Server has a new parameter federated_client_id
      info	[Changelog]   - Model ServerUpdate has a new parameter federated_client_id
      info	[Changelog]   - Model ServerUpdate has a new parameter restrict_outbound_network_access
      info	[Changelog]   - Model BackupShortTermRetentionPolicy has a new parameter diff_backup_interval_in_hours
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ReplicationLinksOperations.get has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47ed02d. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-17 01:49:03 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-sql-generated"
      cmderr	[generate.py] 2021-06-17 01:49:03 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-06-17 01:49:03 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated --java.namespace=com.azure.resourcemanager.sql.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-17 01:53:02 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-06-17 01:53:02 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-17 01:53:02 INFO [POM][Skip] pom already has module azure-resourcemanager-sql-generated
      cmderr	[generate.py] 2021-06-17 01:53:02 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-17 01:53:02 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-17 01:53:02 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-17 01:58:13 DEBUG Got artifact_id: azure-resourcemanager-sql-generated
      cmderr	[Inst] 2021-06-17 01:58:13 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-17 01:58:13 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-06-17 01:58:13 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-17 01:58:13 DEBUG Match jar package: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-17 01:58:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14744/azure-sdk-for-java/azure-resourcemanager-sql-generated/azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-sql-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-sql-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47ed02d. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sql/mgmt/2014-04-01/sql [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/v4.0/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `LongTermRetentionBackupsUpdateByResourceGroupFuture`
      info	[Changelog] - New struct `LongTermRetentionBackupsUpdateFuture`
      info	[Changelog] - New struct `LongTermRetentionOperationResultProperties`
      info	[Changelog] - New struct `LongTermRetentionPoliciesClient`
      info	[Changelog] - New struct `LongTermRetentionPoliciesCreateOrUpdateFuture`
      info	[Changelog] - New struct `LongTermRetentionPolicy`
      info	[Changelog] - New struct `LongTermRetentionPolicyListResult`
      info	[Changelog] - New struct `LongTermRetentionPolicyListResultIterator`
      info	[Changelog] - New struct `LongTermRetentionPolicyListResultPage`
      info	[Changelog] - New struct `UpdateLongTermRetentionBackupParameters`
      info	[Changelog] - New struct `UpdateLongTermRetentionBackupParametersProperties`
      info	[Changelog] - New field `CurrentBackupStorageRedundancy` in struct `DatabaseProperties`
      info	[Changelog] - New field `RequestedBackupStorageRedundancy` in struct `DatabaseProperties`
      info	[Changelog] - New field `BackupStorageRedundancy` in struct `LongTermRetentionBackupProperties`
      info	[Changelog] - New field `RequestedBackupStorageRedundancy` in struct `LongTermRetentionBackupProperties`
      info	[Changelog]
      info	[Changelog] Total 93 breaking change(s), 111 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/v3.0/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New function `*TopQueriesListResultPage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `ManagedInstancePecProperty.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `ManagedInstancePecProperty`
      info	[Changelog] - New struct `ManagedInstancePrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `ManagedInstancePrivateEndpointProperty`
      info	[Changelog] - New struct `QueryMetricInterval`
      info	[Changelog] - New struct `QueryMetricProperties`
      info	[Changelog] - New struct `QueryStatisticsProperties`
      info	[Changelog] - New struct `TopQueries`
      info	[Changelog] - New struct `TopQueriesListResult`
      info	[Changelog] - New struct `TopQueriesListResultIterator`
      info	[Changelog] - New struct `TopQueriesListResultPage`
      info	[Changelog] - New field `ZoneRedundant` in struct `ManagedInstanceProperties`
      info	[Changelog] - New field `PrivateEndpointConnections` in struct `ManagedInstanceProperties`
      info	[Changelog] - New field `Identity` in struct `ManagedInstanceUpdate`
      info	[Changelog]
      info	[Changelog] Total 21 breaking change(s), 73 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2018-06-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - Const `None` type has been changed from `SensitivityLabelRank` to `IdentityType`
      info	[Changelog] - Const `Low` has been removed
      info	[Changelog] - Const `Medium` has been removed
      info	[Changelog] - Const `High` has been removed
      info	[Changelog] - Const `Critical` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `SensitivityLabelRankNone`
      info	[Changelog] - New const `SensitivityLabelRankCritical`
      info	[Changelog] - New const `SensitivityLabelRankLow`
      info	[Changelog] - New const `SensitivityLabelRankMedium`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `SensitivityLabelRankHigh`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2017-10-01-preview/sql [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/2017-03-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `PrimaryAggregationTypeCount`
      info	[Changelog] - New const `Percent`
      info	[Changelog] - New const `PrimaryAggregationTypeAverage`
      info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
      info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `BytesPerSecond`
      info	[Changelog] - New const `Seconds`
      info	[Changelog] - New const `PrimaryAggregationTypeNone`
      info	[Changelog] - New const `PrimaryAggregationTypeTotal`
      info	[Changelog] - New const `Bytes`
      info	[Changelog] - New const `CountPerSecond`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2015-05-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 18 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `CountPerSecond`
      info	[Changelog] - New const `Percent`
      info	[Changelog] - New const `PrimaryAggregationTypeTotal`
      info	[Changelog] - New const `PrimaryAggregationTypeAverage`
      info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
      info	[Changelog] - New const `PrimaryAggregationTypeCount`
      info	[Changelog] - New const `PrimaryAggregationTypeNone`
      info	[Changelog] - New const `Seconds`
      info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
      info	[Changelog] - New const `Bytes`
      info	[Changelog] - New const `BytesPerSecond`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47ed02d. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
      cmderr	[npmPack] created ./dist/arm-sql.js in 2s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47ed02d. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    @ericshape
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi, @ericshape your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @

    @openapi-workflow-bot
    Copy link

    Hi, @ericshape your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @zhenglaizhang

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi @ericshape, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @zhenglaizhang zhenglaizhang removed their assignment Jun 10, 2021
    @j5lim j5lim added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 10, 2021
    @zhenglaizhang
    Copy link
    Contributor

    @ArcturusZhang @msyyc pls help review the SDK breaking change.

    @ericshape
    Copy link
    Contributor Author

    @ArcturusZhang @msyyc pls help review the SDK breaking change.

    I think the .NET SDK failure is expected because we change the replicationRole define from string to enum string.

    @ArcturusZhang
    Copy link
    Member

    Hi @ericshape could you take a look why we see the BackupLongTermRetentionPoliciesClient was removed in the generated SDK?

    Is this operation group defined previously in 2020-11-01-preview/ReplicationLinks.json but not in 2021-02-01-preview/ReplicationLinks.json?

    @ericshape
    Copy link
    Contributor Author

    ericshape commented Jun 15, 2021

    Hi @ericshape could you take a look why we see the BackupLongTermRetentionPoliciesClient was removed in the generated SDK?

    Is this operation group defined previously in 2020-11-01-preview/ReplicationLinks.json but not in 2021-02-01-preview/ReplicationLinks.json?

    @ArcturusZhang
    No.
    This PR is about https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2020-11-01-preview/ReplicationLinks.json

    BackupLongTermRetentionPoliciesClient is from: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2021-02-01-preview/LongTermRetentionPolicies.json
    And the Golang SDK is based on v4 sdk tag. But the latest python, .NET and current swagger are from v5 SDK tag.
    We need to release Golang SDK based on V5 sdk tag.

    cc: @zhenglaizhang

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 15, 2021
    @zhenglaizhang zhenglaizhang added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 15, 2021
    @zhenglaizhang zhenglaizhang merged commit 47ed02d into Azure:master Jun 15, 2021
    @RAY-316
    Copy link
    Contributor

    RAY-316 commented Jun 17, 2021

    /azp run

    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    * update ReplicationLinks.json in 2021-02-01-preview
    
    * update json file
    
    * update examples/ReplicationLinkGet.json
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * update ReplicationLinks.json in 2021-02-01-preview
    
    * update json file
    
    * update examples/ReplicationLinkGet.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python SQL
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants