-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ReplicationLinks.json in 2021-02-01-preview #14744
Update ReplicationLinks.json in 2021-02-01-preview #14744
Conversation
Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @ericshape your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ |
Hi, @ericshape your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @zhenglaizhang |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @ericshape, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@ArcturusZhang @msyyc pls help review the SDK breaking change. |
I think the .NET SDK failure is expected because we change the replicationRole define from string to enum string. |
Hi @ericshape could you take a look why we see the Is this operation group defined previously in |
@ArcturusZhang BackupLongTermRetentionPoliciesClient is from: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2021-02-01-preview/LongTermRetentionPolicies.json cc: @zhenglaizhang |
/azp run |
* update ReplicationLinks.json in 2021-02-01-preview * update json file * update examples/ReplicationLinkGet.json
* update ReplicationLinks.json in 2021-02-01-preview * update json file * update examples/ReplicationLinkGet.json
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
We update 2021-02-01 ReplicationLinks.json to match the 2014-04-01 ReplicationLinks.json API contract: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/stable/2014-04-01/replicationLinks.json. Otherwise, it will break customers.
replicationLinkName -> linkId
Changelog
Please ensure to add changelog with this PR by answering the following questions.
What's the purpose of the update?
Have stated in the top.
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
This can be treated as breaking change, but we change it back to the API contract as 2014-04-01.
The new replication link GET APIs were in prod but based on our monitoring, there is no customer uses it.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.