[Bug] - remove apiVersion from securityInsights common and targeting the ApiVersionParameter in the common-type #14641

ori-licht · 2021-06-02T16:43:25Z

…ersionParameter in the common-type

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify - fix bug in current swagger
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…ersionParameter in the common-type

openapi-workflow-bot · 2021-06-02T16:43:28Z

Hi, @ori-licht Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-06-02T16:43:28Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-06-02T16:43:28Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- current:preview/2021-03-01-preview/operations.json compared with base:preview/2021-03-01-preview/operations.json
- current:common/1.0/types.json compared with base:common/1.0/types.json

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ApiVersion' removed or renamed? New: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L126:3 Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L126:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ApiVersion' removed or renamed? New: resource-manager/common/1.0/types.json#L80:3 Old: resource-manager/common/1.0/types.json#L80:3
`❌` 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L41:9 Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L41:9

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- securityinsights/resource-manager/readme.md tag:package-2021-03-preview-only
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- securityinsights/resource-manager/readme.md tag:package-2021-03-preview-only

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.SecurityInsights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L37
⚠️ R1006 - PutInOperationName	'PUT' operation 'ProductSettings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L185
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'ProductSettings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L38
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'SentinelOnboardingStates_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/OnboardingStates.json#L187
⚠️ R2057 - InvalidSkuModel	Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L482
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SourceControlModel'. Consider using the plural form of 'SourceControl' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/SourceControls.json#L48
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'watchlistItems' with immediate parent 'Watchlist', must have a list by immediate parent operation. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Metadata.json#L302
⚠️ R3017 - GuidUsage	Guid used in model definition 'UserInfo' for property 'objectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Watchlists.json#L700
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L380
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L408

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

securityinsights/resource-manager/readme.md#package-2021-03-preview-only

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"securityinsights/resource-manager/readme.md",
"tag":"package-2021-03-preview-only",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"securityinsights/resource-manager/readme.md",
"tag":"package-2021-03-preview-only",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"securityinsights/resource-manager/readme.md",
"tag":"package-2021-03-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-06-02T16:43:29Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - securityinsight/mgmt/v1.0/securityinsight - v55.1.0

️✔️azure-sdk-for-go - securityinsight/mgmt/2020-01-01/securityinsight - v55.1.0
️✔️azure-sdk-for-go - preview/securityinsight/mgmt/2019-01-01-preview/securityinsight - v55.1.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 91b376e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityInsights.1.0.0.nupkg
- Microsoft.Azure.Management.SecurityInsights.1.0.0.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 91b376e. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected
```
info	[Changelog] This package was removed
```
️✔️securityinsight/mgmt/2020-01-01/securityinsight [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `DomainWhoisClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewIPGeodataClient(string) IPGeodataClient`
info	[Changelog] - New function `DomainWhoisClient.Get(context.Context, string, string) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `IPGeodataClient.GetResponder(*http.Response) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `NewDomainWhoisClientWithBaseURI(string, string) DomainWhoisClient`
info	[Changelog] - New function `DomainWhoisClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `IPGeodataClient.Get(context.Context, string, string) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `DomainWhoisClient.GetResponder(*http.Response) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `IPGeodataClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `IPGeodataClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewDomainWhoisClient(string) DomainWhoisClient`
info	[Changelog] - New function `NewIPGeodataClientWithBaseURI(string, string) IPGeodataClient`
info	[Changelog] - New struct `DomainWhoisClient`
info	[Changelog] - New struct `EnrichmentDomainWhois`
info	[Changelog] - New struct `EnrichmentDomainWhoisContact`
info	[Changelog] - New struct `EnrichmentDomainWhoisContacts`
info	[Changelog] - New struct `EnrichmentDomainWhoisDetails`
info	[Changelog] - New struct `EnrichmentDomainWhoisRegistrarDetails`
info	[Changelog] - New struct `EnrichmentIPGeodata`
info	[Changelog] - New struct `IPGeodataClient`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 28 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 91b376e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 91b376e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md

️✔️@azure/arm-securityinsight [View full logs] [Release SDK Changes]

azure-arm-securityinsight-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
cmderr	[npmPack] created ./dist/arm-securityinsight.js in 428ms

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 91b376e. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-teams' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Actions/put/Creates or updates an action of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get an action of alert rule.
cmderr	[Autorest]     - name: /Actions/delete/Delete an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
cmderr	[Autorest]     - name: /Bookmarks/put/Creates or updates a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get all bookmarks.
cmderr	[Autorest]     - name: /Bookmarks/delete/Delete a bookmark.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Threat Intelligence Platform data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a ASC data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MCAS data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MDATP data connector
cmderr	[Autorest]     - name: /DataConnectors/get/Get a TI data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get all data connectors.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AAD data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AATP data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
cmderr	[Autorest]     - name: /IncidentComments/put/Creates an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
cmderr	[Autorest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 91b376e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️securityinsights [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

zhenglaizhang · 2021-06-03T00:17:33Z

/azp run

azure-pipelines · 2021-06-03T00:17:44Z

Azure Pipelines successfully started running 1 pipeline(s).

zhenglaizhang · 2021-06-03T00:20:28Z

/azp run

azure-pipelines · 2021-06-03T00:20:37Z

Azure Pipelines successfully started running 1 pipeline(s).

zhenglaizhang · 2021-06-03T00:55:19Z

/azp run

azure-pipelines · 2021-06-03T00:55:29Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2021-06-03T00:57:14Z

Hi @ori-licht, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

ori-licht · 2021-06-03T07:57:27Z

This is a bug fix, while all resources are targeting the commo-types, ApiVersionParameter, the operations is targeting an internal common, which is redundant.
When generating the swagger this creates an "ApiVersion" and "ApiVersion1" properties

openapi-workflow-bot · 2021-06-07T06:55:28Z

Hi, @ori-licht your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @raych1

j5lim · 2021-06-07T21:53:07Z

Please make sure ARM API Review Checklist is marked correctly. The changes in the pr do not require a review by ARM.

ori-licht · 2021-06-08T07:03:06Z

Please make sure ARM API Review Checklist is marked correctly. The changes in the pr do not require a review by ARM.

ok, thank you, I thought that the "BreakingChangeReviewRequired" tag indicates that is does.

raych1 · 2021-06-08T07:15:45Z

Hi @ori-licht, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

@ori-licht , changing api version parameter model is a braking change since the old one only accept a enum api-version value? Can you follow above action to get breaking change review approval?

ori-licht · 2021-06-08T07:19:00Z

Hi @ori-licht, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

@ori-licht , changing api version parameter model is a braking change since the old one only accept a enum api-version value? Can you follow above action to get breaking change review approval?

ohhh, now I have added that tag again,
I'll go to next week weekly hour.

but this is a bug fix, the swagger is being generated incorrectly

ori-licht · 2021-06-09T07:06:27Z

I also have this PR - #14659
have no one assign to it

ori-licht · 2021-06-15T06:53:06Z

Hi @raych1,
anything else is needed for this PR?

Thank you

…ersionParameter in the common-type (Azure#14641)

remove apiVersion from securityInsights common and targeting the ApiV…

006e8be

…ersionParameter in the common-type

ori-licht closed this Jun 2, 2021

ori-licht reopened this Jun 2, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jun 3, 2021

ori-licht marked this pull request as ready for review June 3, 2021 07:55

openapi-assignment-bot bot assigned raych1 Jun 3, 2021

dosegal approved these changes Jun 3, 2021

View reviewed changes

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2021

j5lim removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 8, 2021

ori-licht closed this Jun 8, 2021

ori-licht reopened this Jun 8, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jun 8, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 14, 2021

JeffreyRichter approved these changes Jun 14, 2021

View reviewed changes

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 14, 2021

raych1 approved these changes Jun 15, 2021

View reviewed changes

raych1 merged commit 91b376e into Azure:master Jun 15, 2021

asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021

remove apiVersion from securityInsights common and targeting the ApiV…

675a912

…ersionParameter in the common-type (Azure#14641)

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

remove apiVersion from securityInsights common and targeting the ApiV…

a07ff0e

…ersionParameter in the common-type (Azure#14641)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] - remove apiVersion from securityInsights common and targeting the ApiVersionParameter in the common-type #14641

[Bug] - remove apiVersion from securityInsights common and targeting the ApiVersionParameter in the common-type #14641

ori-licht commented Jun 2, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jun 2, 2021

openapi-workflow-bot bot commented Jun 2, 2021

openapi-pipeline-app bot commented Jun 2, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 2, 2021 •

edited

Loading

Breaking Changes Tracking

zhenglaizhang commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

zhenglaizhang commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

zhenglaizhang commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

openapi-workflow-bot bot commented Jun 3, 2021

ori-licht commented Jun 3, 2021

openapi-workflow-bot bot commented Jun 7, 2021

j5lim commented Jun 7, 2021

ori-licht commented Jun 8, 2021

raych1 commented Jun 8, 2021

ori-licht commented Jun 8, 2021 •

edited

Loading

ori-licht commented Jun 9, 2021

ori-licht commented Jun 15, 2021

[Bug] - remove apiVersion from securityInsights common and targeting the ApiVersionParameter in the common-type #14641

[Bug] - remove apiVersion from securityInsights common and targeting the ApiVersionParameter in the common-type #14641

Conversation

ori-licht commented Jun 2, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 2, 2021

openapi-workflow-bot bot commented Jun 2, 2021

openapi-pipeline-app bot commented Jun 2, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 2, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

zhenglaizhang commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

zhenglaizhang commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

zhenglaizhang commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

openapi-workflow-bot bot commented Jun 3, 2021

ori-licht commented Jun 3, 2021

openapi-workflow-bot bot commented Jun 7, 2021

j5lim commented Jun 7, 2021

ori-licht commented Jun 8, 2021

raych1 commented Jun 8, 2021

ori-licht commented Jun 8, 2021 • edited Loading

ori-licht commented Jun 9, 2021

ori-licht commented Jun 15, 2021

ori-licht commented Jun 2, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 2, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 2, 2021 •

edited

Loading

ori-licht commented Jun 8, 2021 •

edited

Loading