[EventGrid] Add "FarmBeats" prefix to two enums #14628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `JobStatus` and `ResourceActionType` has very general names and did not indicate they were specific to FarmBeats. Add a prefix to the names so the generated types in the SDKs have more specific names.
|
Hi, @ellismg Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"Error: Semantic validation failed. There was some errors" |
| 💬 AutorestCore/Exception | "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
@lmazuel Sorry for not noticing this when the events were in PR, it didn't become obvious to me before reviewing the surface area changes to the SDKs after ingesting the new events. |
JoshLove-msft
approved these changes
Jun 1, 2021
rakshith91
approved these changes
Jun 1, 2021
lmazuel
approved these changes
Jun 2, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
The `JobStatus` and `ResourceActionType` has very general names and did not indicate they were specific to FarmBeats. Add a prefix to the names so the generated types in the SDKs have more specific names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JobStatusandResourceActionTypehas very general names anddid not indicate they were specific to FarmBeats. Add a prefix to the
names so the generated types in the SDKs have more specific names.