Add 2021-05-01 ARM API version for Synapse RP #14605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @coolswatish Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
|
The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/bigDataPool.json#L25 |
|
The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/firewallRule.json#L203 |
|
The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L85 |
|
The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/keys.json#L75 |
|
The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/library.json#L25 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/privateEndpointConnections.json#L46 |
|
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/privateLinkResources.json#L75 |
|
The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/privateLinkResources.json#L175 |
|
The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-05-01/privatelinkhub.json#L86 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/stable/2021-05-01/workspace.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2021-05-01/bigDataPool.json compared with base:preview/2021-04-01-preview/bigDataPool.json
- current:stable/2021-05-01/checkNameAvailability.json compared with base:preview/2021-04-01-preview/checkNameAvailability.json
- current:stable/2021-05-01/firewallRule.json compared with base:preview/2021-04-01-preview/firewallRule.json
- current:stable/2021-05-01/integrationRuntime.json compared with base:preview/2021-04-01-preview/integrationRuntime.json
- current:stable/2021-05-01/keys.json compared with base:preview/2021-04-01-preview/keys.json
- current:stable/2021-05-01/library.json compared with base:preview/2021-04-01-preview/library.json
- current:stable/2021-05-01/operations.json compared with base:preview/2021-04-01-preview/operations.json
- current:stable/2021-05-01/privateEndpointConnections.json compared with base:preview/2021-04-01-preview/privateEndpointConnections.json
- current:stable/2021-05-01/privateLinkResources.json compared with base:preview/2021-04-01-preview/privateLinkResources.json
- current:stable/2021-05-01/privatelinkhub.json compared with base:preview/2021-04-01-preview/privatelinkhub.json
- current:stable/2021-05-01/sqlPool.json compared with base:preview/2021-04-01-preview/sqlPool.json
- current:stable/2021-05-01/sqlServer.json compared with base:preview/2021-04-01-preview/sqlServer.json
- current:stable/2021-05-01/workspace.json compared with base:preview/2021-04-01-preview/workspace.json
- current:stable/2021-05-01/bigDataPool.json compared with base:stable/2021-03-01/bigDataPool.json
- current:stable/2021-05-01/checkNameAvailability.json compared with base:stable/2021-03-01/checkNameAvailability.json
- current:stable/2021-05-01/firewallRule.json compared with base:stable/2021-03-01/firewallRule.json
- current:stable/2021-05-01/integrationRuntime.json compared with base:stable/2021-03-01/integrationRuntime.json
- current:stable/2021-05-01/keys.json compared with base:stable/2021-03-01/keys.json
- current:stable/2021-05-01/library.json compared with base:stable/2021-03-01/library.json
- current:stable/2021-05-01/operations.json compared with base:stable/2021-03-01/operations.json
- current:stable/2021-05-01/privateEndpointConnections.json compared with base:stable/2021-03-01/privateEndpointConnections.json
- current:stable/2021-05-01/privateLinkResources.json compared with base:stable/2021-03-01/privateLinkResources.json
- current:stable/2021-05-01/privatelinkhub.json compared with base:stable/2021-03-01/privatelinkhub.json
- current:stable/2021-05-01/sqlPool.json compared with base:stable/2021-03-01/sqlPool.json
- current:stable/2021-05-01/sqlServer.json compared with base:stable/2021-03-01/sqlServer.json
- current:stable/2021-05-01/workspace.json compared with base:stable/2021-03-01/workspace.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1281", properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-05-01/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
| 💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-05", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced May 31, 2021
This was referenced May 31, 2021
|
@coolswatish , need to fix lintdiff, prettier issue and spell check |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @coolswatish your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ruowan |
|
Hi @coolswatish, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
…2021-05-01 Dev synapse microsoft.synapse 2021 05 01
Add PEC Get api to avoid cross version breaking change
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=220316&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.0.0️✔️azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v55.0.0️✔️azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v55.0.0❌azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v55.0.0+ Field `HaveLibraryRequirementsChanged` of struct `BigDataPoolResourceProperties` has been removed
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 warn specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Synapse [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured warn specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
️✔️@azure/arm-synapse [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js... cmderr [npmPack] created ./dist/arm-synapse.js in 1.2s
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json warn specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️✔️azure-resourcemanager-synapse [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-synapse-1.0.0-beta.2-sources.jar
- azure-resourcemanager-synapse-1.0.0-beta.2.jar
- azure-resourcemanager-synapse-1.0.0-beta.2-javadoc.jar
cmderr [Inst] 2021-06-08 06:08:50 DEBUG Got artifact_id: azure-resourcemanager-synapse cmderr [Inst] 2021-06-08 06:08:50 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-06-08 06:08:50 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2-sources.jar cmderr [Inst] 2021-06-08 06:08:50 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2.jar cmderr [Inst] 2021-06-08 06:08:50 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.2.jar cmderr [Inst] 2021-06-08 06:08:50 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14605/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.2.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-sdk-for-python warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-synapse [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model CustomerManagedKeyDetails has a new parameter kek_identity info [Changelog] - Model Workspace has a new parameter csp_workspace_admin_properties info [Changelog] - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-synapse [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model CustomerManagedKeyDetails has a new parameter kek_identity info [Changelog] - Model Workspace has a new parameter csp_workspace_admin_properties info [Changelog] - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get
️❌ azure-sdk-for-go failed [Detail]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json warn specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-go not found in swagger-to-sdk command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"} HttpError: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"} at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/[email protected]/node_modules/@octokit/request/dist-node/index.js:68:23 at runMicrotasks (<anonymous>) at processTicksAndRejections (internal/process/task_queues.js:95:5) at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:330:21) at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5) at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9) at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9) at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13) at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18️✔️synapse/mgmt/2021-03-01/synapse [View full logs] [Release SDK Changes]info [Changelog] No exported changes
- Only show 40 items here, please refer to log for details.
️✔️synapse/mgmt/2020-12-01/synapse [View full logs] [Release SDK Changes]info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `NewLibraryClient(string) LibraryClient` info [Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)` info [Changelog] - New function `LibraryClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient` info [Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `*LibraryListResponsePage.Next() error` info [Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)` info [Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource` info [Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource` info [Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)` info [Changelog] - New function `LibraryListResponseIterator.NotDone() bool` info [Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage` info [Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)` info [Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse` info [Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error` info [Changelog] - New function `NewLibrariesClient(string) LibrariesClient` info [Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `LibrariesClient.ListByWorkspaceComplete(context.Context, string, string) (LibraryListResponseIterator, error)` info [Changelog] - New function `*LibraryListResponseIterator.Next() error` info [Changelog] - New function `*LibraryListResponseIterator.NextWithContext(context.Context) error` info [Changelog] - New function `LibraryListResponse.IsEmpty() bool` info [Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient` info [Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)` info [Changelog] - New function `LibraryListResponsePage.NotDone() bool` info [Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)` info [Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator` info [Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error` info [Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse` info [Changelog] - New struct `LibrariesClient` info [Changelog] - New struct `LibraryClient` info [Changelog] - New struct `LibraryListResponse` info [Changelog] - New struct `LibraryListResponseIterator` info [Changelog] - New struct `LibraryListResponsePage` info [Changelog] - New struct `LibraryResource` info [Changelog] info [Changelog] Total 0 breaking change(s), 40 additive change(s). info [Changelog]
- Only show 40 items here, please refer to log for details.
️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] Breaking Change Detectedinfo [Changelog] - New struct `DynamicExecutorAllocation` info [Changelog] - New struct `LibraryInfo` info [Changelog] - New struct `MaintenanceWindowOptions` info [Changelog] - New struct `MaintenanceWindowOptionsProperties` info [Changelog] - New struct `MaintenanceWindowTimeRange` info [Changelog] - New struct `MaintenanceWindows` info [Changelog] - New struct `MaintenanceWindowsProperties` info [Changelog] - New struct `ManagedVirtualNetworkReference` info [Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New struct `RecommendedSensitivityLabelUpdate` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateList` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties` info [Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient` info [Changelog] - New struct `SQLPoolMaintenanceWindowsClient` info [Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New struct `SensitivityLabelUpdate` info [Changelog] - New struct `SensitivityLabelUpdateList` info [Changelog] - New struct `SensitivityLabelUpdateProperties` info [Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties` info [Changelog] - New field `ManagedBy` in struct `SensitivityLabel` info [Changelog] - New field `Rank` in struct `SensitivityLabelProperties` info [Changelog] - New field `TableName` in struct `SensitivityLabelProperties` info [Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties` info [Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties` info [Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime` info [Changelog] info [Changelog] Total 1 breaking change(s), 119 additive change(s). info [Changelog] error Fatal error: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"} error The following packages are still pending: error synapse/mgmt/2021-03-01/synapse error synapse/mgmt/2020-12-01/synapse error preview/synapse/mgmt/2019-06-01-preview/synapse
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read warn specification/synapse/data-plane/readme.md skipped due to azure-resource-manager-schemas not found in swagger-to-sdk command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️✔️synapse [View full logs] [Release Schema Changes]
majastrz
reviewed
Jun 2, 2021
| } | ||
| } | ||
| }, | ||
| "default": { |
majastrz
added
ARMSignedOff
This was referenced Jun 8, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 8, 2021
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* Adds base for updating Microsoft.Synapse from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * Added 2021-05-01 version to Synapse RP ARM API spec * Fixed spellcheck and prettier checks * Fixed spellchecks * Add get pec api Co-authored-by: Surya Prakash <[email protected]> Co-authored-by: Surya <[email protected]>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adds base for updating Microsoft.Synapse from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * Added 2021-05-01 version to Synapse RP ARM API spec * Fixed spellcheck and prettier checks * Fixed spellchecks * Add get pec api Co-authored-by: Surya Prakash <[email protected]> Co-authored-by: Surya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.