-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communication] - Fixing broken paths in swagger #14488
Conversation
Hi, @JoshuaLai Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Chat/preview/2020-11-01-preview3/communicationserviceschat.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Chat/preview/2020-11-01-preview3/communicationserviceschat.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2020-11-01-preview3/communicationserviceschat.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2020-11-01-preview3/communicationserviceschat.json:1235:6 ($.definitions.ErrorResponse["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedExcept" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Chat/preview/2021-01-27-preview4/communicationserviceschat.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Chat/preview/2021-01-27-preview4/communicationserviceschat.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2021-01-27-preview4/communicationserviceschat.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2021-01-27-preview4/communicationserviceschat.json:1251:6 ($.definitions.ErrorResponse["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Chat/preview/2021-03-01-preview5/communicationserviceschat.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Chat/preview/2021-03-01-preview5/communicationserviceschat.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2021-03-01-preview5/communicationserviceschat.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2021-03-01-preview5/communicationserviceschat.json:1251:6 ($.definitions.CommunicationErrorResponse["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedExc" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Chat/preview/2021-04-05-preview6/communicationserviceschat.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Chat/preview/2021-04-05-preview6/communicationserviceschat.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2021-04-05-preview6/communicationserviceschat.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/preview/2021-04-05-preview6/communicationserviceschat.json:1251:6 ($.definitions.CommunicationErrorResponse["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedExc" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Chat/stable/2021-03-07/communicationserviceschat.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Chat/stable/2021-03-07/communicationserviceschat.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/stable/2021-03-07/communicationserviceschat.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Chat/stable/2021-03-07/communicationserviceschat.json:1251:6 ($.definitions.CommunicationErrorResponse["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occurr" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Identity/preview/2021-02-22-preview1/CommunicationIdentity.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Identity/preview/2021-02-22-preview1/CommunicationIdentity.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Identity/preview/2021-02-22-preview1/CommunicationIdentity.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Identity/preview/2021-02-22-preview1/CommunicationIdentity.json:173:14 ($.paths["/identities/id/:issueAccessToken"].post.responses.default.schema["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due " |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Identity/preview/2021-03-31-preview1/CommunicationIdentity.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Identity/preview/2021-03-31-preview1/CommunicationIdentity.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Identity/preview/2021-03-31-preview1/CommunicationIdentity.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Identity/preview/2021-03-31-preview1/CommunicationIdentity.json:220:14 ($.paths["/identities/id/:issueAccessToken"].post.responses.default.schema["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due " |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Identity/stable/2021-03-07/CommunicationIdentity.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Identity/stable/2021-03-07/CommunicationIdentity.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Identity/stable/2021-03-07/CommunicationIdentity.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Identity/stable/2021-03-07/CommunicationIdentity.json:173:14 ($.paths["/identities/id/:issueAccessToken"].post.responses.default.schema["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [Oper" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/PhoneNumbers/stable/2021-03-07/phonenumbers.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/PhoneNumbers/stable/2021-03-07/phonenumbers.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/PhoneNumbers/stable/2021-03-07/phonenumbers.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/PhoneNumbers/stable/2021-03-07/phonenumbers.json:730:10 ($.definitions.PhoneNumberOperation.properties.error["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occur" |
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5c3b6d7ef534a9d44e12f57298b0f65416f80aeb/specification/communication/data-plane/Turn/preview/2021-02-22-preview1/CommunicationTurn.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Turn/preview/2021-02-22-preview1/CommunicationTurn.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Turn/preview/2021-02-22-preview1/CommunicationTurn.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found\n - file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Turn/preview/2021-02-22-preview1/CommunicationTurn.json:35:14 ($.paths["/turn/id/:issueCredentials"].post.responses.default.schema["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [Operati" |
️❌
LintDiff: 0 Errors, 47 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- data-plane/Chat/readme.md tag:package-chat-2021-04-05-preview6
- data-plane/Chat/readme.md tag:package-chat-2021-03-07
- data-plane/Chat/readme.md tag:package-2021-03-01-preview5
- data-plane/Chat/readme.md tag:package-2021-01-27-preview4
- data-plane/Chat/readme.md tag:package-2020-11-01-preview3
- data-plane/Identity/readme.md tag:package-2021-03-31-preview1
- data-plane/Identity/readme.md tag:package-2021-03-07
- data-plane/Identity/readme.md tag:package-2021-02-22-preview1
- data-plane/PhoneNumbers/readme.md tag:package-phonenumber-2021-03-07
- data-plane/Turn/readme.md tag:package-2021-02-22-preview1
- eventgrid/data-plane/readme.md tag:package-2018-01
- Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- data-plane/Chat/readme.md tag:package-chat-2021-04-05-preview6
- data-plane/Chat/readme.md tag:package-chat-2021-03-07
- data-plane/Chat/readme.md tag:package-2021-03-01-preview5
- data-plane/Chat/readme.md tag:package-2021-01-27-preview4
- data-plane/Chat/readme.md tag:package-2020-11-01-preview3
- data-plane/Identity/readme.md tag:package-2021-03-31-preview1
- data-plane/Identity/readme.md tag:package-2021-03-07
- data-plane/Identity/readme.md tag:package-2021-02-22-preview1
- data-plane/PhoneNumbers/readme.md tag:package-phonenumber-2021-03-07
- data-plane/Turn/readme.md tag:package-2021-02-22-preview1
- eventgrid/data-plane/readme.md tag:package-2018-01
Only 10 items are listed, please refer to log for more details.
Rule | Message |
---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L118 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L146 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L217 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L243 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Devices/stable/2018-01-01/IotHub.json#L103 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Devices/stable/2018-01-01/IotHub.json#L147 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ChatThreadModel'. Consider using the plural form of 'ChatThread' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Chat/preview/2020-11-01-preview3/communicationserviceschat.json#L15 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ChatThreadModel'. Consider using the plural form of 'ChatThread' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Chat/preview/2020-11-01-preview3/communicationserviceschat.json#L96 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ChatThreadModel'. Consider using the plural form of 'ChatThread' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Chat/preview/2020-11-01-preview3/communicationserviceschat.json#L170 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ChatThreadModel'. Consider using the plural form of 'ChatThread' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Chat/preview/2020-11-01-preview3/communicationserviceschat.json#L245 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
Rule | Message |
---|---|
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-chat-2021-04-05-preview6", "details":"Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found" |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-chat-2021-04-05-preview6", "details":"swagger-document/loader - FAILED" |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-chat-2021-04-05-preview6", "details":"Error: [OperationAbortedException] Error occurred. Exiting." |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-chat-2021-03-07", "details":"Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found" |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-chat-2021-03-07", "details":"swagger-document/loader - FAILED" |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-chat-2021-03-07", "details":"Error: [OperationAbortedException] Error occurred. Exiting." |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-2021-03-01-preview5", "details":"Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found" |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-2021-03-01-preview5", "details":"swagger-document/loader - FAILED" |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-2021-03-01-preview5", "details":"Error: [OperationAbortedException] Error occurred. Exiting." |
AutoRest exception |
"readme":"communication/data-plane/Chat/readme.md", "tag":"package-2021-01-27-preview4", "details":"Referenced file 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/communication/data-plane/Microsoft.CommunicationServicesCommon/stable/2021-03-07/common.json' not found" |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
[Staging] SDK Track2 Validation inProgress [Detail]
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other swaggers that need these replacements as well: Turn, PhoneNumbers, Identity, etc.
@@ -113,7 +113,7 @@ | |||
"properties": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this even in EventGrid?
* [AzureCommunicationServices] fixing folder paths * [Chat] updating path in swagger * [Communication] fixing folder paths
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.