Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Subscriptions 2021-01-01-privatepreview #14390

Closed

Conversation

rajshah11
Copy link
Contributor

@rajshah11 rajshah11 commented May 12, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
    Already deployed
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
    By end of this month, As soon as, possible
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @rajshah11 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi, @rajshah11 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 12, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 12, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️❌LintDiff: 5 Errors, 26 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4009 - RequiredReadOnlySystemData The response of operation:'Subscriptions_CreateAlias' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L20
    R4009 - RequiredReadOnlySystemData The response of operation:'Subscriptions_GetAlias' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L66
    R4009 - RequiredReadOnlySystemData The response of operation:'SubscriptionPolicy_AddUpdatePolicyForTenant' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L633
    R4009 - RequiredReadOnlySystemData The response of operation:'SubscriptionPolicy_GetPolicyForTenant' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L669
    R4009 - RequiredReadOnlySystemData The response of operation:'BillingAccount_GetPolicy' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L732
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Subscriptions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L245
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Subscriptions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L305
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Subscriptions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L380
    ⚠️ R1005 - GetInOperationName 'GET' operation 'Subscription_AcceptOwnershipStatus' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L212
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'SubscriptionPolicy_AddUpdatePolicyForTenant' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L635


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L46
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L85
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L121
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L154
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L49
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L103
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L139
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L172
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L246
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L285
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND In operation "Subscription_AcceptOwnershipStatus", parameter subscriptionId is required in the swagger spec but is not present in the provided example parameter values.
    Url: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L233
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 22 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_Create' to 'Subscriptions_CreateAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L20:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L164:7
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_Get' to 'Subscriptions_GetAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L66:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L213:7
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_Delete' to 'Subscriptions_DeleteAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L97:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L247:7
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_List' to 'Subscriptions_ListAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L130:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L283:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L783:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L320:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L783:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L320:7
    1034 - AddedRequiredProperty The new version has new required property 'displayName, workload, billingScope' that was not found in the old version.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L794:9
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L431:9
    1034 - AddedRequiredProperty The new version has new required property 'displayName, workload, billingScope' that was not found in the old version.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L800:5
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L437:5


    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateSubscriptionInEnrollmentAccount' to 'Subscriptions_CreateSubscriptionInEnrollmentAccount'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L243:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L20:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateSubscription' to 'Subscriptions_CreateSubscription'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L303:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L256:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateCspSubscription' to 'Subscriptions_CreateCspSubscription'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L378:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L330:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateAlias' to 'Subscriptions_CreateAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L20:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L397:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_GetAlias' to 'Subscriptions_GetAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L66:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L443:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_DeleteAlias' to 'Subscriptions_DeleteAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L97:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L474:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_ListAlias' to 'Subscriptions_ListAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L130:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L507:7
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L578:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L571:15
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L204:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L326:15
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L279:15
    ️🔄CredScan inProgress [Detail]
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2021-01-privatepreview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2021-01-privatepreview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2019-10-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2019-10-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 12, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ea46c4d96b0d6c5e9586dbf6f6fa7e4e275d3fe0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/subscription/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Subscription [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ea46c4d96b0d6c5e9586dbf6f6fa7e4e275d3fe0. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️subscription/mgmt/2020-09-01/subscription [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/subscription/mgmt/2019-10-01-preview/subscription [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/subscription/mgmt/2018-03-01-preview/subscription [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `OperationClient.GetPreparer(context.Context, string) (*http.Request, error)`
      info	[Changelog] - New function `OperationClient.GetSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `NewOperationClient() OperationClient`
      info	[Changelog] - New function `OperationClient.Get(context.Context, string) (CreationResult, error)`
      info	[Changelog] - New function `OperationClient.GetResponder(*http.Response) (CreationResult, error)`
      info	[Changelog] - New function `NewOperationClientWithBaseURI(string) OperationClient`
      info	[Changelog] - New struct `ErrorResponseBody`
      info	[Changelog] - New struct `OperationClient`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
      info	[Changelog]
    • ️✔️preview/subscription/mgmt/2017-11-01-preview/subscription [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from ea46c4d96b0d6c5e9586dbf6f6fa7e4e275d3fe0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-subscription [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ea46c4d96b0d6c5e9586dbf6f6fa7e4e275d3fe0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/subscription/resource-manager/readme.md
    • ️✔️@azure/arm-subscriptions [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/subscriptionClient.js → ./dist/arm-subscriptions.js...
      cmderr	[npmPack] created ./dist/arm-subscriptions.js in 234ms
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ea46c4d96b0d6c5e9586dbf6f6fa7e4e275d3fe0. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/subscription/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Subscription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionPolicies' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantIdDescription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CanceledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'RenamedSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'EnabledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasRequestProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /Alias/put/CreateAlias
      cmderr	[Autorest]     - name: /Alias/get/GetAlias
      cmderr	[Autorest]     - name: /Alias/get/GetAlias
      cmderr	[Autorest]     - name: /Alias/delete/DeleteAlias
      cmderr	[Autorest]     - name: /Subscriptions/get/getSubscription
      cmderr	[Autorest]     - name: /Subscriptions/get/listLocations
      cmderr	[Autorest]     - name: /Subscriptions/get/listSubscriptions
      cmderr	[Autorest]     - name: /Subscription/post/cancelSubscription
      cmderr	[Autorest]     - name: /Subscription/post/enableSubscription
      cmderr	[Autorest]     - name: /Subscription/post/renameSubscription
      cmderr	[Autorest]     - name: /Tenants/get/listTenants
      cmderr	[Autorest] --------------------------------------------------------
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ea46c4d96b0d6c5e9586dbf6f6fa7e4e275d3fe0. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️subscription [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @rajshah11
    Copy link
    Contributor Author

    The swagger was mostly reviewed and updated in this PR - #12551. However, we had to move it to a new version and make a few changes that this PR includes. Thanks!

    Updated alias name description
    Copy link
    Member

    @markcowl markcowl left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    What is your intention with this PR? The new spec you have created is not referenced from the readme file, so won't be used anywhere. Also, it is marked as a private preview, which means it likely should not be in the public repo.

    Finally, there are several breaking changes from the previous stable version, as shown by the ci checks. These would all need approval by the breakiing change board.

    Please respond on these issues before a review can proceed.

    specification/subscription/resource-manager/readme.md Outdated Show resolved Hide resolved
    @markcowl markcowl added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 13, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 13, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️❌LintDiff: 5 Errors, 26 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4009 - RequiredReadOnlySystemData The response of operation:'Subscriptions_CreateAlias' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L20
    R4009 - RequiredReadOnlySystemData The response of operation:'Subscriptions_GetAlias' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L66
    R4009 - RequiredReadOnlySystemData The response of operation:'SubscriptionPolicy_AddUpdatePolicyForTenant' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L633
    R4009 - RequiredReadOnlySystemData The response of operation:'SubscriptionPolicy_GetPolicyForTenant' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L669
    R4009 - RequiredReadOnlySystemData The response of operation:'BillingAccount_GetPolicy' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L732
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Subscriptions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L245
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Subscriptions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L305
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Subscriptions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L380
    ⚠️ R1005 - GetInOperationName 'GET' operation 'Subscription_AcceptOwnershipStatus' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L212
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'SubscriptionPolicy_AddUpdatePolicyForTenant' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L635


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L46
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L85
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L121
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L154
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L49
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L103
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L139
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L172
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L246
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L285
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/subscription/resource-manager/readme.md
    tag: specification/subscription/resource-manager/readme.md#tag-package-2020-09
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 22 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_Create' to 'Subscriptions_CreateAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L20:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L164:7
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_Get' to 'Subscriptions_GetAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L66:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L213:7
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_Delete' to 'Subscriptions_DeleteAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L97:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L247:7
    1008 - ModifiedOperationId The operation id has been changed from 'Alias_List' to 'Subscriptions_ListAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L130:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L283:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L783:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L320:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L783:7
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L320:7
    1034 - AddedRequiredProperty The new version has new required property 'displayName, workload, billingScope' that was not found in the old version.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L794:9
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L431:9
    1034 - AddedRequiredProperty The new version has new required property 'displayName, workload, billingScope' that was not found in the old version.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L800:5
    Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L437:5


    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateSubscriptionInEnrollmentAccount' to 'Subscriptions_CreateSubscriptionInEnrollmentAccount'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L243:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L20:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateSubscription' to 'Subscriptions_CreateSubscription'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L303:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L256:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateCspSubscription' to 'Subscriptions_CreateCspSubscription'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L378:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L330:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateAlias' to 'Subscriptions_CreateAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L20:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L397:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_GetAlias' to 'Subscriptions_GetAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L66:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L443:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_DeleteAlias' to 'Subscriptions_DeleteAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L97:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L474:7
    1008 - ModifiedOperationId The operation id has been changed from 'Subscription_ListAlias' to 'Subscriptions_ListAlias'. This will impact generated code.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L130:7
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L507:7
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L578:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L571:15
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L204:15
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Subscription/preview/2021-01-01-privatepreview/subscriptions.json#L326:15
    Old: Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json#L279:15
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2021-01-privatepreview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2021-01-privatepreview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2019-10-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"subscription/resource-manager/readme.md",
    "tag":"package-2019-10-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @rajshah11 rajshah11 force-pushed the shahraj/2021-subscriptions-api branch from bf15c40 to acc3a45 Compare May 19, 2021 18:33
    @rajshah11 rajshah11 requested a review from markcowl May 25, 2021 20:31
    @rajshah11
    Copy link
    Contributor Author

    The automatic checks failing are the following -
    Swagger LintDiff with "RequiredReadOnlySystemData" for which we want an exception for now
    The other failure is "Cross-Version Breaking Changes" which is expected

    @openapi-workflow-bot
    Copy link

    Hi @rajshah11, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @markcowl markcowl closed this May 26, 2021
    @markcowl
    Copy link
    Member

    Closing this pull request as the intention of the authors is not clear. It is not appropriate to check in a private preview api here, nor to name a version 'privatepreview'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants