Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for List File V2 #14385

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Added support for List File V2 #14385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8659a5f
Added support for List File V2
May 12, 2021
bef7e6d
PR comments
Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions specification/storage/data-plane/Microsoft.FileStorage/preview/2020-04-08/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,12 @@
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/ListFilesInclude"
},
{
"$ref": "#/parameters/ListFilesExtendedInfo"
}
],
"responses": {
Expand Down Expand Up @@ -5012,6 +5018,18 @@
"properties": {
"Name": {
"type": "string"
},
"FileId": {
"type": "string"
},
"Properties": {
"$ref": "#/definitions/FileProperty"
},
"Attributes": {
"type": "string"
},
"PermissionKey": {
"type": "string"
}
}
},
Expand All @@ -5029,8 +5047,17 @@
"Name": {
"type": "string"
},
"FileId": {
"type": "string"
},
"Properties": {
"$ref": "#/definitions/FileProperty"
},
"Attributes": {
"type": "string"
},
"PermissionKey": {
"type": "string"
}
}
},
Expand All @@ -5045,6 +5072,22 @@
"description": "Content length of the file. This value may not be up-to-date since an SMB client may have modified the file locally. The value of Content-Length may not reflect that fact until the handle is closed or the op-lock is broken. To retrieve current property values, call Get File Properties.",
"type": "integer",
"format": "int64"
},
"CreationTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"LastAccessTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"LastWriteTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"Etag": {
"type": "string",
"format": "etag"
}
}
},
Expand Down Expand Up @@ -6048,6 +6091,36 @@
"x-ms-parameter-location": "method",
"description": "Specifies the current lease ID on the resource."
},
"ListFilesInclude": {
"name": "include",
"in": "query",
"description": "Include this parameter to specify one or more datasets to include in the response.",
"required": false,
"type": "array",
"collectionFormat": "csv",
"items": {
"type": "string",
"enum": [
"Timestamps",
"Etag",
"Attributes",
"PermissionKey"
],
"x-ms-enum": {
"name": "ListFilesIncludeType",
"modelAsString": false
}
},
"x-ms-parameter-location": "method"
},
"ListFilesExtendedInfo": {
"name": "x-ms-file-extended-info",
"x-ms-client-name": "includeExtendedInfo",
"x-ms-parameter-location": "method",
"in": "header",
"type": "boolean",
"required": false
},
"ListSharesInclude": {
"name": "include",
"in": "query",
Expand Down
81 changes: 81 additions & 0 deletions specification/storage/data-plane/Microsoft.FileStorage/preview/2020-06-12/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,12 @@
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/ListFilesInclude"
},
{
"$ref": "#/parameters/ListFilesExtendedInfo"
}
],
"responses": {
Expand Down Expand Up @@ -5012,6 +5018,18 @@
"properties": {
"Name": {
"type": "string"
},
"FileId": {
"type": "string"
},
"Properties": {
"$ref": "#/definitions/FileProperty"
},
"Attributes": {
"type": "string"
},
"PermissionKey": {
"type": "string"
}
}
},
Expand All @@ -5029,8 +5047,17 @@
"Name": {
"type": "string"
},
"FileId": {
"type": "string"
},
"Properties": {
"$ref": "#/definitions/FileProperty"
},
"Attributes": {
"type": "string"
},
"PermissionKey": {
"type": "string"
}
}
},
Expand All @@ -5045,6 +5072,30 @@
"description": "Content length of the file. This value may not be up-to-date since an SMB client may have modified the file locally. The value of Content-Length may not reflect that fact until the handle is closed or the op-lock is broken. To retrieve current property values, call Get File Properties.",
"type": "integer",
"format": "int64"
},
"CreationTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"LastAccessTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"LastWriteTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"ChangeTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"Last-Modified": {
"type": "string",
"format": "date-time-rfc1123"
},
"Etag": {
"type": "string",
"format": "etag"
}
}
},
Expand Down Expand Up @@ -6048,6 +6099,36 @@
"x-ms-parameter-location": "method",
"description": "Specifies the current lease ID on the resource."
},
"ListFilesInclude": {
"name": "include",
"in": "query",
"description": "Include this parameter to specify one or more datasets to include in the response.",
"required": false,
"type": "array",
"collectionFormat": "csv",
"items": {
"type": "string",
"enum": [
"Timestamps",
"Etag",
"Attributes",
"PermissionKey"
],
"x-ms-enum": {
"name": "ListFilesIncludeType",
"modelAsString": false
}
},
"x-ms-parameter-location": "method"
},
"ListFilesExtendedInfo": {
"name": "x-ms-file-extended-info",
"x-ms-client-name": "includeExtendedInfo",
"x-ms-parameter-location": "method",
"in": "header",
"type": "boolean",
"required": false
},
"ListSharesInclude": {
"name": "include",
"in": "query",
Expand Down
84 changes: 84 additions & 0 deletions specification/storage/data-plane/Microsoft.FileStorage/preview/2020-10-02/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,12 @@
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/ListFilesInclude"
},
{
"$ref": "#/parameters/ListFilesExtendedInfo"
}
],
"responses": {
Expand Down Expand Up @@ -5012,6 +5018,18 @@
"properties": {
"Name": {
"type": "string"
},
"FileId": {
"type": "string"
},
"Properties": {
"$ref": "#/definitions/FileProperty"
},
"Attributes": {
"type": "string"
},
"PermissionKey": {
"type": "string"
}
}
},
Expand All @@ -5029,8 +5047,17 @@
"Name": {
"type": "string"
},
"FileId": {
"type": "string"
},
"Properties": {
"$ref": "#/definitions/FileProperty"
},
"Attributes": {
"type": "string"
},
"PermissionKey": {
"type": "string"
}
}
},
Expand All @@ -5045,6 +5072,30 @@
"description": "Content length of the file. This value may not be up-to-date since an SMB client may have modified the file locally. The value of Content-Length may not reflect that fact until the handle is closed or the op-lock is broken. To retrieve current property values, call Get File Properties.",
"type": "integer",
"format": "int64"
},
"CreationTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"LastAccessTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"LastWriteTime": {
"type": "string",
"format": "date-time-rfc1123"
},
"ChangeTime": {
"type": "string",
"format": "date-time-rfc1123"
},
Copy link
Contributor

@xiafu-msft xiafu-msft Jun 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these all should be iso-8601 except last-modified should be rfc-1123

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gapra-msft, is this an issue in Java?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jaschrep-msft had to add a manual transform, he can confirm but I think yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is how iso-8601 is generated in blob swagger
https://github.com/Azure/azure-rest-api-specs/blob/storage-dataplane-preview/specification/storage/data-plane/Microsoft.BlobStorage/preview/2020-10-02/blob.json#L10108

"Last-Modified": {
"type": "string",
"format": "date-time-rfc1123"
},
"Etag": {
"type": "string",
"format": "etag"
}
}
},
Expand Down Expand Up @@ -5200,6 +5251,9 @@
},
"NextMarker": {
"type": "string"
},
"DirectoryId": {
"type": "string"
}
}
},
Expand Down Expand Up @@ -6048,6 +6102,36 @@
"x-ms-parameter-location": "method",
"description": "Specifies the current lease ID on the resource."
},
"ListFilesInclude": {
"name": "include",
"in": "query",
"description": "Include this parameter to specify one or more datasets to include in the response.",
"required": false,
"type": "array",
"collectionFormat": "csv",
"items": {
"type": "string",
"enum": [
"Timestamps",
"Etag",
"Attributes",
"PermissionKey"
],
"x-ms-enum": {
"name": "ListFilesIncludeType",
"modelAsString": false
}
},
"x-ms-parameter-location": "method"
},
"ListFilesExtendedInfo": {
"name": "x-ms-file-extended-info",
"x-ms-client-name": "includeExtendedInfo",
"x-ms-parameter-location": "method",
"in": "header",
"type": "boolean",
"required": false
},
"ListSharesInclude": {
"name": "include",
"in": "query",
Expand Down