[NetAppFiles] Anf-12396 NetApp Files add api version 2021-04-01 part2 #14365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: coolAccess Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3423 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: coolAccess Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3816 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: healthy Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L5165 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response of operation:'Pools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L493 |
|
The response of operation:'Volumes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L744 |
|
The response of operation:'Snapshots_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L1448 |
|
The response of operation:'SnapshotPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L1736 |
|
The response of operation:'AccountBackups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2054 |
|
The response of operation:'Backups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2194 |
|
The response of operation:'BackupPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2474 |
|
The response of operation:'Pools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L534 |
|
The response of operation:'Volumes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L788 |
|
The response of operation:'Snapshots_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-04-01/netapp.json#L1495 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 114 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2021-04-01/netapp.json compared with base:preview/2021-04-01-preview/netapp.json
- current:stable/2021-04-01/netapp.json compared with base:stable/2021-02-01/netapp.json
Only 10 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
"tag":"package-netapp-2021-04-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
"tag":"package-netapp-2021-04-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
"tag":"package-netapp-2021-04-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @leni-msft |
This was referenced May 11, 2021
This was referenced May 11, 2021
|
@ArcturusZhang Not sure what is causting .net SDK step to fail. |
|
dot net CI failure should be a known issue, please just ignore it. The cross-version breaking changes looks like a false alarm, but is it possible that we switch to use the api-version parameter in common-types? CC @jianyexi |
@ArcturusZhang So if we switch to common type the warning goes away. I think we should try that to get rid of it. |
This was referenced Jun 8, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 8, 2021
…on 2021-04-01 part2 (#1746) Create to sync Azure/azure-rest-api-specs#14365 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/netapp?expand=1)
This was referenced Jun 8, 2021
26 tasks
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
…Azure#14365) * Initial commit * Apply 2021-04-01 changes * pretty * spellcheck add Tebibytes * Use ApiVersionParameter from common types * Use ApiVersionParameter from common types * Change apivesion paramter in correct version * Revert apiversion change * Remove getQuotaLimits * Remove preview from path * Fix example in 2021-02-01 * Update operation id for restore status op Co-authored-by: Audunn Baldvinsson <[email protected]>
11 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…Azure#14365) * Initial commit * Apply 2021-04-01 changes * pretty * spellcheck add Tebibytes * Use ApiVersionParameter from common types * Use ApiVersionParameter from common types * Change apivesion paramter in correct version * Revert apiversion change * Remove getQuotaLimits * Remove preview from path * Fix example in 2021-02-01 * Update operation id for restore status op Co-authored-by: Audunn Baldvinsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.