-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schedule api #14360
Merged
ArcturusZhang
merged 92 commits into
Azure:master
from
SubaMoorthy:sukaruna/mar-preview-schedules
May 18, 2021
Merged
Add schedule api #14360
Changes from 91 commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
8dbb48b
Add Identity to createWorkpace example
zhaomuzhi 9cba54d
Merge branch 'master' of https://github.com/zhaomuzhi/azure-rest-api-…
zhaomuzhi b5e4863
Merge remote-tracking branch 'upstream/master'
zhaomuzhi 02a2401
Merge remote-tracking branch 'upstream/master'
zhaomuzhi f2ceaf1
Merge remote-tracking branch 'upstream/master'
zhaomuzhi a6591d5
Merge remote-tracking branch 'upstream/master'
zhaomuzhi 84ec88f
Merge remote-tracking branch 'upstream/master'
zhaomuzhi ac5afcb
change for getTransitivePEUsages
zhaomuzhi bf923f0
update
zhaomuzhi 2ab304a
prettier code
zhaomuzhi e4a5d19
add another new endpoint
zhaomuzhi 8f20ad7
address comments
zhaomuzhi 5eee086
change for getTransitivePEUsages
zhaomuzhi a34a194
update
zhaomuzhi 0a23a85
prettier code
zhaomuzhi b87f8e9
add another new endpoint
zhaomuzhi 7c91175
address comments
zhaomuzhi 0696b9e
revert change on transitivePE and notebookKeys
zhaomuzhi 2981eb3
Merge branch 'master' of https://github.com/zhaomuzhi/azure-rest-api-…
zhaomuzhi 072a51f
revert change on transitivePE and notebookKeys
zhaomuzhi 3b010c7
Merge remote-tracking branch 'upstream/master'
zhaomuzhi c40a15e
Merge remote-tracking branch 'upstream/master'
zhaomuzhi 1d693a7
add new stable version 2021-01-01
zhaomuzhi 0bc494b
add ListNotebookAccessToken
zhaomuzhi a85c418
add primaryUserAssignedIdentity
zhaomuzhi e13ea29
fix missing properties and apis
zhaomuzhi 8e6ddf9
fix one more missing property
zhaomuzhi 1df7b8e
Merge remote-tracking branch 'upstream/master'
zhaomuzhi 584fd07
202 status for start and stop CI
VinayRSoni 7e30ce1
Merge pull request #8 from zhaomuzhi/vison/202startstopCI
zhaomuzhi 847d562
Merge remote-tracking branch 'upstream/master'
zhaomuzhi ed0fbb9
make resync keys long runnin operation in version Jan2021
SubaMoorthy d57e01a
resync keys 204
SubaMoorthy a6e57f1
update resync keys example
SubaMoorthy 817df44
Dont throw 204 for resync
SubaMoorthy da352f8
update resync keys
SubaMoorthy aa050c6
Formatting
SubaMoorthy f419400
revert Jan2021changes and add new version
SubaMoorthy f4e883e
start apr2021 version for azure ml rp
SubaMoorthy d346094
undo remove new line in jan2021
SubaMoorthy 4a8cd59
Merge branch 'master' of https://github.com/SubaMoorthy/sukaruna-aml-…
zhaomuzhi 5369992
use systemData definition in common
zhaomuzhi 63d49cf
removed old files
zhaomuzhi 36d6366
Merge pull request #3 from SubaMoorthy/referenceCommonSystemData
zhaomuzhi 2818e5f
fix small swagger bugs
SubaMoorthy 7daf6ea
Merge pull request #4 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy 45a3c2b
run prettier
SubaMoorthy 8d43278
Merge pull request #6 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy 97107b4
remove reference to sku
SubaMoorthy c24b611
Merge pull request #7 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy aaadda3
update readme
SubaMoorthy c411877
Merge pull request #8 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy 6fe7c50
minimum agentCount should be 0
a1ac282
add createdOn and ModifiedOn to compute properties
c8bbd9c
add LoadBalancerType to aks compute
2cc4a86
add isNotebookInstanceCompute to virtualMachine
8335e68
add leafDomainLabel to SslConfiguration
0a9921d
add overwriteExistingDomain to SslConfiguration
4344156
add synapseSpark as supported compute-type
db23cf1
update patch compute response to 202
048bf25
remove location from example responses
0088b8c
Revert "remove location from example responses"
83b9be3
Merge pull request #9 from SubaMoorthy/jopet/mlc-swagger-fixes
joshanator 973ae5a
MachineLearningCompute_Update should have a 200 response
cb6d9c8
sys data to use local def due to naming conflicts.
SubaMoorthy fb9d2b1
Merge pull request #10 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy c5bd245
Fix enum casing
SubaMoorthy c0959d0
Merge pull request #11 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy 3bfe3f8
Fix operationId PR comment.
SubaMoorthy 373f8bc
Merge pull request #12 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy fc946f1
Change opId in apr version
SubaMoorthy 64257b3
Merge pull request #13 from SubaMoorthy/fix-swagger-kpi-bugs
SubaMoorthy 06b8f2d
remove 20210401 for easy review
SubaMoorthy 1222658
only change api version
SubaMoorthy df1a995
merge changes for 20210401 version
SubaMoorthy 3da36b8
Add x-ms-discriminator-value for Synapse spark
1d4b80d
camelcase loadbalancer properties
cbeffca
add createdOn and Modified on to examples
235a15e
address AvoidAnonymousTypes error for SynapseSpark
d45216f
Minor fixes + new property
SubaMoorthy 79f3834
Remove subscription state.
SubaMoorthy fdafe9c
Merge branch 'Azure:master' into master
SubaMoorthy af18145
Merge branch 'Azure:master' into master
SubaMoorthy 30b8066
add schedules api
SubaMoorthy c1633c2
Add schedule examples
SubaMoorthy 26b4291
case formatting
SubaMoorthy ca1dd5a
Cron example for ci create
SubaMoorthy 4ad7711
Prettier check and model validation
SubaMoorthy 548f421
renaming property
SubaMoorthy d7f5365
Address comments
SubaMoorthy 0583ede
Give a stop example
SubaMoorthy cb4ecb1
Fix time format.
SubaMoorthy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
73 changes: 73 additions & 0 deletions
73
...view/2021-03-01-preview/examples/Compute/createOrUpdate/ComputeInstanceWithSchedules.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
{ | ||
"parameters": { | ||
"subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
"resourceGroupName": "testrg123", | ||
"workspaceName": "workspaces123", | ||
"computeName": "compute123", | ||
"api-version": "2021-03-01-preview", | ||
"parameters": { | ||
"location": "eastus", | ||
"properties": { | ||
"computeType": "ComputeInstance", | ||
"properties": { | ||
"vmSize": "STANDARD_NC6", | ||
"subnet": "test-subnet-resource-id", | ||
"applicationSharingPolicy": "Personal", | ||
"sshSettings": { | ||
"sshPublicAccess": "Disabled" | ||
}, | ||
"computeInstanceAuthorizationType": "personal", | ||
"personalComputeInstanceSettings": { | ||
"assignedUser": { | ||
"objectId": "00000000-0000-0000-0000-000000000000", | ||
"tenantId": "00000000-0000-0000-0000-000000000000" | ||
} | ||
}, | ||
"schedules": { | ||
"computeStartStop": [ | ||
{ | ||
"status": "Enabled", | ||
"action": "Stop", | ||
"triggerType": "Cron", | ||
"cron": { | ||
"expression": "0 18 * * *", | ||
"startTime": "2021-04-23T1:30:00", | ||
"timeZone": "Pacific Standard Time" | ||
} | ||
SubaMoorthy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
] | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
"responses": { | ||
"200": { | ||
"body": { | ||
"id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/testrg123/providers/Microsoft.MachineLearningServices/workspaces/workspaces123/computes/compute123", | ||
"type": "Microsoft.MachineLearningServices/workspaces/computes", | ||
"name": "compute123", | ||
"location": "eastus", | ||
"properties": { | ||
"computeType": "ComputeInstance", | ||
"provisioningState": "Creating" | ||
} | ||
} | ||
}, | ||
"201": { | ||
"body": { | ||
"id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/testrg123/providers/Microsoft.MachineLearningServices/workspaces/workspaces123/computes/compute123", | ||
"type": "Microsoft.MachineLearningServices/workspaces/computes", | ||
"name": "compute123", | ||
"location": "eastus", | ||
"properties": { | ||
"computeType": "ComputeInstance", | ||
"provisioningState": "Creating" | ||
} | ||
}, | ||
"headers": { | ||
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/...pathToOperationStatus..." | ||
} | ||
} | ||
} | ||
} |
36 changes: 36 additions & 0 deletions
36
....MachineLearningServices/preview/2021-03-01-preview/examples/Compute/updateSchedules.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
{ | ||
"parameters": { | ||
"subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
"resourceGroupName": "testrg123", | ||
"workspaceName": "workspaces123", | ||
"computeName": "compute123", | ||
"api-version": "2021-03-01-preview", | ||
"parameters": { | ||
"computeStartStop": [ | ||
{ | ||
"status": "Enabled", | ||
"action": "Start", | ||
"triggerType": "Recurrence", | ||
"recurrence": { | ||
"frequency": "Day", | ||
"interval": 1, | ||
"startTime": "2021-04-23T1:30:00", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe 2021-04-23T1:30:00 is not valid, it has to be 2021-04-23T01:30:00 |
||
"timeZone": "Pacific Standard Time", | ||
"schedule": { | ||
"hours": [ | ||
18 | ||
], | ||
"minutes": [ | ||
30 | ||
], | ||
"weekDays": null | ||
} | ||
SubaMoorthy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
] | ||
} | ||
}, | ||
"responses": { | ||
"200": {} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, not valid