Add swagger for OutboundNetworkDependenciesEndpoints for AKS #14332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @gossion Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L2494 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L2564 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3119 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3309 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3404 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3445 |
|
Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3479 |
|
Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L3779 |
|
The response of operation:'ManagedClusters_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L418 |
|
The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-05-01/managedClusters.json#L896 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross Version BreakingChange (Base on preview version): 32 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- original: preview/2018-08-01-preview/managedClusters.json <---> new: stable/2021-05-01/managedClusters.json
Only 10 items are listed, please refer to log for more details.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2021-03-01/managedClusters.json <---> new: stable/2021-05-01/managedClusters.json
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @gossion your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ |
|
Hi @gossion, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
This was referenced May 10, 2021
|
I have no idea why it failed at Cross Version BreakingChange & SDK azure-sdk-for-net . @PhoenixHe-msft do you have any suggestion? |
feiskyer
approved these changes
May 10, 2021
|
@gossion For these two failures you could ignore. Now you need to wait for arm review. |
pilor
reviewed
May 10, 2021
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-05-01/managedClusters.json
Show resolved
Hide resolved
pilor
added
ARMChangesRequested
pilor
added
ARMSignedOff
PhoenixHe-NV
approved these changes
May 12, 2021
PhoenixHe-NV
merged commit 82085c4
into
Azure:dev-containerservice-Microsoft.ContainerService-2021-05-01
26 tasks
zhenglaizhang
pushed a commit
that referenced
this pull request
Jun 2, 2021
…ble/2021-05-01 (#14147) * Adds base for updating Microsoft.ContainerService from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 (#14149) * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 api * ref example Co-authored-by: Li Ma <[email protected]> * Add swagger for OutboundNetworkDependenciesEndpoints for AKS (#14332) * Add swagger for OutboundNetworkDependenciesEndpoints for AKS * fix * lint * update operationId * aks: add enableUltraSSD in v20210501 api-version (#14354) * update doc for agentpool max count from 100 to 1000 (#14553) Co-authored-by: Li Ma <[email protected]> * add readme for new version (#14611) Co-authored-by: Li Ma <[email protected]> * fix conflict (#14614) Co-authored-by: Li Ma <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: gossion <[email protected]> Co-authored-by: Andy Zhang <[email protected]>
26 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…ble/2021-05-01 (Azure#14147) * Adds base for updating Microsoft.ContainerService from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 (Azure#14149) * add APIServerAccessProfile.enablePrivateClusterPublicFQDN in 2021-05-01 api * ref example Co-authored-by: Li Ma <[email protected]> * Add swagger for OutboundNetworkDependenciesEndpoints for AKS (Azure#14332) * Add swagger for OutboundNetworkDependenciesEndpoints for AKS * fix * lint * update operationId * aks: add enableUltraSSD in v20210501 api-version (Azure#14354) * update doc for agentpool max count from 100 to 1000 (Azure#14553) Co-authored-by: Li Ma <[email protected]> * add readme for new version (Azure#14611) Co-authored-by: Li Ma <[email protected]> * fix conflict (Azure#14614) Co-authored-by: Li Ma <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: gossion <[email protected]> Co-authored-by: Andy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
May
May
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.