[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-02-01 #14257

joshdmcc · 2021-05-05T20:50:23Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

… stable/2021-01-01 to version 2021-02-01

openapi-pipeline-app · 2021-05-05T20:50:26Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- imds/data-plane/readme.md tag:package-2021-02-01
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- imds/data-plane/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2021-02-01/imds.json compared with base:stable/2021-01-01/imds.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2018-10-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2018-10-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2021-02-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2021-02-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2018-10-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-02-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-02-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-03-11",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-03-11",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-04-30",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-04-30",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-06-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-06-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"imds/data-plane/readme.md",
"tag":"package-2019-06-04",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-05T20:50:26Z

Hi, @joshdmcc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-05-05T20:50:27Z

Swagger Generation Artifacts

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=219099&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 260d292. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-imds [View full logs] [Release SDK Changes]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 260d292. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-02 15:08:35 ERROR [Skip] readme path does not format as specification/*/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs]Release - Generate from 260d292. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: sh ./initScript.sh
warn	File azure-sdk-for-go_tmp/initOutput.json not found to read
command	go run ./tools/generator/main.go automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go automation
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 260d292. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/imds/data-plane/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-05T20:50:27Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2021-05-05T20:52:09Z

Hi @joshdmcc, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

jhendrixMSFT · 2021-05-27T17:58:20Z

@joshdmcc has this been reviewed by the API board?

JeffreyRichter · 2021-05-28T21:32:22Z

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2021-02-01/imds.json

+          "description": "This contains data for the size of local temp disk of the VM, if it exists.",
+          "properties": {
+            "size": {
+              "type": "string",


Why isn't this an integer?

We return all numbers as strings representations.

…to add version stable/2021-02-01 (Azure#14257) * Adds base for updating Microsoft.InstanceMetadataService from version stable/2021-01-01 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * Adding swagger for imds version 2021-02-01 * Adding new blob * Fixing * Spacing * Prettier Co-authored-by: jmccarthy <[email protected]>

joshdmcc and others added 4 commits May 5, 2021 16:15

Adds base for updating Microsoft.InstanceMetadataService from version…

992c512

… stable/2021-01-01 to version 2021-02-01

Updates readme

2e1c9bb

Updates API version in new specs and examples

82cc10a

Adding swagger for imds version 2021-02-01

e73e256

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label May 5, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label May 5, 2021

openapi-sdkautomation bot mentioned this pull request May 5, 2021

[AutoPR azure-imds] [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-02-01 AzureSDKAutomation/azure-sdk-for-python#5456

Closed

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label May 5, 2021

Adding new blob

eab66a8

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels May 6, 2021

Fixing

7fc1c11

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels May 6, 2021

joshdmcc marked this pull request as ready for review May 26, 2021 19:33

openapi-assignment-bot bot assigned jhendrixMSFT May 26, 2021

jmccarthy added 2 commits May 26, 2021 16:20

Spacing

727efc7

Prettier

a9d57c4

JeffreyRichter reviewed May 28, 2021

View reviewed changes

joshdmcc requested a review from JeffreyRichter June 1, 2021 14:53

JeffreyRichter approved these changes Jun 2, 2021

View reviewed changes

jhendrixMSFT approved these changes Jun 2, 2021

View reviewed changes

jhendrixMSFT merged commit 260d292 into Azure:master Jun 2, 2021

openapi-sdkautomation bot mentioned this pull request Jun 2, 2021

[ReleasePR azure-imds] Add IMDS version 2021-10-01 for platformSubFaultDomain field Azure/azure-sdk-for-python#16819

Closed

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-02-01 #14257

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-02-01 #14257

joshdmcc commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

openapi-workflow-bot bot commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 5, 2021

openapi-workflow-bot bot commented May 5, 2021

jhendrixMSFT commented May 27, 2021

JeffreyRichter May 28, 2021

joshdmcc May 31, 2021

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-02-01 #14257

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-02-01 #14257

Conversation

joshdmcc commented May 5, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented May 5, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 5, 2021

openapi-workflow-bot bot commented May 5, 2021

jhendrixMSFT commented May 27, 2021

JeffreyRichter May 28, 2021

Choose a reason for hiding this comment

joshdmcc May 31, 2021

Choose a reason for hiding this comment

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading