New Microsoft.Security proxy rp type of ingestionSettings #14226

kunchawla · 2021-05-04T05:12:51Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Corresponding PR in private repo for the private preview - https://github.com/Azure/azure-rest-api-specs-pr/pull/2446

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- [X ] new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
Already Deployed
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
May-June'2021
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-05-04T05:12:55Z

Hi, @kunchawla Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-05-04T05:12:56Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 6 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- security/resource-manager/readme.md tag:package-composite-v3
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- security/resource-manager/readme.md tag:package-composite-v3

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'aggregatedAlerts' with immediate parent 'IoTSecuritySolutionModel', must have a list by immediate parent operation. Location: Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json#L271
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'aggregatedRecommendations' with immediate parent 'IoTSecuritySolutionModel', must have a list by immediate parent operation. Location: Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json#L271
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'iotAlertTypes' with immediate parent 'IoTSecuritySolutionModel', must have a list by immediate parent operation. Location: Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json#L271
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'iotAlerts' with immediate parent 'IoTSecuritySolutionModel', must have a list by immediate parent operation. Location: Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json#L271
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'iotRecommendationTypes' with immediate parent 'IoTSecuritySolutionModel', must have a list by immediate parent operation. Location: Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json#L271
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'iotRecommendations' with immediate parent 'IoTSecuritySolutionModel', must have a list by immediate parent operation. Location: Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json#L271

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Security/locations/{ascLocation}/ExternalSecuritySolutions' Location: Microsoft.Security/stable/2020-01-01/externalSecuritySolutions.json#L76
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/locations/{ascLocation}/ExternalSecuritySolutions/{externalSecuritySolutionsName}' Location: Microsoft.Security/stable/2020-01-01/externalSecuritySolutions.json#L118
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2017-08-01-preview/securityContacts.json#L185
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2017-08-01-preview/workspaceSettings.json#L216
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/automations.json#L239
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/stable/2020-01-01/assessmentMetadata.json#L248
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2017-08-01-preview/compliances.json#L163
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L371
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L376

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail]

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"security/resource-manager/readme.md",
"tag":"package-composite-v1",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"security/resource-manager/readme.md",
"tag":"package-composite-v1",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"security/resource-manager/readme.md",
"tag":"package-2021-01-preview-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"security/resource-manager/readme.md",
"tag":"package-2021-01-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` AutorestCore/Exception	"readme":"security/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Error: Semantic validation failed. There was some errors"
`❌` AutorestCore/Exception	"readme":"security/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Error: Semantic validation failed. There was some errors"
`❌` PreCheck/DuplicateSchema	"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Duplicate Schema named ExternalSecuritySolutionKind -- type: undefined => "string", properties: "kind":"$ref":"#/components/schemas/ExternalSecuritySolutionKind", "description":"The kind of the external solution" =>, enum: undefined => ["CEF", "ATA", "AAD"], x-ms-enum: undefined => "name":"ExternalSecuritySolutionKind", "modelAsString":true, "values":["value":"CEF", "value":"ATA", "value":"AAD"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Duplicate Schema named AadConnectivityState -- type: undefined => "string", properties: "connectivityState":"$ref":"#/components/schemas/AadConnectivityState" =>, title: undefined => "The connectivity state of the external AAD solution ", enum: undefined => ["Discovered", "NotLicensed", "Connected"], x-ms-enum: undefined => "name":"AadConnectivityState", "modelAsString":true, "values":["value":"Discovered", "value":"NotLicensed", "value":"Connected"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Error: Plugin prechecker reported failure."
`❌` AutorestCore/Exception	"readme":"security/resource-manager/readme.md", "tag":"package-2015-06-preview-only", "details":"Error: Semantic validation failed. There was some errors"
`❌` PreCheck/DuplicateSchema	"readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"Duplicate Schema named ExternalSecuritySolutionKind -- type: undefined => "string", properties: "kind":"$ref":"#/components/schemas/ExternalSecuritySolutionKind", "description":"The kind of the external solution" =>, enum: undefined => ["CEF", "ATA", "AAD"], x-ms-enum: undefined => "name":"ExternalSecuritySolutionKind", "modelAsString":true, "values":["value":"CEF", "value":"ATA", "value":"AAD"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"Duplicate Schema named AadConnectivityState -- type: undefined => "string", properties: "connectivityState":"$ref":"#/components/schemas/AadConnectivityState" =>, title: undefined => "The connectivity state of the external AAD solution ", enum: undefined => ["Discovered", "NotLicensed", "Connected"], x-ms-enum: undefined => "name":"AadConnectivityState", "modelAsString":true, "values":["value":"Discovered", "value":"NotLicensed", "value":"Connected"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"Error: Plugin prechecker reported failure."
💬 AutorestCore/Exception	"readme":"security/resource-manager/readme.md", "tag":"package-composite-v1", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-04T05:12:56Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-04T05:12:57Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f3f9da. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/security/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityCenter [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.2.2.0.nupkg
- Microsoft.Azure.Management.SecurityCenter.2.2.0.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f3f9da. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/security/mgmt/v3.0/security [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `IngestionSettingsClient.List(context.Context) (IngestionSettingListPage, error)`
info	[Changelog] - New function `NewIngestionSettingListPage(IngestionSettingList, func(context.Context, IngestionSettingList) (IngestionSettingList, error)) IngestionSettingListPage`
info	[Changelog] - New function `IngestionSettingListIterator.Response() IngestionSettingList`
info	[Changelog] - New function `IngestionSettingListIterator.NotDone() bool`
info	[Changelog] - New function `IngestionSettingsClient.ListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `MqttD2CMessagesNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New struct `AdditionalWorkspacesProperties`
info	[Changelog] - New struct `AlertSimulatorBundlesRequestProperties`
info	[Changelog] - New struct `AlertSimulatorRequestBody`
info	[Changelog] - New struct `AlertSimulatorRequestProperties`
info	[Changelog] - New struct `AlertsSimulateFuture`
info	[Changelog] - New struct `ConnectionFromIPNotAllowed`
info	[Changelog] - New struct `ConnectionStrings`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `IngestionConnectionString`
info	[Changelog] - New struct `IngestionSetting`
info	[Changelog] - New struct `IngestionSettingList`
info	[Changelog] - New struct `IngestionSettingListIterator`
info	[Changelog] - New struct `IngestionSettingListPage`
info	[Changelog] - New struct `IngestionSettingToken`
info	[Changelog] - New struct `IngestionSettingsClient`
info	[Changelog] - New struct `ServerVulnerabilityAssessmentDeleteFuture`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `Categories` in struct `AssessmentMetadataProperties`
info	[Changelog] - New field `OnboardingKind` in struct `IotDefenderSettingsProperties`
info	[Changelog] - New field `Details` in struct `CloudErrorBody`
info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
info	[Changelog] - New field `Target` in struct `CloudErrorBody`
info	[Changelog] - New field `SystemData` in struct `IoTSecuritySolutionModel`
info	[Changelog] - New field `Type` in struct `IotAlert`
info	[Changelog] - New field `ID` in struct `IotAlert`
info	[Changelog] - New field `Name` in struct `IotAlert`
info	[Changelog] - New field `AdditionalWorkspaces` in struct `IoTSecuritySolutionProperties`
info	[Changelog] - New field `Type` in struct `IotAlertModel`
info	[Changelog] - New field `ID` in struct `IotAlertModel`
info	[Changelog] - New field `Name` in struct `IotAlertModel`
info	[Changelog] - New field `SensorType` in struct `IotSensorProperties`
info	[Changelog]
info	[Changelog] Total 57 breaking change(s), 233 additive change(s).
info	[Changelog]

️✔️preview/security/mgmt/v2.0/security [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `PossibleKindEnum1Values() []KindEnum1`
info	[Changelog] - New function `*IngestionSettingListPage.Next() error`
info	[Changelog] - New function `IngestionSettingList.IsEmpty() bool`
info	[Changelog] - New function `IngestionSettingsClient.ListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `NewIngestionSettingsClient(string, string) IngestionSettingsClient`
info	[Changelog] - New function `Setting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New function `IngestionSettingListPage.Values() []IngestionSetting`
info	[Changelog] - New function `NewIngestionSettingListIterator(IngestionSettingListPage) IngestionSettingListIterator`
info	[Changelog] - New function `NewIngestionSettingListPage(IngestionSettingList, func(context.Context, IngestionSettingList) (IngestionSettingList, error)) IngestionSettingListPage`
info	[Changelog] - New function `IngestionSettingsClient.List(context.Context) (IngestionSettingListPage, error)`
info	[Changelog] - New function `IngestionSettingsClient.ListComplete(context.Context) (IngestionSettingListIterator, error)`
info	[Changelog] - New function `IngestionSettingsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*IngestionSettingListPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `IngestionSettingsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New function `IngestionSettingsClient.ListConnectionStringsPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `*IngestionSettingListIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `IngestionSettingsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `DataExportSetting.AsSetting() (*Setting, bool)`
info	[Changelog] - New function `IngestionSettingsClient.ListTokensResponder(*http.Response) (IngestionSettingToken, error)`
info	[Changelog] - New function `*SettingModel.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IngestionSettingListIterator.NotDone() bool`
info	[Changelog] - New function `IngestionSettingListIterator.Response() IngestionSettingList`
info	[Changelog] - New function `IngestionSettingListPage.Response() IngestionSettingList`
info	[Changelog] - New struct `ConnectionStrings`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `IngestionConnectionString`
info	[Changelog] - New struct `IngestionSetting`
info	[Changelog] - New struct `IngestionSettingList`
info	[Changelog] - New struct `IngestionSettingListIterator`
info	[Changelog] - New struct `IngestionSettingListPage`
info	[Changelog] - New struct `IngestionSettingToken`
info	[Changelog] - New struct `IngestionSettingsClient`
info	[Changelog] - New struct `SettingModel`
info	[Changelog] - New field `Target` in struct `CloudErrorBody`
info	[Changelog] - New field `Details` in struct `CloudErrorBody`
info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
info	[Changelog]
info	[Changelog] Total 29 breaking change(s), 83 additive change(s).
info	[Changelog]

️✔️preview/security/mgmt/v1.0/security [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `*IngestionSettingListPage.Next() error`
info	[Changelog] - New function `IngestionSettingsClient.GetResponder(*http.Response) (IngestionSetting, error)`
info	[Changelog] - New function `IngestionSettingsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `IngestionSettingsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `IngestionSettingListPage.NotDone() bool`
info	[Changelog] - New function `IngestionSettingsClient.GetPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `Setting.AsBasicSetting() (BasicSetting, bool)`
info	[Changelog] - New function `DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New function `*SettingsList.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IngestionSettingsClient.ListTokens(context.Context, string) (IngestionSettingToken, error)`
info	[Changelog] - New function `DataExportSetting.AsBasicSetting() (BasicSetting, bool)`
info	[Changelog] - New function `IngestionSettingsClient.ListConnectionStringsResponder(*http.Response) (ConnectionStrings, error)`
info	[Changelog] - New function `IngestionSettingsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `IngestionSettingsClient.Create(context.Context, string, IngestionSetting) (IngestionSetting, error)`
info	[Changelog] - New function `IngestionSettingsClient.ListResponder(*http.Response) (IngestionSettingList, error)`
info	[Changelog] - New function `IngestionSettingsClient.CreateResponder(*http.Response) (IngestionSetting, error)`
info	[Changelog] - New function `Setting.AsSetting() (*Setting, bool)`
info	[Changelog] - New function `DataExportSetting.AsSetting() (*Setting, bool)`
info	[Changelog] - New function `IngestionSettingsClient.ListTokensSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*SettingModel.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IngestionSetting.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IngestionSettingsClient.List(context.Context) (IngestionSettingListPage, error)`
info	[Changelog] - New function `NewIngestionSettingListPage(IngestionSettingList, func(context.Context, IngestionSettingList) (IngestionSettingList, error)) IngestionSettingListPage`
info	[Changelog] - New function `IngestionSettingsClient.CreatePreparer(context.Context, string, IngestionSetting) (*http.Request, error)`
info	[Changelog] - New struct `ConnectionStrings`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `IngestionConnectionString`
info	[Changelog] - New struct `IngestionSetting`
info	[Changelog] - New struct `IngestionSettingList`
info	[Changelog] - New struct `IngestionSettingListIterator`
info	[Changelog] - New struct `IngestionSettingListPage`
info	[Changelog] - New struct `IngestionSettingToken`
info	[Changelog] - New struct `IngestionSettingsClient`
info	[Changelog] - New struct `SettingModel`
info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
info	[Changelog] - New field `Target` in struct `CloudErrorBody`
info	[Changelog] - New field `Details` in struct `CloudErrorBody`
info	[Changelog]
info	[Changelog] Total 29 breaking change(s), 83 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 2f3f9da. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-security [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model SecurityAssessmentMetadataProperties has a new parameter categories
info	[Changelog]   - Model IotAlert has a new parameter type
info	[Changelog]   - Model IotAlert has a new parameter name
info	[Changelog]   - Model IotAlert has a new parameter id
info	[Changelog]   - Model PackageDownloads has a new parameter device_information_update_import_template
info	[Changelog]   - Model PackageDownloads has a new parameter snmp
info	[Changelog]   - Model PackageDownloads has a new parameter authorized_devices_import_template
info	[Changelog]   - Model PackageDownloads has a new parameter wmi_tool
info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter additional_workspaces
info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter system_data
info	[Changelog]   - Model IotAlertModel has a new parameter type
info	[Changelog]   - Model IotAlertModel has a new parameter name
info	[Changelog]   - Model IotAlertModel has a new parameter id
info	[Changelog]   - Model SecurityAssessmentMetadata has a new parameter categories
info	[Changelog]   - Added operation IotSensorsOperations.download_reset_password
info	[Changelog]   - Added operation IotSensorsOperations.trigger_ti_package_update
info	[Changelog]   - Added operation OnPremiseIotSensorsOperations.download_reset_password
info	[Changelog]   - Added operation IotDefenderSettingsOperations.download_manager_activation
info	[Changelog]   - Added operation AlertsOperations.update_resource_group_level_state_to_dismiss
info	[Changelog]   - Added operation AlertsOperations.list_subscription_level_by_region
info	[Changelog]   - Added operation AlertsOperations.get_subscription_level
info	[Changelog]   - Added operation AlertsOperations.update_resource_group_level_state_to_activate
info	[Changelog]   - Added operation AlertsOperations.update_subscription_level_state_to_dismiss
info	[Changelog]   - Added operation AlertsOperations.get_resource_group_level
info	[Changelog]   - Added operation AlertsOperations.list_resource_group_level_by_region
info	[Changelog]   - Added operation AlertsOperations.simulate
info	[Changelog]   - Added operation AlertsOperations.update_subscription_level_state_to_activate
info	[Changelog]   - Added operation group IotSitesOperations
info	[Changelog]   - Added operation group IngestionSettingsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation IotSensorsOperations.create_or_update has a new signature
info	[Changelog]   - Model SecurityAssessmentMetadataProperties no longer has parameter category
info	[Changelog]   - Model IotDefenderSettingsModel has a new required parameter onboarding_kind
info	[Changelog]   - Model SecurityAssessmentMetadata no longer has parameter category
info	[Changelog]   - Operation IotDefenderSettingsOperations.create_or_update has a new signature
info	[Changelog]   - Removed operation AlertsOperations.list_subscription_level_alerts_by_region
info	[Changelog]   - Removed operation AlertsOperations.list_resource_group_level_alerts_by_region
info	[Changelog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state_to_dismiss
info	[Changelog]   - Removed operation AlertsOperations.update_subscription_level_alert_state_to_dismiss
info	[Changelog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state_to_reactivate
info	[Changelog]   - Removed operation AlertsOperations.get_resource_group_level_alerts
info	[Changelog]   - Removed operation AlertsOperations.get_subscription_level_alert
info	[Changelog]   - Removed operation AlertsOperations.update_subscription_level_alert_state_to_reactivate

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f3f9da. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/security/resource-manager/readme.md

️✔️@azure/arm-security [View full logs] [Release SDK Changes]

azure-arm-security-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
cmderr	[npmPack] created ./dist/arm-security.js in 1.4s

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 2f3f9da. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:3067) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2019-01-01-preview/Microsoft.Security.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:3067) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:3067) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

️✔️security [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

...ty/preview/2021-01-15-preview/examples/IngestionSettings/DeleteIngestionSetting_example.json

...curity/resource-manager/Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json

chlahav · 2021-05-12T17:24:01Z

...curity/resource-manager/Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json

+          "200": {
+            "description": "OK",
+            "schema": {
+              "$ref": "#/definitions/IngestionSetting"


at least make these 2 different object types in here (no need to change server side code), just to make the documentation clearer without any change to the working API

...curity/resource-manager/Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json

pilor · 2021-05-13T17:32:53Z

Please go through and complete the checklist in the PR description

openapi-workflow-bot · 2021-05-13T19:00:04Z

Hi, @kunchawla your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @leni-msft

...curity/resource-manager/Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json

specification/security/resource-manager/readme.md

* New Microsoft.Security proxy rp type of ingestionSettings * PR feedback * Feedback * Fix check error * PR Feedback for list tokens * Fix example description * Remove suppressions from readme.md Co-authored-by: Kunal Chawla <[email protected]>

New Microsoft.Security proxy rp type of ingestionSettings

c9022ba

kunchawla requested review from chlahav and AddySanto May 4, 2021 05:12

openapi-assignment-bot bot assigned ruowan May 4, 2021

openapi-pipeline-app bot added CI-BreakingChange-Python CI-BreakingChange-Go labels May 4, 2021

ruowan assigned leni-msft and unassigned ruowan May 6, 2021

chlahav requested changes May 11, 2021

View reviewed changes

PR feedback

3b3e04a

chlahav approved these changes May 12, 2021

View reviewed changes

Feedback

baa3075

chlahav approved these changes May 12, 2021

View reviewed changes

Fix check error

91495e2

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 13, 2021

pilor self-requested a review May 14, 2021 18:46

pilor reviewed May 14, 2021

View reviewed changes

...curity/resource-manager/Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json Outdated Show resolved Hide resolved

...curity/resource-manager/Microsoft.Security/preview/2021-01-15-preview/ingestionSettings.json Outdated Show resolved Hide resolved

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 14, 2021

PR Feedback for list tokens

1674c83

pilor removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 14, 2021

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 14, 2021

leni-msft reviewed May 17, 2021

View reviewed changes

specification/security/resource-manager/readme.md Show resolved Hide resolved

Kunal Chawla added 2 commits May 17, 2021 20:59

Fix example description

bc80591

Remove suppressions from readme.md

5d045a5

leni-msft merged commit 2f3f9da into Azure:master May 18, 2021

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Microsoft.Security proxy rp type of ingestionSettings #14226

New Microsoft.Security proxy rp type of ingestionSettings #14226

kunchawla commented May 4, 2021 •

edited

Loading

openapi-workflow-bot bot commented May 4, 2021

openapi-pipeline-app bot commented May 4, 2021 •

edited

Loading

openapi-workflow-bot bot commented May 4, 2021

openapi-pipeline-app bot commented May 4, 2021 •

edited

Loading

Breaking Changes Tracking

chlahav May 12, 2021

pilor commented May 13, 2021

openapi-workflow-bot bot commented May 13, 2021

New Microsoft.Security proxy rp type of ingestionSettings #14226

New Microsoft.Security proxy rp type of ingestionSettings #14226

Conversation

kunchawla commented May 4, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 4, 2021

openapi-pipeline-app bot commented May 4, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented May 4, 2021

openapi-pipeline-app bot commented May 4, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

chlahav May 12, 2021

Choose a reason for hiding this comment

pilor commented May 13, 2021

openapi-workflow-bot bot commented May 13, 2021

kunchawla commented May 4, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 4, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 4, 2021 •

edited

Loading