Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid container names in examples. #14190

Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix invalid container names in examples. #14190

merged 1 commit into from
Jun 10, 2021

Conversation

rikogeln
Copy link
Member

Azure Blob Storage container names are not allowed to have upper case letters

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      • Fix for invalid example values

  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
    no api change - change only in example values

  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
    as soon as convenient

  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

@openapi-workflow-bot
Copy link

Hi, @rikogeln Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 29, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"mixedreality/data-plane/readme.md",
    "tag":"package-2021-01-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"mixedreality/data-plane/readme.md",
    "tag":"package-2021-01-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"mixedreality/data-plane/readme.md",
    "tag":"package-2021-01-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"mixedreality/data-plane/readme.md",
    "tag":"package-2021-01-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"mixedreality/data-plane/readme.md",
    "tag":"package-2021-01-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 29, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    Posted by Swagger Pipeline | How to fix these errors?

    @rikogeln rikogeln force-pushed the user/rikogeln/fixsamples branch from 8c311ce to 2609798 Compare April 29, 2021 14:05
    @rikogeln
    fix invalid container names in examples. Azure Blob Storage container…
    d396cd2 
    … names are not allowed to have upper case letters
    @rikogeln rikogeln force-pushed the user/rikogeln/fixsamples branch from 2609798 to d396cd2 Compare April 29, 2021 14:17
    @rikogeln
    Copy link
    Member Author

    rikogeln commented May 4, 2021

    @anuchandy could you take a look?

    @rikogeln
    Copy link
    Member Author

    rikogeln commented May 7, 2021

    @anuchandy could you please take a look?

    1 similar comment
    @rikogeln
    Copy link
    Member Author

    @anuchandy could you please take a look?

    @ghost
    Copy link

    ghost commented Jun 6, 2021

    Hi, @rikogeln. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @markweitzel markweitzel added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jun 10, 2021
    @rikogeln
    Copy link
    Member Author

    @JeffreyRichter - thanks for approving the PR. I am not authorized to merge the pull request - can you do so please?

    @JeffreyRichter
    Copy link
    Member

    @anuchandy can merge

    @jhendrixMSFT jhendrixMSFT merged commit 297c086 into Azure:master Jun 10, 2021
    @markweitzel markweitzel added AzureAPIBoardSignedOff and removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Jun 10, 2021
    @heaths heaths mentioned this pull request Jun 16, 2021
    Merged
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    @rikogeln
    fix invalid container names in examples. Azure Blob Storage container…
    b124162 
    … names are not allowed to have upper case letters (Azure#14190)
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @rikogeln @mkarmark
    fix invalid container names in examples. Azure Blob Storage container…
    d905525 
    … names are not allowed to have upper case letters (Azure#14190)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    Assignees

    @anuchandy anuchandy

    Labels
    AzureAPIBoardSignedOff
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @rikogeln @JeffreyRichter @jhendrixMSFT @markweitzel @anuchandy