Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Public private branch 'master' #14125

Merged
merged 37 commits into from
May 28, 2021

Conversation

samuelkuangms
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 13, 2021
@lirenhe
Copy link
Member

lirenhe commented May 17, 2021

@samuelkuangms, please resolve the conflicts of your PR otherwise, tool check could not start.

@lirenhe lirenhe added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label May 17, 2021
…into published/samuelkuangms/azure-rest-api-specs-pr/master
@openapi-workflow-bot
Copy link

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 24, 2021
…into published/samuelkuangms/azure-rest-api-specs-pr/master
@lirenhe lirenhe merged commit b02a0b6 into master May 28, 2021
@lirenhe lirenhe removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label May 28, 2021
@samuelkuangms samuelkuangms deleted the published/samuelkuangms/azure-rest-api-specs-pr/master branch May 28, 2021 05:13
mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
* Swager specs for Sentinel Source Control RP API

* Remove unnecessary space.

* Fix avocado

* Fix SemanticValidation-Error

* Fix LintDiff

* add new api and change api version

* correct some merge error

* merge to master

* Avoid breaking change

* Add RepoList definition.

* Fix prettier issue.

* Fix prettier issue.

* Fix model validation issue.

* Fix model validation issue.

* Fix SDK Track2 validation.

* Reference common ResourceWithEtag.

* Fix LintDiff issue.

* Fix LintDiff issue.

* repository properties.

* fix regression.

* Fix reference.

* Fix lintDiff issue.

* using POST command instead of GET to retrieve repository metadata

* Fix ModelValidation error.

* Incorporate comments.

* remove duplicate systemData in SourceControl.

* add POST verb.

* Revert an unnecessary change.

* Fix error caused by merging.

* Revert an unreviewed change.

* Update API response.

* Fix typo.

* Update swagger definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants