Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Add 2021-04-01 SRP api version #14038

Closed
wants to merge 120 commits into from

Conversation

HimanshuChhabra
Copy link
Member

@HimanshuChhabra HimanshuChhabra commented Apr 20, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @HimanshuChhabra Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @HimanshuChhabra, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    … share with leased snapshot; lease share; share ACLs; list both deleted shares and snapshots; allow cross tenant replication; default share permission)
    litchiyangMSFT and others added 4 commits April 21, 2021 07:57
    * Add webpubsub swagger
    
    Add custom words
    
    Update webpubsub.json
    
    Update webpubsub.json
    
    Resolve comments
    
    Update webpubsub.json
    
    resolve comments
    
    Update operationId for existence check
    
    [wps] update python generation section and client name for all languages (#1)
    
    * add python stuff
    
    * make title across languages the same
    
    * Update version
    
    * Update some constraints
    
    * Update webpubsub.json
    
    * rename to GetServiceStatus
    
    * Update readme.md
    
    * Update readme.md
    
    * Update readme.md
    …version preview/2021-03-01-preview (Azure#13563)
    
    * Copied from 2019-01-01-preview version
    
    * Updated references to common types
    
    * Add itemsSearchKey field to Watchlists
    
    * Add missing label definition
    
    * Make itemsSearchKey as required field
    
    * Formatting fixes
    
    * Fix Prettier and Avocado errors
    
    * Fix Lint error (subscription level resource)
    
    * Update description and example for CreateOrUpdate watchlists and bulk create watchlist items
    
    * Update Api version in examples
    …version stable/2021-03-01 (Azure#13888)
    
    * Adds base for updating Microsoft.RecoveryServices from version stable/2021-01-01 to version 2021-03-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * updated default package in readme.md to 2021-03
    
    Co-authored-by: Chandrika Gonuguntla <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Go Storage Storage Service (Queues, Blobs, Files) WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.