-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Microsoft.Synapse/workspace/eventstreams resource #13714
Conversation
Hi, @dsouzaarun Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=204429&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" |
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from eba58afce7c6bffd8996e30cbd54f4409ac18a18. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
️✔️
@azure/arm-synapse [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js... cmderr [npmPack] created ./dist/arm-synapse.js in 1.1s
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from eba58afce7c6bffd8996e30cbd54f4409ac18a18. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
synapse/mgmt/2020-12-01/synapse [View full logs] [Preview SDK Changes]info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `LibrariesClient.ListByWorkspaceComplete(context.Context, string, string) (LibraryListResponseIterator, error)` info [Changelog] - New function `*LibraryListResponseIterator.NextWithContext(context.Context) error` info [Changelog] - New function `NewLibraryClient(string) LibraryClient` info [Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)` info [Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse` info [Changelog] - New function `LibraryListResponseIterator.NotDone() bool` info [Changelog] - New function `NewLibrariesClient(string) LibrariesClient` info [Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)` info [Changelog] - New function `*LibraryListResponseIterator.Next() error` info [Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient` info [Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse` info [Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource` info [Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator` info [Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource` info [Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)` info [Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error` info [Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient` info [Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error` info [Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)` info [Changelog] - New function `*LibraryListResponsePage.Next() error` info [Changelog] - New function `LibraryListResponse.IsEmpty() bool` info [Changelog] - New function `LibraryListResponsePage.NotDone() bool` info [Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage` info [Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)` info [Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)` info [Changelog] - New function `LibraryClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New struct `LibrariesClient` info [Changelog] - New struct `LibraryClient` info [Changelog] - New struct `LibraryListResponse` info [Changelog] - New struct `LibraryListResponseIterator` info [Changelog] - New struct `LibraryListResponsePage` info [Changelog] - New struct `LibraryResource` info [Changelog] info [Changelog] Total 0 breaking change(s), 40 additive change(s). info [Changelog]
- Only show 60 items here, please refer to log for details.
️✔️
preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New function `*MaintenanceWindowOptions.UnmarshalJSON([]byte) error` info [Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.UpdateResponder(*http.Response) (autorest.Response, error)` info [Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `DataMaskingRulesClient.GetResponder(*http.Response) (DataMaskingRule, error)` info [Changelog] - New function `RecommendedSensitivityLabelUpdate.MarshalJSON() ([]byte, error)` info [Changelog] - New function `NewPrivateLinkHubPrivateLinkResourcesClient(string) PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)` info [Changelog] - New function `DataMaskingRulesClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateResponder(*http.Response) (autorest.Response, error)` info [Changelog] - New function `PossibleSensitivityLabelUpdateKindValues() []SensitivityLabelUpdateKind` info [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.GetResponder(*http.Response) (PrivateLinkResource, error)` info [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.List(context.Context, string, string) (PrivateLinkResourceListResultPage, error)` info [Changelog] - New function `NewSQLPoolMaintenanceWindowOptionsClient(string) SQLPoolMaintenanceWindowOptionsClient` info [Changelog] - New function `NewSQLPoolRecommendedSensitivityLabelsClientWithBaseURI(string, string) SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `NewPrivateLinkHubPrivateLinkResourcesClientWithBaseURI(string, string) PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdateResponder(*http.Response) (GeoBackupPolicy, error)` info [Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdate(context.Context, string, string, string, string, MaintenanceWindows) (autorest.Response, error)` info [Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdatePreparer(context.Context, string, string, string, GeoBackupPolicy) (*http.Request, error)` info [Changelog] - New function `SQLPoolSensitivityLabelsClient.Update(context.Context, string, string, string, SensitivityLabelUpdateList) (autorest.Response, error)` info [Changelog] - New function `LibraryInfo.MarshalJSON() ([]byte, error)` info [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListResponder(*http.Response) (PrivateLinkResourceListResult, error)` info [Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)` info [Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdatePreparer(context.Context, string, string, string, SensitivityLabelUpdateList) (*http.Request, error)` info [Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdateResponder(*http.Response) (autorest.Response, error)` info [Changelog] - New struct `DynamicExecutorAllocation` info [Changelog] - New struct `LibraryInfo` info [Changelog] - New struct `MaintenanceWindowOptions` info [Changelog] - New struct `MaintenanceWindowOptionsProperties` info [Changelog] - New struct `MaintenanceWindowTimeRange` info [Changelog] - New struct `MaintenanceWindows` info [Changelog] - New struct `MaintenanceWindowsProperties` info [Changelog] - New struct `ManagedVirtualNetworkReference` info [Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New struct `RecommendedSensitivityLabelUpdate` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateList` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties` info [Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient` info [Changelog] - New struct `SQLPoolMaintenanceWindowsClient` info [Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New struct `SensitivityLabelUpdate` info [Changelog] - New struct `SensitivityLabelUpdateList` info [Changelog] - New struct `SensitivityLabelUpdateProperties` info [Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties` info [Changelog] - New field `Rank` in struct `SensitivityLabelProperties` info [Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties` info [Changelog] - New field `TableName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime` info [Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties` info [Changelog] - New field `ManagedBy` in struct `SensitivityLabel` info [Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties` info [Changelog] info [Changelog] Total 1 breaking change(s), 119 additive change(s). info [Changelog]
️❌
azure-sdk-for-net failed [Detail]
❌
Failed [Logs] Generate from eba58afce7c6bffd8996e30cbd54f4409ac18a18. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
❌
Microsoft.Azure.Management.Synapse [View full logs] [Preview SDK Changes]cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/build.proj : error MSB4057: The target "CreateNugetPackage" does not exist in the project. cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/build.proj : error MSB4057: The target "CreateNugetPackage" does not exist in the project. error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️️✔️
azure-resource-manager-schemas succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from eba58afce7c6bffd8996e30cbd54f4409ac18a18. Schema Automation 14.0.0warn Skip initScript due to not configured command npx n 12 command autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
️✔️
synapse [View full logs] [Preview Schema Changes]cmderr [resource-manager] node-pre-gyp cmderr [resource-manager] WARN Using request for node-pre-gyp https download cmderr [resource-manager] [email protected] No repository field. cmderr [resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents): cmderr [resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️⚠️
azure-sdk-for-java warning [Detail]
⚠️
Warning [Logs] Generate from eba58afce7c6bffd8996e30cbd54f4409ac18a18. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-03-30 01:38:31 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-synapse" cmderr [generate.py] 2021-03-30 01:38:31 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-03-30 01:38:31 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [generate.py] 2021-03-30 01:39:55 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-03-30 01:39:55 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-03-30 01:39:55 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-03-30 01:39:55 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-03-30 01:39:55 INFO [POM][Skip] pom already has module sdk/synapse cmderr [generate.py] 2021-03-30 01:39:55 INFO [POM][Success] Write to root pom
️✔️
azure-resourcemanager-synapse [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-synapse-1.0.0-beta.1.jar
- azure-resourcemanager-synapse-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-synapse-1.0.0-beta.1-sources.jar
cmderr [Inst] 2021-03-30 01:44:17 DEBUG Got artifact_id: azure-resourcemanager-synapse cmderr [Inst] 2021-03-30 01:44:17 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-03-30 01:44:17 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.1.jar cmderr [Inst] 2021-03-30 01:44:17 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.1.jar cmderr [Inst] 2021-03-30 01:44:17 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13714/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.1.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️
azure-sdk-for-python warning [Detail]
⚠️
Warning [Logs] Generate from eba58afce7c6bffd8996e30cbd54f4409ac18a18. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️
azure-mgmt-synapse [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model WorkspacePatchInfo has a new parameter network_settings info [Changelog] - Model Workspace has a new parameter network_settings info [Changelog] - Added operation group LibraryOperations info [Changelog] - Added operation group LibrariesOperations
Hi @dsouzaarun, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@dsouzaarun could you fix the avocado errors which mean there are unused example files, do you forget to refer these files in your swagger ? |
I'll reopen this PR after making some more changes |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.